Skip to content

PEReader doesn't work with "IsLoadedImage" and "PrefetchMetadata" options - #80106

Merged
buyaa-n merged 3 commits into
dotnet:mainfrom
pedrobsaila:76648
Jan 13, 2023
Merged

PEReader doesn't work with "IsLoadedImage" and "PrefetchMetadata" options#80106
buyaa-n merged 3 commits into
dotnet:mainfrom
pedrobsaila:76648

Conversation

@pedrobsaila

@pedrobsailapedrobsaila commented Jan 2, 2023

Copy link
Copy Markdown
Contributor

Fixes#76648

@ghostghost added area-System.Reflection.Metadata community-contribution Indicates that the PR has been added by a community member labels Jan 2, 2023
@ghost

ghost commented Jan 2, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #76648

Author:pedrobsaila
Assignees:-
Labels:

area-System.Reflection.Metadata

Milestone:-

@build-analysisbuild-analysisBot mentioned this pull request Jan 3, 2023
Closed
MartyIX
MartyIX reviewed Jan 3, 2023
View reviewed changes
Comment threadsrc/libraries/System.Reflection.Metadata/tests/PortableExecutable/PEReaderTests.cs Outdated
buyaa-n
buyaa-n reviewed Jan 12, 2023
View reviewed changes
Comment threadsrc/libraries/System.Reflection.Metadata/tests/PortableExecutable/PEReaderTests.cs Outdated
buyaa-n
buyaa-n reviewed Jan 12, 2023
View reviewed changes
Comment threadsrc/libraries/System.Reflection.Metadata/tests/PortableExecutable/PEReaderTests.cs Outdated
buyaa-n
buyaa-n reviewed Jan 12, 2023
View reviewed changes
Comment threadsrc/libraries/System.Reflection.Metadata/tests/PortableExecutable/PEReaderTests.cs Outdated
@buyaa-n@MartyIX
Apply suggestions from code review
af95f1c
Co-authored-by: MartyIX <203266+MartyIX@users.noreply.github.com>
@build-analysisbuild-analysisBot mentioned this pull request Jan 12, 2023
Closed
buyaa-n
buyaa-n reviewed Jan 12, 2023
View reviewed changes
Comment threadsrc/libraries/System.Reflection.Metadata/tests/PortableExecutable/PEReaderTests.cs Outdated
buyaa-n
buyaa-n reviewed Jan 12, 2023
View reviewed changes
Comment threadsrc/libraries/System.Reflection.Metadata/tests/PortableExecutable/PEReaderTests.cs Outdated
@build-analysisbuild-analysisBot mentioned this pull request Jan 12, 2023
Closed
buyaa-n
buyaa-n approved these changes Jan 13, 2023
View reviewed changes

@buyaa-nbuyaa-n left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @pedrobsaila!

@buyaa-n
buyaa-n merged commit 8823520 into dotnet:mainJan 13, 2023
@pedrobsaila
pedrobsaila deleted the 76648 branch January 14, 2023 11:10
@ghostghost locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@MartyIXMartyIXMartyIX left review comments
@buyaa-nbuyaa-nbuyaa-n approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.Reflection.Metadatacommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PEReader doesn't work with "IsLoadedImage" and "PrefetchMetadata" options

4 participants

@pedrobsaila@MartyIX@buyaa-n@steveharter