Uh oh!
There was an error while loading. Please reload this page.
Remove duplicate android and wasm yaml templates to run the runtime tests after a "global-build" build step. - #80157
Conversation
…ests after a "global-build" build step.
jkoritzinsky
commented
Jan 4, 2023
/azp list |
ghost
commented
Jan 4, 2023
Tagging subscribers to this area: @directhex Issue DetailsI'm planning on utilizing this template in #74623 with CoreCLR and I noticed that we had two very similar copies. I figured it was a good idea to collapse them into a single copy and make it work for CoreCLR for at least simple cases.
|
jkoritzinsky
commented
Jan 4, 2023
/azp run runtime-android, runtime-androidemulator |
|
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
jkoritzinsky
commented
Jan 4, 2023
/azp run runtime-android, runtime-androidemulator |
|
Azure Pipelines successfully started running 2 pipeline(s). |
I merged the wasm template into build-runtime-tests-and-send-to-helix.yml but I guess I didn't think to also merge in the android one. Thanks for cleaning that up. |
jkoritzinsky
commented
Jan 4, 2023
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkoritzinsky
commented
Jan 4, 2023
Failure is #79874. Merging this in to unblock my other work. |
Recognize SUB(CheckedBound, X) <relop> CNS patterns in assertion propagation and extend MergeEdgeAssertions to handle signed comparisons where op1VN is ADD(normalLclVN, constant). This enables the JIT to eliminate redundant bounds checks when user code performs manual bounds checking like: if ((index < 0) || ((array.Length - index) < 2)) throw; return (array[index], array[index + 1]); Fixes#80157 Co-authored-by: EgorBo <523221+EgorBo@users.noreply.github.com>
I'm planning on utilizing this template in #74623 with CoreCLR and I noticed that we had two very similar copies. I figured it was a good idea to collapse them into a single copy and make it work for CoreCLR for at least simple cases.