Skip to content

Lowercase TargetOS - #80164

Merged
ViktorHofer merged 3 commits into
dotnet:mainfrom
ViktorHofer:LowercaseTargetOS
Jan 11, 2023
Merged

Lowercase TargetOS#80164
ViktorHofer merged 3 commits into
dotnet:mainfrom
ViktorHofer:LowercaseTargetOS

Conversation

@ViktorHofer

@ViktorHoferViktorHofer commented Jan 4, 2023

Copy link
Copy Markdown
Member

Follow-up on #32451 (comment)
Follow-up on #80074

In #43651, the "Windows" OS name was lowercased to achieve target frameworks with RIDs in them. At that time, the original plan was to lowercase all TargetOS values but that had to be cut because of resources. This PR finishes that and updates build systems, YML, markdowns and managed components.

To not break existing developer workflows, the passed-in -os value is automatically lower-cased in the script entry points and validated in the msbuild entry point.

This change was performed via

  1. Manual "Find & Replace"**: <OS> -> <os> for all the possible OS values that we support (i.e. Browser -> browser) in msbuild, cmake, docs, etc.
  2. Trial & Error to fix build failures
  3. Looking through all the commits that went in between the Find & Replace was performed and now (Jan 10th) and performing the same operation again

@ghostghost assigned ViktorHoferJan 4, 2023
@ghost

ghost commented Jan 4, 2023

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ViktorHofer

Copy link
Copy Markdown
MemberAuthor

/azp list

@azure-pipelines

Copy link
Copy Markdown
CI/CD Pipelines for this repository:

@ViktorHofer

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ViktorHoferViktorHofer changed the title [WIP] Lowercase TargetOSLowercase TargetOSJan 5, 2023
@ViktorHofer
ViktorHoferforce-pushed the LowercaseTargetOS branch 3 times, most recently from 376ad4c to acff22eCompareJanuary 10, 2023 14:56
Comment threadeng/native/build-commons.sh Outdated
Comment threadeng/native/gen-buildsys.sh Outdated
Comment threadeng/native/init-os-and-arch.sh Outdated
Comment threadsrc/mono/CMakeLists.txt Outdated
@ViktorHofer
ViktorHofer merged commit 2ca7cf7 into dotnet:mainJan 11, 2023
@ViktorHofer
ViktorHofer deleted the LowercaseTargetOS branch January 11, 2023 16:58
@EgorBo

EgorBo commented Jan 11, 2023

Copy link
Copy Markdown
Member

Just updated my local main:

image

I assume it needs git clean -ffddxx ?

@ViktorHofer

Copy link
Copy Markdown
MemberAuthor

Sorry for the inconvenience and thanks for reporting. Just submitted a fix: #80544

@ghostghost locked as resolved and limited conversation to collaborators Feb 11, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ViktorHofer@EgorBo@akoeplinger