') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [draft][browser] enable closure compiler for dotnet.js by pavelsavara · Pull Request #80178 · dotnet/runtime · GitHub
Skip to content

[draft][browser] enable closure compiler for dotnet.js - #80178

Closed
pavelsavara wants to merge 9 commits into
dotnet:mainfrom
pavelsavara:browser_closure
Closed

[draft][browser] enable closure compiler for dotnet.js#80178
pavelsavara wants to merge 9 commits into
dotnet:mainfrom
pavelsavara:browser_closure

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Jan 4, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#51524

emcc --closure 1

Release size reduction of dotnet.js
from 338118 to 274571 = 63547

7kb difference after brotli compression

@pavelsavarapavelsavara added this to the 8.0.0 milestone Jan 4, 2023
@pavelsavarapavelsavara self-assigned this Jan 4, 2023
@ghost

ghost commented Jan 4, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Release size reduction of dotnet.js
from 338118 to 274571 = 63547

Author:pavelsavara
Assignees:pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone:8.0.0

@pavelsavarapavelsavara mentioned this pull request Jan 4, 2023
Closed
@pavelsavara

pavelsavara commented Jan 5, 2023

Copy link
Copy Markdown
MemberAuthor

image

7kb after brotli compression

@pavelsavara

pavelsavara commented Jan 5, 2023

Copy link
Copy Markdown
MemberAuthor

With compilation_level=SIMPLE_OPTIMIZATIONS there is middle ground result.
uncompressed 310860 and 70321 brotli

ilonatommy
ilonatommy reviewed Jan 11, 2023
View reviewed changes
Comment threadsrc/mono/wasm/runtime/es6/dotnet.es6.lib.js
@pavelsavara

pavelsavara commented Jan 17, 2023

Copy link
Copy Markdown
MemberAuthor

I should consider SIMPLE_OPTIMIZATIONS as default.

@runfoapprunfoappBot mentioned this pull request Jan 17, 2023
Closed
@pavelsavara

pavelsavara commented Jan 19, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jan 19, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara

pavelsavara commented Jan 19, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@ghost

ghost commented Jan 19, 2023

Copy link
Copy Markdown

Fixes #51524

emcc --closure 1

Release size reduction of dotnet.js from 338118 to 274571 = 63547

7kb difference after brotli compression

@build-analysisbuild-analysisBot mentioned this pull request Jan 19, 2023
Closed
@pavelsavara

pavelsavara commented Jan 24, 2023

Copy link
Copy Markdown
MemberAuthor

Closing for now. We would have to ship Java as part of the wasm-tools workload.

@ghostghost locked as resolved and limited conversation to collaborators Jun 5, 2023
@pavelsavara
pavelsavara deleted the browser_closure branch September 2, 2024 15:29
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ilonatommyilonatommyilonatommy left review comments
@marafmarafAwaiting requested review from marafmaraf is a code owner
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger will be requested when the pull request is marked ready for reviewakoeplinger is a code owner
@lewinglewingAwaiting requested review from lewinglewing will be requested when the pull request is marked ready for reviewlewing is a code owner
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@pavelsavarapavelsavara

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScript

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

[browser] Enable closure compiler for dotnet.native.js

2 participants

@pavelsavara@ilonatommy