Skip to content

[release/7.0] fix wasm timestamp test by adding 10M tolerance - #80250

Merged
carlossanlop merged 2 commits into
release/7.0from
backport/pr-74317-to-release/7.0
Jan 6, 2023
Merged

[release/7.0] fix wasm timestamp test by adding 10M tolerance#80250
carlossanlop merged 2 commits into
release/7.0from
backport/pr-74317-to-release/7.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Jan 5, 2023•
edited by carlossanlop
Loading

Copy link
Copy Markdown
Contributor

Backport of #74317 to release/7.0

/cc @carlossanlop@danmoseley

Customer Impact

None. Test fix only.

Testing

Already fixed and merged in main. Need this backported to 7.0 because it's intermittently happening. Saw it here: #78830

Risk

Low. Test fix only.

@ghostghost added the area-System.IO label Jan 5, 2023
@ghost

ghost commented Jan 5, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #74317 to release/7.0

/cc @carlossanlop@danmoseley

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-System.IO

Milestone:-

@carlossanlopcarlossanlop added the arch-wasm WebAssembly architecture label Jan 5, 2023
@ghost

ghost commented Jan 5, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #74317 to release/7.0

/cc @carlossanlop@danmoseley

Customer Impact

None. Test fix only.

Testing

Already fixed and merged in main. Need this backported to 7.0 because it's intermittently happening. Saw it here: #78830

Risk

Low. Test fix only.

Author:github-actions[bot]
Assignees:-
Labels:

arch-wasm, area-System.IO

Milestone:-

@carlossanlopcarlossanlop self-assigned this Jan 5, 2023
@carlossanlopcarlossanlop added this to the 7.0.3 milestone Jan 5, 2023
@carlossanlopcarlossanlop mentioned this pull request Jan 6, 2023
Closed
@carlossanlop

carlossanlop commented Jan 6, 2023

Copy link
Copy Markdown
Contributor

CI failure is unrelated: #80284

@carlossanlop
carlossanlop merged commit dc7302e into release/7.0Jan 6, 2023
@carlossanlop
carlossanlop deleted the backport/pr-74317-to-release/7.0 branch January 6, 2023 04:28
@ghostghost locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical approved these changes
@lewinglewingAwaiting requested review from lewing
@steveisoksteveisokAwaiting requested review from steveisok
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
@jozkeejozkeeAwaiting requested review from jozkee
@adamsitnikadamsitnikAwaiting requested review from adamsitnik

Assignees

@carlossanlopcarlossanlop

Labels

arch-wasmWebAssembly architecturearea-System.IO

Projects

None yet

Milestone

7.0.3

Development

Successfully merging this pull request may close these issues.

2 participants

@carlossanlop@radical