Uh oh!
There was an error while loading. Please reload this page.
[wasm] Enable dedup by default. - #80260
Merged
Merged
Conversation
vargaz
commented
Jan 5, 2023
ContributorAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
requested review from
BrzVlad, SamMonoRT, lambdageek, lewing, marek-safar and pavelsavara
as code ownersJanuary 6, 2023 00:59
vargaz
commented
Jan 6, 2023
ContributorAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tannergooding
commented
Jan 6, 2023
Member
Should be unblocked now. Closing and reopening the PR should retrigger CI with the updated main. |
vargaz
commented
Jan 6, 2023
ContributorAuthor
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
commented
Jan 6, 2023
ContributorAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lewing
commented
Jan 6, 2023
Member
Looked like the tests failed because the TupleElementNamesAttribute wasn't preserved? |
vargaz
commented
Jan 6, 2023
ContributorAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
marked this pull request as draft
January 10, 2023 05:19
vargaz
commented
Jan 10, 2023
ContributorAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
commented
Jan 13, 2023
ContributorAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
commented
Jan 14, 2023
ContributorAuthor
The WasmBuildTests failure looks relevant. |
vargazforce-pushed
the
wasm-dedup-enable
branch
from
January 15, 2023 03:20
0cec0e6 to
408a7c2Comparevargaz
commented
Jan 15, 2023
ContributorAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
commented
Jan 15, 2023
ContributorAuthor
/azp run runtime-wasm |
2 similar comments
vargaz
commented
Jan 15, 2023
ContributorAuthor
/azp run runtime-wasm |
vargaz
commented
Jan 15, 2023
ContributorAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 similar comments
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
.. copied to `aot-in` for the compilation step. Example: - when using WasmDedup=true, we get the main assemblies in `publish` directory after linking, but `aot-instances.dll` is in different directory. - this causes `MonoAOTCompiler` to copy all of them to a temporary `aot-in` dir for compiling with `mono-aot-cross`. - And when the output items are set, we get: ``` Output Item(s): _WasmAssembliesInternal= obj/Debug/net8.0/browser-wasm/wasm/for-publish/aot-in/Debug_u4nbxx3i.gc5.dll LlvmBitcodeFile=obj/Debug/net8.0/browser-wasm/wasm/for-publish/Debug_u4nbxx3i.gc5.dll.bc ``` - here the `ItemSpec` is incorrectly set to the temporary `aot-in` path - which can cause build failures in the following build steps
radical
commented
Jan 18, 2023
Member
Pushed a fix for the WBT failure. |
vargaz
commented
Jan 18, 2023
ContributorAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lewing
approved these changes
Jan 18, 2023
lewing
commented
Jan 18, 2023
Member
wbt are green and the build fix makes sense |
vargaz
marked this pull request as ready for review
January 18, 2023 05:50
vargaz
commented
Jan 18, 2023
Uh oh!
There was an error while loading. Please reload this page.
vargaz
commented
Jan 18, 2023
ContributorAuthor
Failures are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.