Skip to content

[release/7.0] Fixing compressed singlefile scenario on osx-arm64 - #80283

Merged
carlossanlop merged 5 commits into
release/7.0from
backport/pr-79894-to-release/7.0
Jan 11, 2023
Merged

[release/7.0] Fixing compressed singlefile scenario on osx-arm64#80283
carlossanlop merged 5 commits into
release/7.0from
backport/pr-79894-to-release/7.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Jan 6, 2023•
edited by VSadov
Loading

Copy link
Copy Markdown
Contributor

Backport of #79894 to release/7.0

/cc @VSadov

Customer Impact

When a user creates an app that uses both singlefile and compression and targets osx-arm64, the app cannot run.

Testing

Manual testing of the scenario. Also ran related tests, which this change fixes as well.

Risk

Low. This is a small change.
The root cause was not setting MEM_RESERVE_EXECUTABLE flag for the memory allocated to decompress R2R assemblies.

Since this is on osx-arm64 we need to play by the W^X rules. It is not possible to make writeable memory executable later on osx-arm64, if it does not have this flag when allocated.

@ghostghost added the area-Single-File label Jan 6, 2023
@ghost

ghost commented Jan 6, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @agocke, @vitek-karas, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #79894 to release/7.0

/cc @VSadov

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-Single-File

Milestone:-

@VSadov
VSadov requested a review from janvorliJanuary 6, 2023 02:05
@VSadovVSadov added the Servicing-consider Issue for next servicing release review label Jan 6, 2023
jeffschwMSFT
jeffschwMSFT approved these changes Jan 6, 2023
View reviewed changes

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 7.0.x

@jeffschwMSFTjeffschwMSFT added this to the 7.0.x milestone Jan 6, 2023
@am11am11 mentioned this pull request Jan 9, 2023
Closed
@jeffschwMSFTjeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 10, 2023
@jeffschwMSFTjeffschwMSFT modified the milestones: 7.0.x, 7.0.3Jan 10, 2023
@carlossanlop

carlossanlop commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

Approved by Tactics (7.0.3).
Signed off by area owners.
No OOB changes needed (native coreclr code).
CI failure unrelated: #80284
Almost ready to merge. Just waiting for the slow Mono crossaot leg to finish. If nothing concerning shows up, I'll merge.

@carlossanlop

carlossanlop commented Jan 11, 2023

Copy link
Copy Markdown
Contributor

The Mono crossaot leg seems to be stuck. I'll merge the PR.

@carlossanlop
carlossanlop merged commit ed6eab9 into release/7.0Jan 11, 2023
@carlossanlop
carlossanlop deleted the backport/pr-79894-to-release/7.0 branch January 11, 2023 05:43
@ghostghost locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeffschwMSFTjeffschwMSFTjeffschwMSFT approved these changes
@janvorlijanvorlijanvorli approved these changes

Assignees

No one assigned

Labels

Servicing-approvedApproved for servicing release

Projects

None yet

Milestone

7.0.3

Development

Successfully merging this pull request may close these issues.

4 participants

@carlossanlop@jeffschwMSFT@janvorli@VSadov