Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] [browser] make dynamic import cancelable - #80312
Conversation
ghost
commented
Jan 6, 2023
Tagging subscribers to 'arch-wasm': @lewing |
carlossanlop
commented
Jan 9, 2023
Removing |
pavelsavara
commented
Jan 11, 2023
The CI fail is unrelated here and re-run didn't help. |
@pavelsavara please make sure to fill out the template explaining how the issue affects customers and how the fix will address it. Once that's done, please send email to Tactics requesting merge approval,. and add the |
carlossanlop
commented
Jan 11, 2023
The CI failure in dev-innerloop is known and unrelated: #80284 |
pavelsavara
commented
Jan 12, 2023
Thanks, I updated the description. |
carlossanlop
commented
Jan 12, 2023
Approved by Tactics via email (7.0.3). |
Backport of #80257 to release/7.0
The underlying dynamic
import()API of the browser is not cancelable.During design of the C# API we added the cancelation token because we do that on all async methods.
We also added the C# code which would cancel/abandon the JS promise.
But we forgot to make the JS promise ready for that.
This PR fixes the omission.
It doesn't really cancel the JS download, nor execution of the module as that's not possible.
But it at least would stop blocking the caller.
Customer Impact
Fixes customer reported issue #80028
Testing
Unit test
Risk
Low, new API in Net7