Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Crash when region survives >2GB - #80392
Merged
Merged
Conversation
ghost
commented
Jan 9, 2023
Tagging subscribers to this area: @dotnet/gc |
mangod9
approved these changes
Jan 10, 2023
Maoni0
requested changes
Jan 10, 2023
Maoni0
left a comment
Member
There was a problem hiding this comment.
this actually doesn't look like it has most of the fix, for example, the part where it changes int to size_t for the survived field?
jeffschwMSFT
approved these changes
Jan 10, 2023
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. we will take for consideration in 7.0.x
mrsharm
marked this pull request as draft
January 10, 2023 16:11
mrsharm
marked this pull request as ready for review
January 10, 2023 17:00
mrsharm
commented
Jan 10, 2023
MemberAuthor
Thanks for the review! This PR is now ready and has been tested by confirming:
|
Maoni0
approved these changes
Jan 10, 2023
mrsharm
commented
Jan 11, 2023
MemberAuthor
Failures don't look related to the changes. |
carlossanlop
commented
Jan 11, 2023
Contributor
Approved by Tactics (7.0.3). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #80302 that fixes#79486
Customer Impact
The impact of this bug is constrained to users who have very large LOH segments where one segment survives more than 2GB - leading to a crash.
Testing
We were able to test locally after consistently repro'ing the issue and proved that the fix took care of the bug.
Risk
Low risk change since it fixes the semantics of a type that was meant to be unsigned (from an int).