Skip to content

Fix Configuration to ensure calling the property setters. - #80438

Merged
tarekgh merged 2 commits into
dotnet:mainfrom
tarekgh:FixPropertyBindingToCallTheSetter
Jan 12, 2023
Merged

Fix Configuration to ensure calling the property setters.#80438
tarekgh merged 2 commits into
dotnet:mainfrom
tarekgh:FixPropertyBindingToCallTheSetter

Conversation

@tarekgh

Copy link
Copy Markdown
Member

#79904

When performing the configuration property binding, we need to ensure calling the property setter (if the property has a setter). The reason is the apps can decide having some logic adjusting the property value inside the setter. This is a fix to a regression introduced in 7.0 release.

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

#79904

When performing the configuration property binding, we need to ensure calling the property setter (if the property has a setter). The reason is the apps can decide having some logic adjusting the property value inside the setter. This is a fix to a regression introduced in 7.0 release.

Author:tarekgh
Assignees:tarekgh
Labels:

area-Extensions-Configuration

Milestone:-

@tarekgh
tarekgh requested a review from halter73January 10, 2023 16:00
@tarekgh

Copy link
Copy Markdown
MemberAuthor

CC @SteveDunn

@eerhardteerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@tarekgh
tarekgh merged commit 2038514 into dotnet:mainJan 12, 2023
@tarekgh

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3904245491

@layomia

Copy link
Copy Markdown
Contributor

LGTM.

@tarekgh

Copy link
Copy Markdown
MemberAuthor

/backport to release/7.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4019814284

@ghostghost locked as resolved and limited conversation to collaborators Feb 26, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tarekgh@layomia@eerhardt