Skip to content

[release/6.0] Fix parsing the output of ping on Samsung phones - #80692

Merged
carlossanlop merged 3 commits into
dotnet:release/6.0from
simonrozsival:backport/pr-80133-to-release/6.0
Jan 17, 2023
Merged

[release/6.0] Fix parsing the output of ping on Samsung phones#80692
carlossanlop merged 3 commits into
dotnet:release/6.0from
simonrozsival:backport/pr-80133-to-release/6.0

Conversation

@simonrozsival

@simonrozsivalsimonrozsival commented Jan 16, 2023•
edited by karelz
Loading

Copy link
Copy Markdown
Member

Backport of #80133 and (older 7.0 fix) #65312 to release/6.0

Fixes#78990

Unlike in #80502, we need to backport #65312 that wasn't originally backported to 6.0.

Customer Impact

Some Android installations contain a ping utility that produces slightly different output when TTL is exceeded from what our code expects. This seems to be the case at least on Samsung phones. This PR updates the parser to account for this variation.

Testing

  • Manual testing on a Samsung phone (API 31) and on Android emulators of various API levels.
  • CI - Android emulator (API 29)

Risk

Low.

rzikmand others added 3 commits January 13, 2023 18:42
@ghostghost added the area-System.Net label Jan 16, 2023
@ghost

ghost commented Jan 16, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #65312 and #80133 to release/6.0

Unlike in #80502, we need to backport #65312 that wasn't originally backported to 6.0.

Customer Impact

Some Android installations contain a ping utility that produces slightly different output when TTL is exceeded from what our code expects. This seems to be the case at least on Samsung phones. This PR updates the parser to account for this variation.

Testing

  • Manual testing on a Samsung phone (API 31) and on Android emulators of various API levels.
  • CI - Android emulator (API 29)

Risk

Low.

Author:simonrozsival
Assignees:-
Labels:

area-System.Net

Milestone:-

@dotnetdotnet deleted a comment from azure-pipelinesBotJan 16, 2023
@simonrozsivalsimonrozsival added this to the 6.0.x milestone Jan 16, 2023
@simonrozsivalsimonrozsival added the Servicing-consider Issue for next servicing release review label Jan 16, 2023
@simonrozsival
simonrozsival marked this pull request as ready for review January 16, 2023 15:19
@build-analysisbuild-analysisBot mentioned this pull request Jan 16, 2023
Closed
wfurt
wfurt approved these changes Jan 16, 2023
View reviewed changes

@wfurtwfurt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbhandarbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 17, 2023
@rbhandarbhanda modified the milestones: 6.0.x, 6.0.13, 6.0.14Jan 17, 2023
@carlossanlop

carlossanlop commented Jan 17, 2023

Copy link
Copy Markdown
Contributor

Approved by Tactics (6.0.14).
Signed off by area owner.
CI failures are unrelated and pre-existing: "No hay más extremos disponibles desde el asignador de extremos." which translates to "No more endpoints available from the endpoint mapper". Seems to affect other PRs, specifically in Windows.10.Amd64.Server2022.ES.Open.
No OOB changes needed for System.Net.Ping (No IsPackable=true).
Ready to merge. :shipit: cc @mmitche

@carlossanlop
carlossanlop merged commit 8e8a6e0 into dotnet:release/6.0Jan 17, 2023
@ghostghost locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wfurtwfurtwfurt approved these changes
@rzikmrzikmAwaiting requested review from rzikm

Assignees

@simonrozsivalsimonrozsival

Labels

area-System.NetServicing-approvedApproved for servicing release

Projects

None yet

Milestone

6.0.14

Development

Successfully merging this pull request may close these issues.

5 participants

@simonrozsival@carlossanlop@wfurt@rbhanda@rzikm