[browser][http] Fix blocking of streaming response and abort by pavelsavara · Pull Request #80693 · dotnet/runtime

pavelsavara · 2023-01-16T13:26:31Z

return bytes of streaming response as soon as available
fix unhandled error in reader.cancel() promise
return cancelable promise from http_wasm_get_streamed_response_bytes
unit test for slowly streamed chunks
unit test for streaming and default cancellation

Fixes#79238
Fixes#80696

Should be merged back to Net7

- return bytes of streaming response as soon as available

ghost · 2023-01-16T13:27:56Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

return bytes of streaming response as soon as available
fix unhandled error in reader.cancel() promise

Fixes #79238
Fixes #80696

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	`arch-wasm`, `area-System.Runtime.InteropServices.JavaScript`
Milestone:	8.0.0

pavelsavara · 2023-01-16T17:51:53Z

/azp run runtime-wasm

azure-pipelines · 2023-01-16T17:52:02Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf

LGTM 👍

pavelsavara · 2023-01-18T11:00:46Z

/azp run runtime-wasm

azure-pipelines · 2023-01-18T11:01:09Z

Azure Pipelines successfully started running 1 pipeline(s).

ilonatommy

👍 I don't have any more ideas for improvement.

pavelsavara · 2023-01-18T12:23:20Z

@hakenr, would you please have time to test it ?

hakenr · 2023-01-18T12:39:32Z

@pavelsavara Yes, I'm happy to test it, I just don't know how to get the new version into my own project. Yes, I'm happy to test it, I just don't know how to get the new version into my own project. Can you please direct me where I can find some instructions?

pavelsavara · 2023-01-18T18:59:07Z

Can you please direct me where I can find some instructions?

I will have to figure it out. My naive attempt to use net8 runtime in net7 blazor project didn't work.
Maybe it would be easier for me to backport it to net7 before we test it with old blazor.

There are NodeJS CI failures which I need to handle first.

Will ping you again, thanks!

pavelsavara · 2023-01-19T11:27:16Z

/azp run runtime-wasm

azure-pipelines · 2023-01-19T11:27:25Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-01-19T17:35:26Z

/backport to release/7.0

github-actions · 2023-01-19T17:35:58Z

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3960939369

github-actions · 2023-01-19T17:38:31Z

@pavelsavara backporting to release/7.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: - fix unhandled error inreader.cancel() promise
Applying: free reader
Applying: fix + test
Applying: test
Applying: test
Applying: feedback
Applying: new testfor streaming abort
error: sha1 information is lacking or useless (src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0007 new testfor streaming abort
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

github-actions · 2023-01-19T17:38:32Z

@pavelsavara an error occurred while backporting to release/7.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

…80693) - return bytes of streaming response as soon as available - fix unhandled error in reader.cancel() promise - return cancelable promise from http_wasm_get_streamed_response_bytes - unit test for slowly streamed chunks - unit test for streaming and default cancellation

- return bytes of streaming response as soon as available - fix unhandled error in reader.cancel() promise - return cancelable promise from http_wasm_get_streamed_response_bytes - unit test for slowly streamed chunks - unit test for streaming and default cancellation

pavelsavara added 2 commits January 16, 2023 14:21

- fix unhandled error in reader.cancel() promise
e74312f
- return bytes of streaming response as soon as available

free reader
9bf6bad

pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript labels Jan 16, 2023

pavelsavara added this to the 8.0.0 milestone Jan 16, 2023

pavelsavara requested a review from maraf January 16, 2023 13:26

pavelsavara self-assigned this Jan 16, 2023

pavelsavara mentioned this pull request Jan 16, 2023
Fix NET 7.0 streamed http response reading #80638
Closed

pavelsavara changed the title ~~[browser][http] Fix bloking of streaming response and abort~~[browser][http] Fix blocking of streaming response and abortJan 16, 2023

pavelsavara added 3 commits January 16, 2023 17:54

fix + test
0778466

test
494d2fa

test
0516f2c

pavelsavara marked this pull request as ready for review January 16, 2023 20:41

pavelsavara requested a review from lewing as a code owner January 16, 2023 20:41

maraf approved these changes Jan 17, 2023
View reviewed changes

ilonatommy reviewed Jan 17, 2023
View reviewed changes

Comment threadsrc/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs
Comment threadsrc/mono/wasm/runtime/http.ts Outdated

feedback
ea02a5f

ilonatommy approved these changes Jan 17, 2023
View reviewed changes

Comment threadsrc/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs

pavelsavara added 2 commits January 17, 2023 22:14

new test for streaming abort
ef66bd6

test + fix streaming cancellation
faa4300

pavelsavara requested review from ilonatommy and maraf January 18, 2023 11:00

maraf reviewed Jan 18, 2023
View reviewed changes

Comment threadsrc/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs
Comment threadsrc/mono/wasm/runtime/http.ts

ilonatommy approved these changes Jan 18, 2023
View reviewed changes

maraf approved these changes Jan 18, 2023
View reviewed changes

improve the test for NodeJS
5021035

pavelsavara merged commit 03db03f into dotnet:mainJan 19, 2023

pavelsavara mentioned this pull request Jan 24, 2023
[release/7.0][browser][http] Fix blocking of streaming response and abort #81092
Merged
2 tasks

ghost locked as resolved and limited conversation to collaborators Feb 18, 2023

pavelsavara deleted the browser_http_stream branch September 2, 2024 15:29

Uh oh!

Conversation

pavelsavara commented Jan 16, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jan 16, 2023

Uh oh!

pavelsavara commented Jan 16, 2023

Uh oh!

azure-pipelinesBot commented Jan 16, 2023

Uh oh!

maraf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pavelsavara commented Jan 18, 2023

Uh oh!

azure-pipelinesBot commented Jan 18, 2023

Uh oh!

Uh oh!

Uh oh!

ilonatommy left a comment

Choose a reason for hiding this comment

Uh oh!

pavelsavara commented Jan 18, 2023

Uh oh!

hakenr commented Jan 18, 2023

Uh oh!

pavelsavara commented Jan 18, 2023

Uh oh!

pavelsavara commented Jan 19, 2023

Uh oh!

azure-pipelinesBot commented Jan 19, 2023

Uh oh!

pavelsavara commented Jan 19, 2023

Uh oh!

github-actionsBot commented Jan 19, 2023

Uh oh!

github-actionsBot commented Jan 19, 2023

Uh oh!

github-actionsBot commented Jan 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pavelsavara commented Jan 16, 2023•
edited
Loading