Uh oh!
There was an error while loading. Please reload this page.
Harden and re-enable DualMode socket tests - #80715
Conversation
ghost
commented
Jan 16, 2023
Tagging subscribers to this area: @dotnet/ncl Issue DetailsDropping
|
liveans
commented
Jan 17, 2023
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
antonfirsov
commented
Jan 24, 2023
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
antonfirsov
commented
Jan 24, 2023
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
antonfirsov
commented
Jan 31, 2023
@wfurt do you want to take a look, or should I go ahead and merge this? |
wfurt
left a comment
There was a problem hiding this comment.
LGTM. I would probably go with disabled parallelization but I'm fine with the helper if you feel it would stabilize the test. Time will tell and keeping the test disable does not provide any benefits.
I think that some of the re-enabled / shuffled tests are failing on extra platform pipeline: cc: @antonfirsov |
Fixes#1481.
Fixes#79820.
Throwing
DisableParallelizationat all tests in DualModeSocketTest increased the total execution time of those tests by approximately 1 minute on my Windows machine, so I decided to go with a more sophisticated approach.PortBlocker, which creates and binds a "shadow" socket of the opposite address family to prevent sockets in parallel tests to bind to the same port.SocketTestHelperBase<T>, reducing duplicate code.