Skip to content

[wasm] Enable SIMD - #80797

Merged
radekdoulik merged 38 commits into
dotnet:mainfrom
radekdoulik:pr-wasm-enable-simd
Mar 1, 2023
Merged

[wasm] Enable SIMD#80797
radekdoulik merged 38 commits into
dotnet:mainfrom
radekdoulik:pr-wasm-enable-simd

Conversation

@radekdoulik

@radekdoulikradekdoulik commented Jan 18, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Change default value of WasmEnableSIMD property to true. That enables SIMD for wasm/AOT.

Use docker image with newer v8 and node on helix.

@ghostghost added the area-Build-mono label Jan 18, 2023
@radekdoulik@radical
Let old V8 use simd
a0fc3eb
Co-authored-by: Ankit Jain <radical@gmail.com>
@radekdoulik

radekdoulik commented Jan 19, 2023

Copy link
Copy Markdown
MemberAuthor

Currently we fail on helix because v8 is too old. I am trying to improve that with 2 independent approaches, #80808 and dotnet/dotnet-buildtools-prereqs-docker#774

This was referenced Jan 19, 2023
Closed
Open
Closed
radicaland others added 8 commits January 19, 2023 22:55
@radical
[wasm] ManagedToNativeGenerator: Skip unmanaged dlls
b695c92
.. instead crashing with an exception like:
```
src/mono/wasm/build/WasmApp.Native.targets(296,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "ManagedToNativeGenerator" task failed unexpectedly.
System.BadImageFormatException: This PE image is not a managed executable.
at System.Reflection.MetadataLoadContext.LoadFromStreamCore(Stream peStream)
at System.Reflection.MetadataLoadContext.LoadFromAssemblyPath(String assemblyPath)
at PInvokeTableGenerator.Generate(String[] pinvokeModules, String[] assemblies, String outputPath) in /_/src/tasks/WasmAppBuilder/PInvokeTableGenerator.cs:line 42
at ManagedToNativeGenerator.ExecuteInternal() in /_/src/tasks/WasmAppBuilder/ManagedToNativeGenerator.cs:line 68
at ManagedToNativeGenerator.Execute() in /_/src/tasks/WasmAppBuilder/ManagedToNativeGenerator.cs:line 53
at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)
```
The wasm targets currently are not able to differentiate the managed
assemblies from the unmanaged ones. so it needs to be handled here.
@radical
Merge remote-tracking branch 'origin/main' into pr-wasm-enable-simd
9c0ea37
@radical
[wasm] WasmApp.Native.targets: do not trigger relinking when WasmEnab…
cb53bc6
…leSIMD=true
Instead, let the property be effective only for the AOT case.
@radekdoulik
Use staging image with newer v8
68da732
@radical
[wasm] WasmAppHost: Add support for host arguments
b260375
@radical
[wasm] console template: Add --experimental-wasm-simd to node, and re…
d12ab67
…move v8 config as that isn't supported
@radical
[wasm] Pass --experiment-wasm-simd for aot library tests too
5f68d50
@radical
Merge branch 'pr-wasm-enable-simd' ofhttps://github.com/radekdoulik/…
432e144
…runtime into pr-wasm-enable-simd
@radical

radical commented Jan 20, 2023

Copy link
Copy Markdown
Member

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jan 20, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radekdoulik
Try to pass full path to v8
a15b3ef
Also remove --experimental-wasm-simd option, which shouldn't be needed
for newer v8
@radekdoulik
Use docker image for all wasm helix jobs
033d473
As we need newer v8
@runfoapprunfoappBot mentioned this pull request Jan 20, 2023
Closed
@radicalradical added the arch-wasm WebAssembly architecture label Jan 20, 2023
@ghost

ghost commented Jan 20, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Let see how it goes on CI

Author:radekdoulik
Assignees:radekdoulik
Labels:

arch-wasm, area-Build-mono

Milestone:-

@lewinglewing mentioned this pull request Jan 20, 2023
Open
6 tasks
@build-analysisbuild-analysisBot mentioned this pull request Jan 23, 2023
Closed
@radekdoulik
Use DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
7242ab8
Let see whether it will avoid all the writes to correlation payload
path
@radekdoulik
Set NeedsEMSDKNode to false
37080d6
To try if we can use newer node in path
@azure-pipelines

azure-pipelinesBot commented Feb 21, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radekdoulik
radekdoulik marked this pull request as ready for review February 21, 2023 18:58
lewing
lewing reviewed Feb 26, 2023
View reviewed changes

@lewinglewing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we need to resolve the wbt failure

radical
radical reviewed Feb 27, 2023
View reviewed changes
Comment threadsrc/libraries/sendtohelix-wasm.targets
Comment threadsrc/libraries/sendtohelixhelp.proj Outdated
@radical

radical commented Feb 27, 2023

Copy link
Copy Markdown
Member

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Feb 27, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radekdoulik

radekdoulik commented Feb 27, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Feb 27, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radekdoulik

radekdoulik commented Feb 27, 2023

Copy link
Copy Markdown
MemberAuthor

The runtime-wasm (Build browser-wasm linux Release LibraryTests_NodeJs) fails on main too.

@lewing

lewing commented Mar 1, 2023

Copy link
Copy Markdown
Member

The runtime-wasm (Build browser-wasm linux Release LibraryTests_NodeJs) fails on main too.

@maraf are you looking into this?

kg
kg reviewed Mar 1, 2023
View reviewed changes
Comment threadeng/testing/WasmRunnerAOTTemplate.sh
kg
kg reviewed Mar 1, 2023
View reviewed changes
Comment threadsrc/mono/wasm/templates/templates/console/runtimeconfig.template.json
kg
kg approved these changes Mar 1, 2023
View reviewed changes

@kgkg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with the caveat that I don't have the ability to fully vet the yml or msbuild bits (but the latter do look correct to me), and I left some comments

@radekdoulik
radekdoulik merged commit cdd71fe into dotnet:mainMar 1, 2023
This was referenced Mar 8, 2023
Open
Open
@lewinglewing mentioned this pull request Mar 8, 2023
Open
This was referenced Mar 29, 2023
Closed
Closed
@ghostghost locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical left review comments
@lewinglewinglewing left review comments
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner
@vargazvargazAwaiting requested review from vargaz
@lambdageeklambdageekAwaiting requested review from lambdageek
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
+1 more reviewer
@kgkgkg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@radekdoulikradekdoulik

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@radekdoulik@radical@lewing@kg