Skip to content

Don't try to build FunctionalTests test assets as tests - #80874

Closed
lambdageek wants to merge 1 commit into
dotnet:mainfrom
lambdageek:try-fix-android-functional-tests
Closed

Don't try to build FunctionalTests test assets as tests#80874
lambdageek wants to merge 1 commit into
dotnet:mainfrom
lambdageek:try-fix-android-functional-tests

Conversation

@lambdageek

@lambdageeklambdageek commented Jan 19, 2023

Copy link
Copy Markdown
Member

They are just assemblies that can be referenced by other tests, not standalone tests, themselves.

Follow-up to #80391 to address apparent failures on the Android runtime-extra-platforms legs

They are just assemblies that can be referenced by other tests, not
standalone tests, themselves.
@lambdageek

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-extra-platforms

@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

They are just assemblies that can be referenced by other tests, not standalone tests, themselves.

Author:lambdageek
Assignees:lambdageek
Labels:

area-Infrastructure-libraries

Milestone:-

@lambdageek

Copy link
Copy Markdown
MemberAuthor

cc @simonrozsival

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek

Copy link
Copy Markdown
MemberAuthor

@simonrozsival Well this didn't work.

I'm now suspecting src/tests/build.proj. In particular AllRunnableTestPaths which eventually goes into BuildAllAndroidApp which might be building everything as an APK?? Although I haven't figured out exactly what gets into AllRunnableTestPaths, yet.

<TargetName="BuildAllAndroidApp"DependsOnTargets="GetListOfTestCmds;FindCmdDirectories">
<MSBuild
Projects="$(MSBuildProjectFile)"
Targets="BuildAndroidApp"
Properties="_CMDDIR=%(TestDirectories.Identity)"
Condition="'@(TestDirectories)' != ''" />
</Target>

@lambdageek

Copy link
Copy Markdown
MemberAuthor

Closing in favor of #80909

@lambdageek
lambdageek deleted the try-fix-android-functional-tests branch January 24, 2023 01:43
@ghostghost locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@lambdageek