Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] [mono][loader] Set status on success - #80951
Merged
Conversation
Emebedders that call `mono_assembly_load_from_full` may observe a
non-NULL return value and an uninitialized MonoImageOpenStatus, which
may lead to incorrect diagnostics in code like:
```
MonoImageOpenStatus status;
MonoAssembly *assembly = mono_assembly_load_from_full (image, name,
status, refonly);
if (!assembly || status != MONO_IMAGE_OK) {
fprintf(stderr, "Failure due to: %s\n", mono_image_strerror (status));
abort();
}
```
Which will print `Failure due to: Internal error`
Addresses dotnet/android#7658github-actionsBot
requested review from
lambdageek, thaystg and vargaz
as code ownersJanuary 20, 2023 20:33
vargaz
approved these changes
Jan 20, 2023
carlossanlop
commented
Feb 8, 2023
Contributor
Approved by Tactics for 7.0.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #80949 to release/7.0
/cc @lambdageek
Customer Impact
Customers using Microsoft.Android may experience sporadic crashes at app startup or during assembly loading due to an uninitialized variable.
Testing
Manual testing
Risk
Low. We now initialize the variable.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.