Skip to content

[release/6.0] Fix multiple dumps from being generated - #81064

Merged
carlossanlop merged 2 commits into
dotnet:release/6.0from
mikem8361:doubledump6
Feb 13, 2023
Merged

[release/6.0] Fix multiple dumps from being generated#81064
carlossanlop merged 2 commits into
dotnet:release/6.0from
mikem8361:doubledump6

Conversation

@mikem8361

@mikem8361mikem8361 commented Jan 24, 2023

Copy link
Copy Markdown
Contributor

Backport of #80474 to release/6.0

Customer Impact

This issue affects both 1st and 3rd party customers.

The issue (#78956) is that in certain Linux Kubernetes container configurations, 2 core dumps are created: one from the unhandled managed exception and one incorrectly from a SIGSEGV during abort() during process shutdown.

This also fixes hang during unhandled exception processing on ARM64 docker containers (issue #66707).

The soluation is that all the signals that the runtime hooks need to be unregistered before calling the Linux abort() API in the unhandled exception/crash dump generation path.

Testing

Local testing under docker and AKS.

Risk

Low. Affects only crash dump generation on Linux/MacOS.

@mikem8361mikem8361 self-assigned this Jan 24, 2023
@ghostghost added the area-PAL-coreclr only for closed issues label Jan 24, 2023
@mikem8361mikem8361 changed the title Fix multiple dumps from being generated[release/6.0] Fix multiple dumps from being generatedJan 24, 2023
@build-analysisbuild-analysisBot mentioned this pull request Jan 24, 2023
Closed
@runfoapprunfoappBot mentioned this pull request Jan 24, 2023
Closed
Mike McLaughlin
Fix multiple dumps from being generated
fb3e8bc
Issue: dotnet#78956
After a core dump is generated because of a unhandled managed exception
abort() is called but a SIGSEGV is generated in libpthread.so which is
caught by the runtime and a second core dump is generated. The fix is
to uninstall/uninitialize all the signal handlers, not just SIGABORT.
@carlossanlop

carlossanlop commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

If this is ready to be reviewed, please add the servicing-consider label and send email to Tactics requesting approval.

Can you also please take a look at the CI and determine if any of the failures are related to this change?

@carlossanlopcarlossanlop added this to the 6.0.x milestone Feb 8, 2023
@mikem8361

mikem8361 commented Feb 8, 2023

Copy link
Copy Markdown
ContributorAuthor

Yes, I will add that label when I get some testing feedback.

None of the CI failures are related to this change.

@mikem8361mikem8361 added the Servicing-consider Issue for next servicing release review label Feb 10, 2023
@carlossanlopcarlossanlop modified the milestones: 6.0.x, 6.0.15Feb 13, 2023
@carlossanlop

carlossanlop commented Feb 13, 2023

Copy link
Copy Markdown
Contributor

This was approved by Tactics via email for 6.0.15.
The CI re-run is green.
No OOB changes needed (native code).
Signed-off by area owners.
Ready to merge. :shipit:

@carlossanlop
carlossanlop merged commit bd34800 into dotnet:release/6.0Feb 13, 2023
@carlossanlopcarlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Feb 13, 2023
@mikem8361
mikem8361 deleted the doubledump6 branch March 1, 2023 01:40
@ghostghost locked as resolved and limited conversation to collaborators Mar 31, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janvorlijanvorlijanvorli approved these changes
@hoyosjshoyosjshoyosjs approved these changes

Assignees

@mikem8361mikem8361

Labels

area-PAL-coreclronly for closed issuesServicing-approvedApproved for servicing release

Projects

None yet

Milestone

6.0.15

Development

Successfully merging this pull request may close these issues.

4 participants

@mikem8361@carlossanlop@janvorli@hoyosjs
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[release/6.0] Fix multiple dumps from being generated by mikem8361 · Pull Request #81064 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Fix multiple dumps from being generated - #81064
Merged
carlossanlop merged 2 commits into
dotnet:release/6.0from 
mikem8361:doubledump6
Feb 13, 2023
Merged
[release/6.0] Fix multiple dumps from being generated#81064
carlossanlop merged 2 commits into
dotnet:release/6.0from 
mikem8361:doubledump6
Conversation
@mikem8361
@mikem8361mikem8361
commented
Jan 24, 2023

Copy link


Copy Markdown

Contributor
Backport of #80474 to release/6.0
Customer Impact
This issue affects both 1st and 3rd party customers.
The issue (#78956) is that in certain Linux Kubernetes container configurations, 2 core dumps are created: one from the unhandled managed exception and one incorrectly from a SIGSEGV during abort() during process shutdown.
This also fixes hang during unhandled exception processing on ARM64 docker containers (issue #66707).
The soluation is that all the signals that the runtime hooks need to be unregistered before calling the Linux abort() API in the unhandled exception/crash dump generation path.
Testing
Local testing under docker and AKS.
Risk
Low. Affects only crash dump generation on Linux/MacOS.
@mikem8361mikem8361
self-assigned this
Jan 24, 2023
@ghostghost
added
the 
area-PAL-coreclr
only for closed issues
label
Jan 24, 2023
@mikem8361mikem8361
changed the title
Fix multiple dumps from being generated[release/6.0] Fix multiple dumps from being generatedJan 24, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Jan 24, 2023

Closed

@runfoapprunfoappBot
mentioned this pull request
Jan 24, 2023

Closed

Mike McLaughlin
Fix multiple dumps from being generated
fb3e8bc
Issue: dotnet#78956
After a core dump is generated because of a unhandled managed exception
abort() is called but a SIGSEGV is generated in libpthread.so which is
caught by the runtime and a second core dump is generated. The fix is
to uninstall/uninitialize all the signal handlers, not just SIGABORT.
@carlossanlop
carlossanlop
commented
Feb 8, 2023

Copy link


Copy Markdown

Contributor
If this is ready to be reviewed, please add the servicing-consider label and send email to Tactics requesting approval.
Can you also please take a look at the CI and determine if any of the failures are related to this change?
@carlossanlopcarlossanlop
added this to the 6.0.x milestone
Feb 8, 2023
@mikem8361
mikem8361
commented
Feb 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Yes, I will add that label when I get some testing feedback.
None of the CI failures are related to this change.
@mikem8361mikem8361
added
the 
Servicing-consider
Issue for next servicing release review
label
Feb 10, 2023
@carlossanlopcarlossanlop
modified the milestones:
6.0.x, 6.0.15Feb 13, 2023
@carlossanlop
carlossanlop
commented
Feb 13, 2023

Copy link


Copy Markdown

Contributor
This was approved by Tactics via email for 6.0.15.

The CI re-run is green.

No OOB changes needed (native code).

Signed-off by area owners.

Ready to merge. :shipit:
@carlossanlop
carlossanlop
merged commit bd34800
into
dotnet:release/6.0Feb 13, 2023
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Feb 13, 2023
@mikem8361
mikem8361
deleted the

doubledump6

branch
March 1, 2023 01:40
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 31, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@janvorlijanvorlijanvorli approved these changes
@hoyosjshoyosjshoyosjs approved these changes

Assignees

@mikem8361mikem8361

Labels

area-PAL-coreclronly for closed issuesServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.15

Development

Successfully merging this pull request may close these issues.

4 participants

@mikem8361@carlossanlop@janvorli@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/6.0] Fix multiple dumps from being generated by mikem8361 · Pull Request #81064 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Fix multiple dumps from being generated - #81064
Merged
carlossanlop merged 2 commits into
dotnet:release/6.0from 
mikem8361:doubledump6
Feb 13, 2023
Merged
[release/6.0] Fix multiple dumps from being generated#81064
carlossanlop merged 2 commits into
dotnet:release/6.0from 
mikem8361:doubledump6
Conversation
@mikem8361
@mikem8361mikem8361
commented
Jan 24, 2023

Copy link


Copy Markdown

Contributor
Backport of #80474 to release/6.0
Customer Impact
This issue affects both 1st and 3rd party customers.
The issue (#78956) is that in certain Linux Kubernetes container configurations, 2 core dumps are created: one from the unhandled managed exception and one incorrectly from a SIGSEGV during abort() during process shutdown.
This also fixes hang during unhandled exception processing on ARM64 docker containers (issue #66707).
The soluation is that all the signals that the runtime hooks need to be unregistered before calling the Linux abort() API in the unhandled exception/crash dump generation path.
Testing
Local testing under docker and AKS.
Risk
Low. Affects only crash dump generation on Linux/MacOS.
@mikem8361mikem8361
self-assigned this
Jan 24, 2023
@ghostghost
added
the 
area-PAL-coreclr
only for closed issues
label
Jan 24, 2023
@mikem8361mikem8361
changed the title
Fix multiple dumps from being generated[release/6.0] Fix multiple dumps from being generatedJan 24, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Jan 24, 2023

Closed

@runfoapprunfoappBot
mentioned this pull request
Jan 24, 2023

Closed

Mike McLaughlin
Fix multiple dumps from being generated
fb3e8bc
Issue: dotnet#78956
After a core dump is generated because of a unhandled managed exception
abort() is called but a SIGSEGV is generated in libpthread.so which is
caught by the runtime and a second core dump is generated. The fix is
to uninstall/uninitialize all the signal handlers, not just SIGABORT.
@carlossanlop
carlossanlop
commented
Feb 8, 2023

Copy link


Copy Markdown

Contributor
If this is ready to be reviewed, please add the servicing-consider label and send email to Tactics requesting approval.
Can you also please take a look at the CI and determine if any of the failures are related to this change?
@carlossanlopcarlossanlop
added this to the 6.0.x milestone
Feb 8, 2023
@mikem8361
mikem8361
commented
Feb 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Yes, I will add that label when I get some testing feedback.
None of the CI failures are related to this change.
@mikem8361mikem8361
added
the 
Servicing-consider
Issue for next servicing release review
label
Feb 10, 2023
@carlossanlopcarlossanlop
modified the milestones:
6.0.x, 6.0.15Feb 13, 2023
@carlossanlop
carlossanlop
commented
Feb 13, 2023

Copy link


Copy Markdown

Contributor
This was approved by Tactics via email for 6.0.15.

The CI re-run is green.

No OOB changes needed (native code).

Signed-off by area owners.

Ready to merge. :shipit:
@carlossanlop
carlossanlop
merged commit bd34800
into
dotnet:release/6.0Feb 13, 2023
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Feb 13, 2023
@mikem8361
mikem8361
deleted the

doubledump6

branch
March 1, 2023 01:40
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 31, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@janvorlijanvorlijanvorli approved these changes
@hoyosjshoyosjshoyosjs approved these changes

Assignees

@mikem8361mikem8361

Labels

area-PAL-coreclronly for closed issuesServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.15

Development

Successfully merging this pull request may close these issues.

4 participants

@mikem8361@carlossanlop@janvorli@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/6.0] Fix multiple dumps from being generated by mikem8361 · Pull Request #81064 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Fix multiple dumps from being generated - #81064
Merged
carlossanlop merged 2 commits into
dotnet:release/6.0from 
mikem8361:doubledump6
Feb 13, 2023
Merged
[release/6.0] Fix multiple dumps from being generated#81064
carlossanlop merged 2 commits into
dotnet:release/6.0from 
mikem8361:doubledump6
Conversation
@mikem8361
@mikem8361mikem8361
commented
Jan 24, 2023

Copy link


Copy Markdown

Contributor
Backport of #80474 to release/6.0
Customer Impact
This issue affects both 1st and 3rd party customers.
The issue (#78956) is that in certain Linux Kubernetes container configurations, 2 core dumps are created: one from the unhandled managed exception and one incorrectly from a SIGSEGV during abort() during process shutdown.
This also fixes hang during unhandled exception processing on ARM64 docker containers (issue #66707).
The soluation is that all the signals that the runtime hooks need to be unregistered before calling the Linux abort() API in the unhandled exception/crash dump generation path.
Testing
Local testing under docker and AKS.
Risk
Low. Affects only crash dump generation on Linux/MacOS.
@mikem8361mikem8361
self-assigned this
Jan 24, 2023
@ghostghost
added
the 
area-PAL-coreclr
only for closed issues
label
Jan 24, 2023
@mikem8361mikem8361
changed the title
Fix multiple dumps from being generated[release/6.0] Fix multiple dumps from being generatedJan 24, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Jan 24, 2023

Closed

@runfoapprunfoappBot
mentioned this pull request
Jan 24, 2023

Closed

Mike McLaughlin
Fix multiple dumps from being generated
fb3e8bc
Issue: dotnet#78956
After a core dump is generated because of a unhandled managed exception
abort() is called but a SIGSEGV is generated in libpthread.so which is
caught by the runtime and a second core dump is generated. The fix is
to uninstall/uninitialize all the signal handlers, not just SIGABORT.
@carlossanlop
carlossanlop
commented
Feb 8, 2023

Copy link


Copy Markdown

Contributor
If this is ready to be reviewed, please add the servicing-consider label and send email to Tactics requesting approval.
Can you also please take a look at the CI and determine if any of the failures are related to this change?
@carlossanlopcarlossanlop
added this to the 6.0.x milestone
Feb 8, 2023
@mikem8361
mikem8361
commented
Feb 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Yes, I will add that label when I get some testing feedback.
None of the CI failures are related to this change.
@mikem8361mikem8361
added
the 
Servicing-consider
Issue for next servicing release review
label
Feb 10, 2023
@carlossanlopcarlossanlop
modified the milestones:
6.0.x, 6.0.15Feb 13, 2023
@carlossanlop
carlossanlop
commented
Feb 13, 2023

Copy link


Copy Markdown

Contributor
This was approved by Tactics via email for 6.0.15.

The CI re-run is green.

No OOB changes needed (native code).

Signed-off by area owners.

Ready to merge. :shipit:
@carlossanlop
carlossanlop
merged commit bd34800
into
dotnet:release/6.0Feb 13, 2023
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Feb 13, 2023
@mikem8361
mikem8361
deleted the

doubledump6

branch
March 1, 2023 01:40
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 31, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@janvorlijanvorlijanvorli approved these changes
@hoyosjshoyosjshoyosjs approved these changes

Assignees

@mikem8361mikem8361

Labels

area-PAL-coreclronly for closed issuesServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.15

Development

Successfully merging this pull request may close these issues.

4 participants

@mikem8361@carlossanlop@janvorli@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[release/6.0] Fix multiple dumps from being generated by mikem8361 · Pull Request #81064 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Fix multiple dumps from being generated - #81064
Merged
carlossanlop merged 2 commits into
dotnet:release/6.0from 
mikem8361:doubledump6
Feb 13, 2023
Merged
[release/6.0] Fix multiple dumps from being generated#81064
carlossanlop merged 2 commits into
dotnet:release/6.0from 
mikem8361:doubledump6
Conversation
@mikem8361
@mikem8361mikem8361
commented
Jan 24, 2023

Copy link


Copy Markdown

Contributor
Backport of #80474 to release/6.0
Customer Impact
This issue affects both 1st and 3rd party customers.
The issue (#78956) is that in certain Linux Kubernetes container configurations, 2 core dumps are created: one from the unhandled managed exception and one incorrectly from a SIGSEGV during abort() during process shutdown.
This also fixes hang during unhandled exception processing on ARM64 docker containers (issue #66707).
The soluation is that all the signals that the runtime hooks need to be unregistered before calling the Linux abort() API in the unhandled exception/crash dump generation path.
Testing
Local testing under docker and AKS.
Risk
Low. Affects only crash dump generation on Linux/MacOS.
@mikem8361mikem8361
self-assigned this
Jan 24, 2023
@ghostghost
added
the 
area-PAL-coreclr
only for closed issues
label
Jan 24, 2023
@mikem8361mikem8361
changed the title
Fix multiple dumps from being generated[release/6.0] Fix multiple dumps from being generatedJan 24, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Jan 24, 2023

Closed

@runfoapprunfoappBot
mentioned this pull request
Jan 24, 2023

Closed

Mike McLaughlin
Fix multiple dumps from being generated
fb3e8bc
Issue: dotnet#78956
After a core dump is generated because of a unhandled managed exception
abort() is called but a SIGSEGV is generated in libpthread.so which is
caught by the runtime and a second core dump is generated. The fix is
to uninstall/uninitialize all the signal handlers, not just SIGABORT.
@carlossanlop
carlossanlop
commented
Feb 8, 2023

Copy link


Copy Markdown

Contributor
If this is ready to be reviewed, please add the servicing-consider label and send email to Tactics requesting approval.
Can you also please take a look at the CI and determine if any of the failures are related to this change?
@carlossanlopcarlossanlop
added this to the 6.0.x milestone
Feb 8, 2023
@mikem8361
mikem8361
commented
Feb 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Yes, I will add that label when I get some testing feedback.
None of the CI failures are related to this change.
@mikem8361mikem8361
added
the 
Servicing-consider
Issue for next servicing release review
label
Feb 10, 2023
@carlossanlopcarlossanlop
modified the milestones:
6.0.x, 6.0.15Feb 13, 2023
@carlossanlop
carlossanlop
commented
Feb 13, 2023

Copy link


Copy Markdown

Contributor
This was approved by Tactics via email for 6.0.15.

The CI re-run is green.

No OOB changes needed (native code).

Signed-off by area owners.

Ready to merge. :shipit:
@carlossanlop
carlossanlop
merged commit bd34800
into
dotnet:release/6.0Feb 13, 2023
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Feb 13, 2023
@mikem8361
mikem8361
deleted the

doubledump6

branch
March 1, 2023 01:40
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 31, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@janvorlijanvorlijanvorli approved these changes
@hoyosjshoyosjshoyosjs approved these changes

Assignees

@mikem8361mikem8361

Labels

area-PAL-coreclronly for closed issuesServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.15

Development

Successfully merging this pull request may close these issues.

4 participants

@mikem8361@carlossanlop@janvorli@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[release/6.0] Fix multiple dumps from being generated by mikem8361 · Pull Request #81064 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Fix multiple dumps from being generated - #81064
Merged
carlossanlop merged 2 commits into
dotnet:release/6.0from 
mikem8361:doubledump6
Feb 13, 2023
Merged
[release/6.0] Fix multiple dumps from being generated#81064
carlossanlop merged 2 commits into
dotnet:release/6.0from 
mikem8361:doubledump6
Conversation
@mikem8361
@mikem8361mikem8361
commented
Jan 24, 2023

Copy link


Copy Markdown

Contributor
Backport of #80474 to release/6.0
Customer Impact
This issue affects both 1st and 3rd party customers.
The issue (#78956) is that in certain Linux Kubernetes container configurations, 2 core dumps are created: one from the unhandled managed exception and one incorrectly from a SIGSEGV during abort() during process shutdown.
This also fixes hang during unhandled exception processing on ARM64 docker containers (issue #66707).
The soluation is that all the signals that the runtime hooks need to be unregistered before calling the Linux abort() API in the unhandled exception/crash dump generation path.
Testing
Local testing under docker and AKS.
Risk
Low. Affects only crash dump generation on Linux/MacOS.
@mikem8361mikem8361
self-assigned this
Jan 24, 2023
@ghostghost
added
the 
area-PAL-coreclr
only for closed issues
label
Jan 24, 2023
@mikem8361mikem8361
changed the title
Fix multiple dumps from being generated[release/6.0] Fix multiple dumps from being generatedJan 24, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Jan 24, 2023

Closed

@runfoapprunfoappBot
mentioned this pull request
Jan 24, 2023

Closed

Mike McLaughlin
Fix multiple dumps from being generated
fb3e8bc
Issue: dotnet#78956
After a core dump is generated because of a unhandled managed exception
abort() is called but a SIGSEGV is generated in libpthread.so which is
caught by the runtime and a second core dump is generated. The fix is
to uninstall/uninitialize all the signal handlers, not just SIGABORT.
@carlossanlop
carlossanlop
commented
Feb 8, 2023

Copy link


Copy Markdown

Contributor
If this is ready to be reviewed, please add the servicing-consider label and send email to Tactics requesting approval.
Can you also please take a look at the CI and determine if any of the failures are related to this change?
@carlossanlopcarlossanlop
added this to the 6.0.x milestone
Feb 8, 2023
@mikem8361
mikem8361
commented
Feb 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Yes, I will add that label when I get some testing feedback.
None of the CI failures are related to this change.
@mikem8361mikem8361
added
the 
Servicing-consider
Issue for next servicing release review
label
Feb 10, 2023
@carlossanlopcarlossanlop
modified the milestones:
6.0.x, 6.0.15Feb 13, 2023
@carlossanlop
carlossanlop
commented
Feb 13, 2023

Copy link


Copy Markdown

Contributor
This was approved by Tactics via email for 6.0.15.

The CI re-run is green.

No OOB changes needed (native code).

Signed-off by area owners.

Ready to merge. :shipit:
@carlossanlop
carlossanlop
merged commit bd34800
into
dotnet:release/6.0Feb 13, 2023
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Feb 13, 2023
@mikem8361
mikem8361
deleted the

doubledump6

branch
March 1, 2023 01:40
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 31, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@janvorlijanvorlijanvorli approved these changes
@hoyosjshoyosjshoyosjs approved these changes

Assignees

@mikem8361mikem8361

Labels

area-PAL-coreclronly for closed issuesServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.15

Development

Successfully merging this pull request may close these issues.

4 participants

@mikem8361@carlossanlop@janvorli@hoyosjs

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[release/6.0] Fix multiple dumps from being generated by mikem8361 · Pull Request #81064 · dotnet/runtime · GitHub
Skip to content
[release/6.0] Fix multiple dumps from being generated - #81064
Merged
carlossanlop merged 2 commits into
dotnet:release/6.0from 
mikem8361:doubledump6
Feb 13, 2023
Merged
[release/6.0] Fix multiple dumps from being generated#81064
carlossanlop merged 2 commits into
dotnet:release/6.0from 
mikem8361:doubledump6
Conversation
@mikem8361
@mikem8361mikem8361
commented
Jan 24, 2023

Copy link


Copy Markdown

Contributor
Backport of #80474 to release/6.0
Customer Impact
This issue affects both 1st and 3rd party customers.
The issue (#78956) is that in certain Linux Kubernetes container configurations, 2 core dumps are created: one from the unhandled managed exception and one incorrectly from a SIGSEGV during abort() during process shutdown.
This also fixes hang during unhandled exception processing on ARM64 docker containers (issue #66707).
The soluation is that all the signals that the runtime hooks need to be unregistered before calling the Linux abort() API in the unhandled exception/crash dump generation path.
Testing
Local testing under docker and AKS.
Risk
Low. Affects only crash dump generation on Linux/MacOS.
@mikem8361mikem8361
self-assigned this
Jan 24, 2023
@ghostghost
added
the 
area-PAL-coreclr
only for closed issues
label
Jan 24, 2023
@mikem8361mikem8361
changed the title
Fix multiple dumps from being generated[release/6.0] Fix multiple dumps from being generatedJan 24, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Jan 24, 2023

Closed

@runfoapprunfoappBot
mentioned this pull request
Jan 24, 2023

Closed

Mike McLaughlin
Fix multiple dumps from being generated
fb3e8bc
Issue: dotnet#78956
After a core dump is generated because of a unhandled managed exception
abort() is called but a SIGSEGV is generated in libpthread.so which is
caught by the runtime and a second core dump is generated. The fix is
to uninstall/uninitialize all the signal handlers, not just SIGABORT.
@carlossanlop
carlossanlop
commented
Feb 8, 2023

Copy link


Copy Markdown

Contributor
If this is ready to be reviewed, please add the servicing-consider label and send email to Tactics requesting approval.
Can you also please take a look at the CI and determine if any of the failures are related to this change?
@carlossanlopcarlossanlop
added this to the 6.0.x milestone
Feb 8, 2023
@mikem8361
mikem8361
commented
Feb 8, 2023

Copy link


Copy Markdown

ContributorAuthor
Yes, I will add that label when I get some testing feedback.
None of the CI failures are related to this change.
@mikem8361mikem8361
added
the 
Servicing-consider
Issue for next servicing release review
label
Feb 10, 2023
@carlossanlopcarlossanlop
modified the milestones:
6.0.x, 6.0.15Feb 13, 2023
@carlossanlop
carlossanlop
commented
Feb 13, 2023

Copy link


Copy Markdown

Contributor
This was approved by Tactics via email for 6.0.15.

The CI re-run is green.

No OOB changes needed (native code).

Signed-off by area owners.

Ready to merge. :shipit:
@carlossanlop
carlossanlop
merged commit bd34800
into
dotnet:release/6.0Feb 13, 2023
@carlossanlopcarlossanlop
added

Servicing-approved
Approved for servicing release
and removed

Servicing-consider
Issue for next servicing release review
labels
Feb 13, 2023
@mikem8361
mikem8361
deleted the

doubledump6

branch
March 1, 2023 01:40
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 31, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@janvorlijanvorlijanvorli approved these changes
@hoyosjshoyosjshoyosjs approved these changes

Assignees

@mikem8361mikem8361

Labels

area-PAL-coreclronly for closed issuesServicing-approvedApproved for servicing release

Projects


None yet


Milestone

6.0.15

Development

Successfully merging this pull request may close these issues.

4 participants

@mikem8361@carlossanlop@janvorli@hoyosjs