Skip to content

BrowserDebugProxy: unify debug metadata reading for PE and Webcil - #81099

Merged
lambdageek merged 7 commits into
dotnet:mainfrom
lambdageek:feature-webcil-debug-refactor
Jan 26, 2023
Merged

BrowserDebugProxy: unify debug metadata reading for PE and Webcil#81099
lambdageek merged 7 commits into
dotnet:mainfrom
lambdageek:feature-webcil-debug-refactor

Conversation

@lambdageek

@lambdageeklambdageek commented Jan 24, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Factor common code out into a MetadataDebugSummary using an adapter to read from either PEReader or WebcilReader.

  • Implement WebcilReader.ReadPdbChecksumDebugDirectoryData

Contributes to #80807

@ghostghost assigned lambdageekJan 24, 2023
@ghost

ghost commented Jan 24, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Factor common code out into a MetadataDebugSummary using an adapter to read from either PEReader or WebcilReader.

Note: WebcilReader doesn't implement ReadPdbChecksumDebugDirectoryData yet, so that part isn't functional.

Contributes to #80807

Author:lambdageek
Assignees:lambdageek
Labels:

area-Debugger-mono

Milestone:-

@lambdageeklambdageek added the arch-wasm WebAssembly architecture label Jan 24, 2023
@ghost

ghost commented Jan 24, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Factor common code out into a MetadataDebugSummary using an adapter to read from either PEReader or WebcilReader.

TODO

  • WebcilReader doesn't implement ReadPdbChecksumDebugDirectoryData yet, so that part isn't functional.

Contributes to #80807

Author:lambdageek
Assignees:lambdageek
Labels:

arch-wasm, area-Debugger-mono

Milestone:-

@lambdageek

lambdageek commented Jan 24, 2023

Copy link
Copy Markdown
MemberAuthor

Keeping it a draft until I add the pdb checksum reader for webcil

@lambdageek
lambdageekforce-pushed the feature-webcil-debug-refactor branch from 81f43ac to 5b5e844CompareJanuary 24, 2023 17:51
@lambdageek
lambdageek marked this pull request as ready for review January 24, 2023 18:06
@lambdageeklambdageek mentioned this pull request Jan 24, 2023
Closed
16 tasks
radical
radical approved these changes Jan 24, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.NET.WebAssembly.Webcil/src/Webcil/WebcilReader.cs Outdated
Comment threadsrc/libraries/Microsoft.NET.WebAssembly.Webcil/src/Webcil/WebcilReader.cs Outdated
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/IDebugMetadataProvider.cs
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Outdated
Comment threadsrc/mono/wasm/debugger/BrowserDebugProxy/DebugStore.cs Outdated
Comment threadsrc/libraries/Microsoft.NET.WebAssembly.Webcil/src/Webcil/WebcilReader.cs Outdated
lambdageekand others added 2 commits January 24, 2023 14:24
@lambdageek@radical
Fix whitespace
fe8f874
Co-authored-by: Ankit Jain <radical@gmail.com>
@lambdageek
Move MetadataDebugSummary to a new file
6eaee63
Also switch from cascade of 'if's to a 'switch' when looking at debug entries
@lambdageek
lambdageekforce-pushed the feature-webcil-debug-refactor branch from 9ebd6d8 to 0e4cdf6CompareJanuary 24, 2023 20:09
@build-analysisbuild-analysisBot mentioned this pull request Jan 24, 2023
Closed
@lambdageek
lambdageekforce-pushed the feature-webcil-debug-refactor branch from 0e4cdf6 to 45b7c47CompareJanuary 24, 2023 21:04
@lambdageek

lambdageek commented Jan 24, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jan 24, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

radical
radical approved these changes Jan 24, 2023
View reviewed changes
Comment threadsrc/libraries/Microsoft.NET.WebAssembly.Webcil/src/Webcil/WebcilReader.Reflection.cs Outdated
Comment threadsrc/libraries/Microsoft.NET.WebAssembly.Webcil/src/Webcil/WebcilReader.Reflection.cs Outdated
Comment threadsrc/libraries/Microsoft.NET.WebAssembly.Webcil/src/Webcil/WebcilReader.Reflection.cs Outdated
This was referenced Jan 25, 2023
Open
Closed
Closed
@lambdageek@radical
Mark fields readonly; use naming convention
df5175b
Co-Authored-By: Ankit Jain <radical@gmail.com>
@lambdageek

lambdageek commented Jan 25, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-wasm

@azure-pipelines

azure-pipelinesBot commented Jan 25, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek
lambdageek merged commit d92e70f into dotnet:mainJan 26, 2023
@ghostghost locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radicalradicalradical approved these changes
@thaystgthaystgthaystg approved these changes

Assignees

@lambdageeklambdageek

Labels

arch-wasmWebAssembly architecturearea-Debugger-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lambdageek@radical@thaystg