Uh oh!
There was an error while loading. Please reload this page.
[release/7.0] Decommit memory before returning to the region_allocator - #81295
Merged
carlossanlop merged 1 commit intoFeb 9, 2023
Merged
Conversation
ghost
commented
Jan 27, 2023
Tagging subscribers to this area: @dotnet/gc Issue Detailsnull
|
cshung
marked this pull request as draft
January 27, 2023 20:47
jeffschwMSFT
approved these changes
Jan 27, 2023
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. we will take for consideration in 7.0.x
cshung
marked this pull request as ready for review
January 27, 2023 23:21
Maoni0
approved these changes
Jan 30, 2023
5 tasks
carlossanlop
commented
Feb 9, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #80640 to release/7.0
/cc @cshung
Customer Impact
As customers reported in #79882, newly created arrays might not be zero-initialized, this violates our guarantees. Turn out this has to do with some of our low memory condition processing. After the fix, the arrays will always be zero-initialized.
Testing
This is tested under reliability framework stress test for both server and workstation. It is also tested against the ASP.NET benchmarks.
Risk
Low, given extensive testing.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.