Skip to content

[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only - #81454

Merged
TIHan merged 30 commits into
dotnet:mainfrom
TIHan:fold-gt-lcl-var-addr
Feb 17, 2023
Merged

[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only#81454
TIHan merged 30 commits into
dotnet:mainfrom
TIHan:fold-gt-lcl-var-addr

Conversation

@TIHan

@TIHanTIHan commented Feb 1, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Will resolve: #55064

There are cases where IND{short}(LCL_VAR_ADDR{int}) can be transformed to CAST{int <- short <- int}(LCL_VAR{int}) to prevent storing and reading from memory, but only if the indirection is narrow for integer types.

This transformation will not occur for the storage of an assignment: ASG(IND{short}(LCL_VAR_ADDR{int}}, ..).

Acceptance Criteria

  • Disasm tests

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 1, 2023
@ghostghost assigned TIHanFeb 1, 2023
@ghost

ghost commented Feb 1, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:TIHan
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@TIHanTIHan changed the title [JIT] EXPERIMENT - Folding IND(GT_LCL_VAR_ADDR)[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR)Feb 1, 2023
@TIHanTIHan changed the title [JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR)[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VARFeb 1, 2023
@build-analysisbuild-analysisBot mentioned this pull request Feb 1, 2023
Closed
@TIHan
TIHanforce-pushed the fold-gt-lcl-var-addr branch from 3c27c57 to af037ecCompareFebruary 1, 2023 20:14
@build-analysisbuild-analysisBot mentioned this pull request Feb 2, 2023
Closed
5 tasks
@TIHanTIHan changed the title [JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small typesFeb 4, 2023
@TIHanTIHan changed the title [JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small types[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
@TIHanTIHan changed the title [JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
@TIHanTIHan changed the title [JIT] Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
drieseng
drieseng reviewed Feb 4, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp Outdated
@TIHanTIHan changed the title [JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast onlyFeb 7, 2023
@TIHanTIHan mentioned this pull request Feb 7, 2023
Merged
2 tasks
@TIHanTIHan closed this Feb 9, 2023
@TIHanTIHan reopened this Feb 9, 2023
@TIHan
TIHan marked this pull request as ready for review February 14, 2023 23:23
@TIHan

TIHan commented Feb 14, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@dotnet/jit-contrib cc @jakobbotsch

Diffs

There are a lot of ARM32 regressions, but this is due to the CSE rules for that target.
Other regressions are due to more CSEs.

@jakobbotsch

jakobbotsch commented Feb 15, 2023

Copy link
Copy Markdown
Member

There are a lot of ARM32 regressions, but this is due to the CSE rules for that target.

Can you show some examples? What are/aren't we CSE'ing that changed from before?

SingleAccretion
SingleAccretion reviewed Feb 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp Outdated
Comment threadsrc/coreclr/jit/lclmorph.cpp Outdated
Comment threadsrc/coreclr/jit/lclmorph.cpp Outdated
Comment threadsrc/coreclr/jit/lclmorph.cpp Outdated
Comment threadsrc/coreclr/jit/lclmorph.cpp Outdated
Comment threadsrc/coreclr/jit/lclmorph.cpp Outdated
Comment threadsrc/coreclr/jit/lclmorph.cpp Outdated
@TIHan

TIHan commented Feb 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@jakobbotsch diff dump of one of the ARM32 regressions
arm32_diff_dump.zip

SingleAccretion
SingleAccretion reviewed Feb 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp Outdated
@TIHan@SingleAccretion
Update src/coreclr/jit/lclmorph.cpp
93d81b6
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
@TIHan

TIHan commented Feb 16, 2023

Copy link
Copy Markdown
ContributorAuthor

@SingleAccretion Ok, looks like I was seeing things before - allowed looking at long types for 32bit and there are quite a bit of improvements.

SingleAccretion
SingleAccretion approved these changes Feb 16, 2023
View reviewed changes

@SingleAccretionSingleAccretion left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jakobbotsch
jakobbotsch approved these changes Feb 17, 2023
View reviewed changes

@jakobbotschjakobbotsch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We looked at one of the arm32 regressions offline and it was caused by CSE being less aggressive due to more tracked locals now existing, so not something we should be compensating for here.

@TIHan
TIHan merged commit 925028b into dotnet:mainFeb 17, 2023
@TIHan
TIHan deleted the fold-gt-lcl-var-addr branch February 17, 2023 23:19
@dakersnardakersnar mentioned this pull request Feb 21, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes
+2 more reviewers
@driesengdriesengdrieseng left review comments
@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sub-optimal code generated for Unsafe.As

4 participants

@TIHan@jakobbotsch@drieseng@SingleAccretion
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[JIT] LclMorph `GT_IND(GT_LCL_VAR_ADDR)` => `GT_CAST(GT_LCL_VAR)` narrow-cast only by TIHan · Pull Request #81454 · dotnet/runtime · GitHub
Skip to content
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only - #81454
Merged
TIHan merged 30 commits into
dotnet:mainfrom 
TIHan:fold-gt-lcl-var-addr
Feb 17, 2023
Merged
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only#81454
TIHan merged 30 commits into
dotnet:mainfrom 
TIHan:fold-gt-lcl-var-addr
Conversation
@TIHan
@TIHanTIHan
commented
Feb 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Will resolve: #55064
There are cases where IND{short}(LCL_VAR_ADDR{int}) can be transformed to CAST{int <- short <- int}(LCL_VAR{int}) to prevent storing and reading from memory, but only if the indirection is narrow for integer types.
This transformation will not occur for the storage of an assignment: ASG(IND{short}(LCL_VAR_ADDR{int}}, ..).
Acceptance Criteria
  •  Disasm tests
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Feb 1, 2023
@ghostghost
assigned TIHanFeb 1, 2023
@ghost
ghost
commented
Feb 1, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:TIHan
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding IND(GT_LCL_VAR_ADDR)[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR)Feb 1, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR)[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VARFeb 1, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 1, 2023

Closed

@TIHan
TIHanforce-pushed
the
fold-gt-lcl-var-addr
branch
from
3c27c57 to
af037ecCompareFebruary 1, 2023 20:14
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 2, 2023

Closed

5 tasks
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small types[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
drieseng
drieseng
reviewed
Feb 4, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHanTIHan
changed the title
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast onlyFeb 7, 2023
@TIHanTIHan
mentioned this pull request
Feb 7, 2023
 Merged

2 tasks
@TIHanTIHan
closed this
Feb 9, 2023
@TIHanTIHan
reopened this
Feb 9, 2023
@TIHan
TIHan
marked this pull request as ready for review
February 14, 2023 23:23
@TIHan
TIHan
commented
Feb 14, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib cc @jakobbotsch
Diffs
There are a lot of ARM32 regressions, but this is due to the CSE rules for that target.

Other regressions are due to more CSEs.
@jakobbotsch
jakobbotsch
commented
Feb 15, 2023

Copy link


Copy Markdown

Member
There are a lot of ARM32 regressions, but this is due to the CSE rules for that target.
Can you show some examples? What are/aren't we CSE'ing that changed from before?
SingleAccretion
SingleAccretion
reviewed
Feb 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHan
TIHan
commented
Feb 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@jakobbotsch diff dump of one of the ARM32 regressions
arm32_diff_dump.zip
SingleAccretion
SingleAccretion
reviewed
Feb 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHan@SingleAccretion
Update src/coreclr/jit/lclmorph.cpp
93d81b6
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
@TIHan
TIHan
commented
Feb 16, 2023

Copy link


Copy Markdown

ContributorAuthor
@SingleAccretion Ok, looks like I was seeing things before - allowed looking at long types for 32bit and there are quite a bit of improvements.
SingleAccretion
SingleAccretion
approved these changes
Feb 16, 2023
View reviewed changes
@SingleAccretionSingleAccretion
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
jakobbotsch
jakobbotsch
approved these changes
Feb 17, 2023
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We looked at one of the arm32 regressions offline and it was caused by CSE being less aggressive due to more tracked locals now existing, so not something we should be compensating for here.
@TIHan
TIHan
merged commit 925028b
into
dotnet:mainFeb 17, 2023
@TIHan
TIHan
deleted the

fold-gt-lcl-var-addr

branch
February 17, 2023 23:19
@dakersnardakersnar
mentioned this pull request
Feb 21, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

+2 more reviewers

@driesengdriesengdrieseng left review comments
@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Sub-optimal code generated for Unsafe.As


4 participants

@TIHan@jakobbotsch@drieseng@SingleAccretion

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[JIT] LclMorph `GT_IND(GT_LCL_VAR_ADDR)` => `GT_CAST(GT_LCL_VAR)` narrow-cast only by TIHan · Pull Request #81454 · dotnet/runtime · GitHub
Skip to content
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only - #81454
Merged
TIHan merged 30 commits into
dotnet:mainfrom 
TIHan:fold-gt-lcl-var-addr
Feb 17, 2023
Merged
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only#81454
TIHan merged 30 commits into
dotnet:mainfrom 
TIHan:fold-gt-lcl-var-addr
Conversation
@TIHan
@TIHanTIHan
commented
Feb 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Will resolve: #55064
There are cases where IND{short}(LCL_VAR_ADDR{int}) can be transformed to CAST{int <- short <- int}(LCL_VAR{int}) to prevent storing and reading from memory, but only if the indirection is narrow for integer types.
This transformation will not occur for the storage of an assignment: ASG(IND{short}(LCL_VAR_ADDR{int}}, ..).
Acceptance Criteria
  •  Disasm tests
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Feb 1, 2023
@ghostghost
assigned TIHanFeb 1, 2023
@ghost
ghost
commented
Feb 1, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:TIHan
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding IND(GT_LCL_VAR_ADDR)[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR)Feb 1, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR)[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VARFeb 1, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 1, 2023

Closed

@TIHan
TIHanforce-pushed
the
fold-gt-lcl-var-addr
branch
from
3c27c57 to
af037ecCompareFebruary 1, 2023 20:14
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 2, 2023

Closed

5 tasks
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small types[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
drieseng
drieseng
reviewed
Feb 4, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHanTIHan
changed the title
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast onlyFeb 7, 2023
@TIHanTIHan
mentioned this pull request
Feb 7, 2023
 Merged

2 tasks
@TIHanTIHan
closed this
Feb 9, 2023
@TIHanTIHan
reopened this
Feb 9, 2023
@TIHan
TIHan
marked this pull request as ready for review
February 14, 2023 23:23
@TIHan
TIHan
commented
Feb 14, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib cc @jakobbotsch
Diffs
There are a lot of ARM32 regressions, but this is due to the CSE rules for that target.

Other regressions are due to more CSEs.
@jakobbotsch
jakobbotsch
commented
Feb 15, 2023

Copy link


Copy Markdown

Member
There are a lot of ARM32 regressions, but this is due to the CSE rules for that target.
Can you show some examples? What are/aren't we CSE'ing that changed from before?
SingleAccretion
SingleAccretion
reviewed
Feb 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHan
TIHan
commented
Feb 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@jakobbotsch diff dump of one of the ARM32 regressions
arm32_diff_dump.zip
SingleAccretion
SingleAccretion
reviewed
Feb 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHan@SingleAccretion
Update src/coreclr/jit/lclmorph.cpp
93d81b6
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
@TIHan
TIHan
commented
Feb 16, 2023

Copy link


Copy Markdown

ContributorAuthor
@SingleAccretion Ok, looks like I was seeing things before - allowed looking at long types for 32bit and there are quite a bit of improvements.
SingleAccretion
SingleAccretion
approved these changes
Feb 16, 2023
View reviewed changes
@SingleAccretionSingleAccretion
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
jakobbotsch
jakobbotsch
approved these changes
Feb 17, 2023
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We looked at one of the arm32 regressions offline and it was caused by CSE being less aggressive due to more tracked locals now existing, so not something we should be compensating for here.
@TIHan
TIHan
merged commit 925028b
into
dotnet:mainFeb 17, 2023
@TIHan
TIHan
deleted the

fold-gt-lcl-var-addr

branch
February 17, 2023 23:19
@dakersnardakersnar
mentioned this pull request
Feb 21, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

+2 more reviewers

@driesengdriesengdrieseng left review comments
@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Sub-optimal code generated for Unsafe.As


4 participants

@TIHan@jakobbotsch@drieseng@SingleAccretion

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[JIT] LclMorph `GT_IND(GT_LCL_VAR_ADDR)` => `GT_CAST(GT_LCL_VAR)` narrow-cast only by TIHan · Pull Request #81454 · dotnet/runtime · GitHub
Skip to content
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only - #81454
Merged
TIHan merged 30 commits into
dotnet:mainfrom 
TIHan:fold-gt-lcl-var-addr
Feb 17, 2023
Merged
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only#81454
TIHan merged 30 commits into
dotnet:mainfrom 
TIHan:fold-gt-lcl-var-addr
Conversation
@TIHan
@TIHanTIHan
commented
Feb 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Will resolve: #55064
There are cases where IND{short}(LCL_VAR_ADDR{int}) can be transformed to CAST{int <- short <- int}(LCL_VAR{int}) to prevent storing and reading from memory, but only if the indirection is narrow for integer types.
This transformation will not occur for the storage of an assignment: ASG(IND{short}(LCL_VAR_ADDR{int}}, ..).
Acceptance Criteria
  •  Disasm tests
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Feb 1, 2023
@ghostghost
assigned TIHanFeb 1, 2023
@ghost
ghost
commented
Feb 1, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:TIHan
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding IND(GT_LCL_VAR_ADDR)[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR)Feb 1, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR)[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VARFeb 1, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 1, 2023

Closed

@TIHan
TIHanforce-pushed
the
fold-gt-lcl-var-addr
branch
from
3c27c57 to
af037ecCompareFebruary 1, 2023 20:14
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 2, 2023

Closed

5 tasks
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small types[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
drieseng
drieseng
reviewed
Feb 4, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHanTIHan
changed the title
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast onlyFeb 7, 2023
@TIHanTIHan
mentioned this pull request
Feb 7, 2023
 Merged

2 tasks
@TIHanTIHan
closed this
Feb 9, 2023
@TIHanTIHan
reopened this
Feb 9, 2023
@TIHan
TIHan
marked this pull request as ready for review
February 14, 2023 23:23
@TIHan
TIHan
commented
Feb 14, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib cc @jakobbotsch
Diffs
There are a lot of ARM32 regressions, but this is due to the CSE rules for that target.

Other regressions are due to more CSEs.
@jakobbotsch
jakobbotsch
commented
Feb 15, 2023

Copy link


Copy Markdown

Member
There are a lot of ARM32 regressions, but this is due to the CSE rules for that target.
Can you show some examples? What are/aren't we CSE'ing that changed from before?
SingleAccretion
SingleAccretion
reviewed
Feb 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHan
TIHan
commented
Feb 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@jakobbotsch diff dump of one of the ARM32 regressions
arm32_diff_dump.zip
SingleAccretion
SingleAccretion
reviewed
Feb 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHan@SingleAccretion
Update src/coreclr/jit/lclmorph.cpp
93d81b6
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
@TIHan
TIHan
commented
Feb 16, 2023

Copy link


Copy Markdown

ContributorAuthor
@SingleAccretion Ok, looks like I was seeing things before - allowed looking at long types for 32bit and there are quite a bit of improvements.
SingleAccretion
SingleAccretion
approved these changes
Feb 16, 2023
View reviewed changes
@SingleAccretionSingleAccretion
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
jakobbotsch
jakobbotsch
approved these changes
Feb 17, 2023
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We looked at one of the arm32 regressions offline and it was caused by CSE being less aggressive due to more tracked locals now existing, so not something we should be compensating for here.
@TIHan
TIHan
merged commit 925028b
into
dotnet:mainFeb 17, 2023
@TIHan
TIHan
deleted the

fold-gt-lcl-var-addr

branch
February 17, 2023 23:19
@dakersnardakersnar
mentioned this pull request
Feb 21, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

+2 more reviewers

@driesengdriesengdrieseng left review comments
@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Sub-optimal code generated for Unsafe.As


4 participants

@TIHan@jakobbotsch@drieseng@SingleAccretion

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[JIT] LclMorph `GT_IND(GT_LCL_VAR_ADDR)` => `GT_CAST(GT_LCL_VAR)` narrow-cast only by TIHan · Pull Request #81454 · dotnet/runtime · GitHub
Skip to content
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only - #81454
Merged
TIHan merged 30 commits into
dotnet:mainfrom 
TIHan:fold-gt-lcl-var-addr
Feb 17, 2023
Merged
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only#81454
TIHan merged 30 commits into
dotnet:mainfrom 
TIHan:fold-gt-lcl-var-addr
Conversation
@TIHan
@TIHanTIHan
commented
Feb 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Will resolve: #55064
There are cases where IND{short}(LCL_VAR_ADDR{int}) can be transformed to CAST{int <- short <- int}(LCL_VAR{int}) to prevent storing and reading from memory, but only if the indirection is narrow for integer types.
This transformation will not occur for the storage of an assignment: ASG(IND{short}(LCL_VAR_ADDR{int}}, ..).
Acceptance Criteria
  •  Disasm tests
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Feb 1, 2023
@ghostghost
assigned TIHanFeb 1, 2023
@ghost
ghost
commented
Feb 1, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:TIHan
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding IND(GT_LCL_VAR_ADDR)[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR)Feb 1, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR)[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VARFeb 1, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 1, 2023

Closed

@TIHan
TIHanforce-pushed
the
fold-gt-lcl-var-addr
branch
from
3c27c57 to
af037ecCompareFebruary 1, 2023 20:14
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 2, 2023

Closed

5 tasks
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small types[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
drieseng
drieseng
reviewed
Feb 4, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHanTIHan
changed the title
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast onlyFeb 7, 2023
@TIHanTIHan
mentioned this pull request
Feb 7, 2023
 Merged

2 tasks
@TIHanTIHan
closed this
Feb 9, 2023
@TIHanTIHan
reopened this
Feb 9, 2023
@TIHan
TIHan
marked this pull request as ready for review
February 14, 2023 23:23
@TIHan
TIHan
commented
Feb 14, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib cc @jakobbotsch
Diffs
There are a lot of ARM32 regressions, but this is due to the CSE rules for that target.

Other regressions are due to more CSEs.
@jakobbotsch
jakobbotsch
commented
Feb 15, 2023

Copy link


Copy Markdown

Member
There are a lot of ARM32 regressions, but this is due to the CSE rules for that target.
Can you show some examples? What are/aren't we CSE'ing that changed from before?
SingleAccretion
SingleAccretion
reviewed
Feb 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHan
TIHan
commented
Feb 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@jakobbotsch diff dump of one of the ARM32 regressions
arm32_diff_dump.zip
SingleAccretion
SingleAccretion
reviewed
Feb 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHan@SingleAccretion
Update src/coreclr/jit/lclmorph.cpp
93d81b6
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
@TIHan
TIHan
commented
Feb 16, 2023

Copy link


Copy Markdown

ContributorAuthor
@SingleAccretion Ok, looks like I was seeing things before - allowed looking at long types for 32bit and there are quite a bit of improvements.
SingleAccretion
SingleAccretion
approved these changes
Feb 16, 2023
View reviewed changes
@SingleAccretionSingleAccretion
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
jakobbotsch
jakobbotsch
approved these changes
Feb 17, 2023
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We looked at one of the arm32 regressions offline and it was caused by CSE being less aggressive due to more tracked locals now existing, so not something we should be compensating for here.
@TIHan
TIHan
merged commit 925028b
into
dotnet:mainFeb 17, 2023
@TIHan
TIHan
deleted the

fold-gt-lcl-var-addr

branch
February 17, 2023 23:19
@dakersnardakersnar
mentioned this pull request
Feb 21, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

+2 more reviewers

@driesengdriesengdrieseng left review comments
@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Sub-optimal code generated for Unsafe.As


4 participants

@TIHan@jakobbotsch@drieseng@SingleAccretion

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[JIT] LclMorph `GT_IND(GT_LCL_VAR_ADDR)` => `GT_CAST(GT_LCL_VAR)` narrow-cast only by TIHan · Pull Request #81454 · dotnet/runtime · GitHub
Skip to content
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only - #81454
Merged
TIHan merged 30 commits into
dotnet:mainfrom 
TIHan:fold-gt-lcl-var-addr
Feb 17, 2023
Merged
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only#81454
TIHan merged 30 commits into
dotnet:mainfrom 
TIHan:fold-gt-lcl-var-addr
Conversation
@TIHan
@TIHanTIHan
commented
Feb 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Will resolve: #55064
There are cases where IND{short}(LCL_VAR_ADDR{int}) can be transformed to CAST{int <- short <- int}(LCL_VAR{int}) to prevent storing and reading from memory, but only if the indirection is narrow for integer types.
This transformation will not occur for the storage of an assignment: ASG(IND{short}(LCL_VAR_ADDR{int}}, ..).
Acceptance Criteria
  •  Disasm tests
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Feb 1, 2023
@ghostghost
assigned TIHanFeb 1, 2023
@ghost
ghost
commented
Feb 1, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:TIHan
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding IND(GT_LCL_VAR_ADDR)[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR)Feb 1, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR)[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VARFeb 1, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 1, 2023

Closed

@TIHan
TIHanforce-pushed
the
fold-gt-lcl-var-addr
branch
from
3c27c57 to
af037ecCompareFebruary 1, 2023 20:14
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 2, 2023

Closed

5 tasks
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small types[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
drieseng
drieseng
reviewed
Feb 4, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHanTIHan
changed the title
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast onlyFeb 7, 2023
@TIHanTIHan
mentioned this pull request
Feb 7, 2023
 Merged

2 tasks
@TIHanTIHan
closed this
Feb 9, 2023
@TIHanTIHan
reopened this
Feb 9, 2023
@TIHan
TIHan
marked this pull request as ready for review
February 14, 2023 23:23
@TIHan
TIHan
commented
Feb 14, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib cc @jakobbotsch
Diffs
There are a lot of ARM32 regressions, but this is due to the CSE rules for that target.

Other regressions are due to more CSEs.
@jakobbotsch
jakobbotsch
commented
Feb 15, 2023

Copy link


Copy Markdown

Member
There are a lot of ARM32 regressions, but this is due to the CSE rules for that target.
Can you show some examples? What are/aren't we CSE'ing that changed from before?
SingleAccretion
SingleAccretion
reviewed
Feb 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHan
TIHan
commented
Feb 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@jakobbotsch diff dump of one of the ARM32 regressions
arm32_diff_dump.zip
SingleAccretion
SingleAccretion
reviewed
Feb 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHan@SingleAccretion
Update src/coreclr/jit/lclmorph.cpp
93d81b6
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
@TIHan
TIHan
commented
Feb 16, 2023

Copy link


Copy Markdown

ContributorAuthor
@SingleAccretion Ok, looks like I was seeing things before - allowed looking at long types for 32bit and there are quite a bit of improvements.
SingleAccretion
SingleAccretion
approved these changes
Feb 16, 2023
View reviewed changes
@SingleAccretionSingleAccretion
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
jakobbotsch
jakobbotsch
approved these changes
Feb 17, 2023
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We looked at one of the arm32 regressions offline and it was caused by CSE being less aggressive due to more tracked locals now existing, so not something we should be compensating for here.
@TIHan
TIHan
merged commit 925028b
into
dotnet:mainFeb 17, 2023
@TIHan
TIHan
deleted the

fold-gt-lcl-var-addr

branch
February 17, 2023 23:19
@dakersnardakersnar
mentioned this pull request
Feb 21, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

+2 more reviewers

@driesengdriesengdrieseng left review comments
@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Sub-optimal code generated for Unsafe.As


4 participants

@TIHan@jakobbotsch@drieseng@SingleAccretion

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[JIT] LclMorph `GT_IND(GT_LCL_VAR_ADDR)` => `GT_CAST(GT_LCL_VAR)` narrow-cast only by TIHan · Pull Request #81454 · dotnet/runtime · GitHub
Skip to content
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only - #81454
Merged
TIHan merged 30 commits into
dotnet:mainfrom 
TIHan:fold-gt-lcl-var-addr
Feb 17, 2023
Merged
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only#81454
TIHan merged 30 commits into
dotnet:mainfrom 
TIHan:fold-gt-lcl-var-addr
Conversation
@TIHan
@TIHanTIHan
commented
Feb 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Will resolve: #55064
There are cases where IND{short}(LCL_VAR_ADDR{int}) can be transformed to CAST{int <- short <- int}(LCL_VAR{int}) to prevent storing and reading from memory, but only if the indirection is narrow for integer types.
This transformation will not occur for the storage of an assignment: ASG(IND{short}(LCL_VAR_ADDR{int}}, ..).
Acceptance Criteria
  •  Disasm tests
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Feb 1, 2023
@ghostghost
assigned TIHanFeb 1, 2023
@ghost
ghost
commented
Feb 1, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:TIHan
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding IND(GT_LCL_VAR_ADDR)[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR)Feb 1, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR)[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VARFeb 1, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 1, 2023

Closed

@TIHan
TIHanforce-pushed
the
fold-gt-lcl-var-addr
branch
from
3c27c57 to
af037ecCompareFebruary 1, 2023 20:14
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 2, 2023

Closed

5 tasks
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small types[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
drieseng
drieseng
reviewed
Feb 4, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHanTIHan
changed the title
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast onlyFeb 7, 2023
@TIHanTIHan
mentioned this pull request
Feb 7, 2023
 Merged

2 tasks
@TIHanTIHan
closed this
Feb 9, 2023
@TIHanTIHan
reopened this
Feb 9, 2023
@TIHan
TIHan
marked this pull request as ready for review
February 14, 2023 23:23
@TIHan
TIHan
commented
Feb 14, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib cc @jakobbotsch
Diffs
There are a lot of ARM32 regressions, but this is due to the CSE rules for that target.

Other regressions are due to more CSEs.
@jakobbotsch
jakobbotsch
commented
Feb 15, 2023

Copy link


Copy Markdown

Member
There are a lot of ARM32 regressions, but this is due to the CSE rules for that target.
Can you show some examples? What are/aren't we CSE'ing that changed from before?
SingleAccretion
SingleAccretion
reviewed
Feb 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHan
TIHan
commented
Feb 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@jakobbotsch diff dump of one of the ARM32 regressions
arm32_diff_dump.zip
SingleAccretion
SingleAccretion
reviewed
Feb 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHan@SingleAccretion
Update src/coreclr/jit/lclmorph.cpp
93d81b6
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
@TIHan
TIHan
commented
Feb 16, 2023

Copy link


Copy Markdown

ContributorAuthor
@SingleAccretion Ok, looks like I was seeing things before - allowed looking at long types for 32bit and there are quite a bit of improvements.
SingleAccretion
SingleAccretion
approved these changes
Feb 16, 2023
View reviewed changes
@SingleAccretionSingleAccretion
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
jakobbotsch
jakobbotsch
approved these changes
Feb 17, 2023
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We looked at one of the arm32 regressions offline and it was caused by CSE being less aggressive due to more tracked locals now existing, so not something we should be compensating for here.
@TIHan
TIHan
merged commit 925028b
into
dotnet:mainFeb 17, 2023
@TIHan
TIHan
deleted the

fold-gt-lcl-var-addr

branch
February 17, 2023 23:19
@dakersnardakersnar
mentioned this pull request
Feb 21, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

+2 more reviewers

@driesengdriesengdrieseng left review comments
@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Sub-optimal code generated for Unsafe.As


4 participants

@TIHan@jakobbotsch@drieseng@SingleAccretion

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[JIT] LclMorph `GT_IND(GT_LCL_VAR_ADDR)` => `GT_CAST(GT_LCL_VAR)` narrow-cast only by TIHan · Pull Request #81454 · dotnet/runtime · GitHub
Skip to content
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only - #81454
Merged
TIHan merged 30 commits into
dotnet:mainfrom 
TIHan:fold-gt-lcl-var-addr
Feb 17, 2023
Merged
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast only#81454
TIHan merged 30 commits into
dotnet:mainfrom 
TIHan:fold-gt-lcl-var-addr
Conversation
@TIHan
@TIHanTIHan
commented
Feb 1, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Description
Will resolve: #55064
There are cases where IND{short}(LCL_VAR_ADDR{int}) can be transformed to CAST{int <- short <- int}(LCL_VAR{int}) to prevent storing and reading from memory, but only if the indirection is narrow for integer types.
This transformation will not occur for the storage of an assignment: ASG(IND{short}(LCL_VAR_ADDR{int}}, ..).
Acceptance Criteria
  •  Disasm tests
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Feb 1, 2023
@ghostghost
assigned TIHanFeb 1, 2023
@ghost
ghost
commented
Feb 1, 2023

Copy link


Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak

See info in area-owners.md if you want to be subscribed.
Issue Details
null
Author:TIHan
Assignees:-
Labels:
area-CodeGen-coreclr
Milestone:-
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding IND(GT_LCL_VAR_ADDR)[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR)Feb 1, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR)[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VARFeb 1, 2023
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 1, 2023

Closed

@TIHan
TIHanforce-pushed
the
fold-gt-lcl-var-addr
branch
from
3c27c57 to
af037ecCompareFebruary 1, 2023 20:14
@build-analysisbuild-analysisBot
mentioned this pull request
Feb 2, 2023

Closed

5 tasks
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_LCL_VAR for small types[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] EXPERIMENT - Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
@TIHanTIHan
changed the title
[JIT] Folding GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small typesFeb 4, 2023
drieseng
drieseng
reviewed
Feb 4, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHanTIHan
changed the title
[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) for small types[JIT] LclMorph GT_IND(GT_LCL_VAR_ADDR) => GT_CAST(GT_LCL_VAR) narrow-cast onlyFeb 7, 2023
@TIHanTIHan
mentioned this pull request
Feb 7, 2023
 Merged

2 tasks
@TIHanTIHan
closed this
Feb 9, 2023
@TIHanTIHan
reopened this
Feb 9, 2023
@TIHan
TIHan
marked this pull request as ready for review
February 14, 2023 23:23
@TIHan
TIHan
commented
Feb 14, 2023•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@dotnet/jit-contrib cc @jakobbotsch
Diffs
There are a lot of ARM32 regressions, but this is due to the CSE rules for that target.

Other regressions are due to more CSEs.
@jakobbotsch
jakobbotsch
commented
Feb 15, 2023

Copy link


Copy Markdown

Member
There are a lot of ARM32 regressions, but this is due to the CSE rules for that target.
Can you show some examples? What are/aren't we CSE'ing that changed from before?
SingleAccretion
SingleAccretion
reviewed
Feb 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHan
TIHan
commented
Feb 15, 2023

Copy link


Copy Markdown

ContributorAuthor
@jakobbotsch diff dump of one of the ARM32 regressions
arm32_diff_dump.zip
SingleAccretion
SingleAccretion
reviewed
Feb 15, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/lclmorph.cpp
Outdated

@TIHan@SingleAccretion
Update src/coreclr/jit/lclmorph.cpp
93d81b6
Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>
@TIHan
TIHan
commented
Feb 16, 2023

Copy link


Copy Markdown

ContributorAuthor
@SingleAccretion Ok, looks like I was seeing things before - allowed looking at long types for 32bit and there are quite a bit of improvements.
SingleAccretion
SingleAccretion
approved these changes
Feb 16, 2023
View reviewed changes
@SingleAccretionSingleAccretion
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
jakobbotsch
jakobbotsch
approved these changes
Feb 17, 2023
View reviewed changes
@jakobbotschjakobbotsch
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We looked at one of the arm32 regressions offline and it was caused by CSE being less aggressive due to more tracked locals now existing, so not something we should be compensating for here.
@TIHan
TIHan
merged commit 925028b
into
dotnet:mainFeb 17, 2023
@TIHan
TIHan
deleted the

fold-gt-lcl-var-addr

branch
February 17, 2023 23:19
@dakersnardakersnar
mentioned this pull request
Feb 21, 2023

Closed

@ghostghost
locked as resolved and limited conversation to collaborators
Mar 20, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

+2 more reviewers

@driesengdriesengdrieseng left review comments
@SingleAccretionSingleAccretionSingleAccretion approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@TIHanTIHan

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Sub-optimal code generated for Unsafe.As


4 participants

@TIHan@jakobbotsch@drieseng@SingleAccretion