Uh oh!
There was an error while loading. Please reload this page.
Suppress clang-16 warnings - #81573
Merged
Merged
Conversation
ghost
commented
Feb 2, 2023
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
commented
Feb 2, 2023
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsFound these on Ubuntu 22.04 amd64 with clang-16 (RC1).
|
am11
commented
Feb 2, 2023
Uh oh!
There was an error while loading. Please reload this page.
am11
commented
Feb 2, 2023
Uh oh!
There was an error while loading. Please reload this page.
am11
commented
Feb 2, 2023
Uh oh!
There was an error while loading. Please reload this page.
am11
commented
Feb 2, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
am11force-pushed
the
feature/native/clang-16
branch
2 times, most recently
from
February 4, 2023 01:10
62669aa to
4fe0733Compaream11force-pushed
the
feature/native/clang-16
branch
from
February 4, 2023 09:50
646ba71 to
dced5d0Compaream11
commented
Feb 4, 2023
MemberAuthor
Mono failure is unrelated: #81123 |
mikem8361
approved these changes
Feb 4, 2023
jkotas
approved these changes
Feb 4, 2023
mikem8361 pushed a commit
to mikem8361/runtime
that referenced
this pull request
Feb 22, 2023
Part of PR dotnet#81573 needed to be undone to build libmscordbi.so without any undefined symbols from the DAC. The DAC_PAL_RegisterModule, etc. stubs I recommended didn't work and DBI could not be loaded by SOS because of missing exports. The double pass at the libraries from the `target_link_libraries(mscordbi ${COREDBI_LIBRARIES} ${COREDBI_LIBRARIES})` cmake file needed to be restored. The stubs were not needed after that.
mikem8361 pushed a commit
that referenced
this pull request
Feb 22, 2023
* Fix DBI loading problem on Linux Part of PR #81573 needed to be undone to build libmscordbi.so without any undefined symbols from the DAC. The DAC_PAL_RegisterModule, etc. stubs I recommended didn't work and DBI could not be loaded by SOS because of missing exports. The double pass at the libraries from the `target_link_libraries(mscordbi ${COREDBI_LIBRARIES} ${COREDBI_LIBRARIES})` cmake file needed to be restored. The stubs were not needed after that. * Fix clang16 build problems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found these on Ubuntu 22.04 amd64 with clang-16 (RC1).