Skip to content

Use eager evaluation when configuring the JsonTypeInfo type graph. - #81576

Merged
eiriktsarpalis merged 2 commits into
dotnet:mainfrom
eiriktsarpalis:jsontypeinfo-locking
Feb 3, 2023
Merged

Use eager evaluation when configuring the JsonTypeInfo type graph.#81576
eiriktsarpalis merged 2 commits into
dotnet:mainfrom
eiriktsarpalis:jsontypeinfo-locking

Conversation

@eiriktsarpalis

@eiriktsarpaliseiriktsarpalis commented Feb 2, 2023

Copy link
Copy Markdown
Member

Continuing from #81306, this PR changes the evaluation strategy when configuring JsonTypeInfo so that the type graph is always traversed eagerly.

Contributes to #71933.

@ghost

ghost commented Feb 2, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Continuing from #81306, this PR changes the evaluation strategy when configuring JsonTypeInfo so that the type graph is always traversed eagerly.

Contributes to #71933.

Author:eiriktsarpalis
Assignees:-
Labels:

area-System.Text.Json

Milestone:-

@eiriktsarpaliseiriktsarpalis added this to the 8.0.0 milestone Feb 2, 2023
krwq
krwq reviewed Feb 3, 2023
View reviewed changes
Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.cs Outdated
krwq
krwq approved these changes Feb 3, 2023
View reviewed changes
@eiriktsarpalis
eiriktsarpalis merged commit 490b20f into dotnet:mainFeb 3, 2023
@eiriktsarpalis
eiriktsarpalis deleted the jsontypeinfo-locking branch February 3, 2023 15:46
@build-analysisbuild-analysisBot mentioned this pull request Feb 3, 2023
Closed
@krwqkrwq mentioned this pull request Feb 6, 2023
Closed
@krwqkrwq mentioned this pull request Feb 16, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krwqkrwqkrwq approved these changes
@layomialayomiaAwaiting requested review from layomia
@stephentoubstephentoubAwaiting requested review from stephentoub

Assignees

@eiriktsarpaliseiriktsarpalis

Labels

area-System.Text.Json

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@eiriktsarpalis@krwq