Skip to content

Console.Tests: extend VerifyInstalledTermInfosParse test. - #82025

Merged
adamsitnik merged 1 commit into
dotnet:mainfrom
tmds:terminfo_test
Feb 13, 2023
Merged

Console.Tests: extend VerifyInstalledTermInfosParse test.#82025
adamsitnik merged 1 commit into
dotnet:mainfrom
tmds:terminfo_test

Conversation

@tmds

@tmdstmds commented Feb 13, 2023

Copy link
Copy Markdown
Member
  • Run against TERMINFO envvar, and HOME terminfo too.
  • Don't stop on first problem, aggregate exceptions.
  • Include database file name in the exception.

@adamsitnik ptal.

@tmds
Console.Tests: extend VerifyInstalledTermInfosParse test.
e58ae4e
- Run against TERMINFO envvar, and HOME terminfo too.
- Don't stop on first problem, aggregate exceptions.
- Include database file name in the exception.
@ghostghost added area-System.Console community-contribution Indicates that the PR has been added by a community member labels Feb 13, 2023
@ghost

ghost commented Feb 13, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Run against TERMINFO envvar, and HOME terminfo too.
  • Don't stop on first problem, aggregate exceptions.
  • Include database file name in the exception.

@adamsitnik ptal.

Author:tmds
Assignees:-
Labels:

area-System.Console, community-contribution

Milestone:-

@tmdstmds mentioned this pull request Feb 13, 2023
Closed
@build-analysisbuild-analysisBot mentioned this pull request Feb 13, 2023
Closed
adamsitnik
adamsitnik approved these changes Feb 13, 2023
View reviewed changes

@adamsitnikadamsitnik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @tmds !

@adamsitnik
adamsitnik merged commit ae6666d into dotnet:mainFeb 13, 2023
@ghostghost locked as resolved and limited conversation to collaborators Mar 15, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

No one assigned

Labels

area-System.Consolecommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmds@adamsitnik