[browser] wasm memory snapshot into browser cache by pavelsavara · Pull Request #82049 · dotnet/runtime

pavelsavara · 2023-02-13T21:15:45Z

create memory snapshot after first load
skip downloads of assets when there is memory already in cache
resize wasm memory as necessary and apply the cached memory bytes
calculate hash for all assets and the config file
added new .withStartupMemoryCache() public API. true by default.
start threads and eventPipe bit later (after taking snapshot)
disabled JITERP during creation of snapshot.

Other

cleanup of anyModule
moved ICU shard logic to icu.ts

ghost · 2023-02-13T21:15:58Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

create memory snapshot after first load
skip downloads of assets when there is memory already in cache
resize wasm memory as necessary and apply the cached memory bytes
calculate hash for all assets and the config file
added new .withMemoryCache() API - internal for now
added new MSBuild property WasmNativeAssetsPath so that files could be hashed in WasmAppBuilder

Other

cleanup of anyModule
removed obsolete mono_load_runtime_and_bcl_args

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	`arch-wasm`, `area-System.Runtime.InteropServices.JavaScript`
Milestone:	8.0.0

# Conflicts: # src/mono/wasm/runtime/types.ts

kg · 2023-03-03T20:17:43Z

Is this being turned on by default?

pavelsavara · 2023-03-03T23:18:25Z

/azp run runtime-wasm

azure-pipelines · 2023-03-03T23:18:35Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-03-13T12:27:58Z

/azp run runtime-wasm

azure-pipelines · 2023-03-13T12:28:16Z

Azure Pipelines successfully started running 1 pipeline(s).

@kg

- @kg feedback about mono_jiterp_do_jit_call_indirect

pavelsavara · 2023-03-13T16:04:59Z

/azp run runtime-wasm

azure-pipelines · 2023-03-13T16:05:10Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-03-14T01:05:19Z

CI failures

System.Drawing.PrimitivesTest.RectangleTests.RectangleFConversionTest is [mono] System.Drawing.PrimitivesTest.RectangleTests.RectangleFConversionTest fails on devices #60585 unrelated
NuGet-Migrations is unrelated and known
Multi-threaded DebuggerTests failures are unrelated
System.Net.WebSockets.Client.Tests timeouts on nodeJS is unrelated

maraf

Looks good to me 👍

Co-authored-by: Marek Fišera <mara@neptuo.com>

pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript labels Feb 13, 2023

pavelsavara added this to the 8.0.0 milestone Feb 13, 2023

pavelsavara requested a review from maraf February 13, 2023 21:15

pavelsavara self-assigned this Feb 13, 2023

This was referenced Feb 14, 2023
Tracking issue for CI build timeouts #76454
Closed
NuGet failing with Response status code does not indicate success: 503 (Service Unavailable) dotnet/arcade#11723
Open

pavelsavara mentioned this pull request Feb 24, 2023
[wasm] Tracking issue for build/bundler changes #70762
Closed
49 tasks

pavelsavara force-pushed the browser_memory_snapshot3 branch from bb59529 to e928ad9Compare March 2, 2023 00:28

pavelsavara commented Mar 2, 2023
View reviewed changes

Comment threadsrc/mono/wasm/runtime/startup.ts Outdated

pavelsavara added 3 commits March 3, 2023 17:18

wip
ea02d94

wip
c1aa6c3

wip
bf9ef4d

pavelsavara force-pushed the browser_memory_snapshot3 branch from 650d283 to bf9ef4dCompare March 3, 2023 16:32

Merge branch 'main' into browser_memory_snapshot3
f883a72
# Conflicts: # src/mono/wasm/runtime/types.ts

build-analysisBot mentioned this pull request Mar 3, 2023
IOException running NuGet-Migrations during tests in dotnet CLI first run #80619
Closed

pavelsavara marked this pull request as ready for review March 3, 2023 20:10

pavelsavara requested review from kg and lewing as code owners March 3, 2023 20:10

pavelsavara requested a review from ilonatommy March 3, 2023 20:12

kg reviewed Mar 3, 2023
View reviewed changes

Comment threadsrc/mono/wasm/runtime/icu.ts

kg reviewed Mar 3, 2023
View reviewed changes

Comment threadsrc/mono/wasm/runtime/storage.ts Outdated

kg reviewed Mar 3, 2023
View reviewed changes

Comment threadsrc/mono/wasm/runtime/strings.ts Outdated

pavelsavara added 3 commits March 3, 2023 23:57

wip
3fe9aba

Merge branch 'main' into browser_memory_snapshot3
f4225aa

fix
d2e5b49

kg reviewed Mar 11, 2023
View reviewed changes

Comment threadsrc/mono/wasm/test-main.js

build-analysisBot mentioned this pull request Mar 11, 2023
[wasm][debugger] DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment failing #64188
Closed

pavelsavara added 3 commits March 13, 2023 09:32

fix
94e931a

optimize timezone detection
2a7508e

feedback
9759ad8

pavelsavara requested review from kg and maraf March 13, 2023 11:24

pavelsavara added 5 commits March 13, 2023 13:40

fix
1f4e4c6

- enable snapshot in blazor
e2a2cd4
- @kg feedback about mono_jiterp_do_jit_call_indirect

store cache key
eaaeaa5

feedback and cleanup
bc86ffe

fix debugging
59a7a56

pavelsavara added 2 commits March 14, 2023 01:52

fix
6d9f7ee

Merge branch 'main' into browser_memory_snapshot3
3e961d1

build-analysisBot mentioned this pull request Mar 14, 2023
[jitstress] HardwareIntrinsics_ro fails with "process cannot access the file" error #83298
Closed

maraf approved these changes Mar 14, 2023
View reviewed changes

Comment threadsrc/mono/wasm/memory-snapshot.md Outdated
Comment threadsrc/mono/wasm/memory-snapshot.md Outdated
Comment threadsrc/mono/wasm/runtime/assets.ts Outdated
Comment threadsrc/mono/wasm/runtime/assets.ts Outdated

pavelsavaraand others added 5 commits March 14, 2023 09:24

Update src/mono/wasm/memory-snapshot.md
f617787
Co-authored-by: Marek Fišera <mara@neptuo.com>

Update src/mono/wasm/memory-snapshot.md
cfc5acf
Co-authored-by: Marek Fišera <mara@neptuo.com>

Update src/mono/wasm/runtime/assets.ts
c78ef57
Co-authored-by: Marek Fišera <mara@neptuo.com>

Update src/mono/wasm/runtime/assets.ts
7309e43
Co-authored-by: Marek Fišera <mara@neptuo.com>

Merge branch 'main' into browser_memory_snapshot3
5f8aeef

pavelsavara merged commit bb2b860 into dotnet:mainMar 14, 2023

pavelsavara mentioned this pull request Mar 15, 2023
[browser] fix noisy tests #83448
Merged

ghost locked as resolved and limited conversation to collaborators Apr 13, 2023

pavelsavara deleted the browser_memory_snapshot3 branch September 2, 2024 15:30

Uh oh!

Conversation

pavelsavara commented Feb 13, 2023• edited by maraf Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other

Uh oh!

ghost commented Feb 13, 2023

Other

Uh oh!

Uh oh!

kg commented Mar 3, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pavelsavara commented Mar 3, 2023

Uh oh!

azure-pipelinesBot commented Mar 3, 2023

Uh oh!

Uh oh!

pavelsavara commented Mar 13, 2023

Uh oh!

azure-pipelinesBot commented Mar 13, 2023

Uh oh!

pavelsavara commented Mar 13, 2023

Uh oh!

azure-pipelinesBot commented Mar 13, 2023

Uh oh!

pavelsavara commented Mar 14, 2023

Uh oh!

maraf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pavelsavara commented Feb 13, 2023•
edited by maraf
Loading