Skip to content

Add cmake check for ioclt prototype - #82173

Merged
janvorli merged 2 commits into
dotnet:mainfrom
am11:feature/native/build-config
Feb 16, 2023
Merged

Add cmake check for ioclt prototype#82173
janvorli merged 2 commits into
dotnet:mainfrom
am11:feature/native/build-config

Conversation

@am11

@am11am11 commented Feb 15, 2023

Copy link
Copy Markdown
Member

Fix#82161.

On some Unix-likes, such as linux with musl-libc and illumos, the second argument of ioctl is int request instead of unsigned long request.

Thanks to @uweigand for investigating what's going on: #76500 (comment).

FYI @Sapana-Khemkar@ayakael

@ghost

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@am11
am11 requested a review from janvorliFebruary 15, 2023 15:56
@ghostghost added the community-contribution Indicates that the PR has been added by a community member label Feb 15, 2023
@ghost

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #82161.

On some Unix-likes, such as linux with mul-libc and illumos, the second argument of ioctl is int request instead of unsigned long request.

Thanks to @uweigand for investigating what's going on: #76500 (comment).

FYI @Sapana-Khemkar@ayakael

Author:am11
Assignees:-
Labels:

area-Infrastructure-libraries

Milestone:-

@am11

am11 commented Feb 15, 2023

Copy link
Copy Markdown
MemberAuthor

linux-arm64 test failure is unrelated: #81123.

@janvorlijanvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli
janvorli merged commit 4e0ff82 into dotnet:mainFeb 16, 2023
@ayakaelayakael mentioned this pull request Feb 16, 2023
@ghostghost locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-librariescommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

runtime-community pipeline fails to build

2 participants

@am11@janvorli