') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [release/7.0][wasm] Use latest sdk 7.0 sdk for workload testing, and perf runs by radical · Pull Request #82219 · dotnet/runtime · GitHub
Skip to content

[release/7.0][wasm] Use latest sdk 7.0 sdk for workload testing, and perf runs - #82219

Merged
carlossanlop merged 2 commits into
dotnet:release/7.0from
radical:fix-perf-7
Mar 8, 2023
Merged

[release/7.0][wasm] Use latest sdk 7.0 sdk for workload testing, and perf runs#82219
carlossanlop merged 2 commits into
dotnet:release/7.0from
radical:fix-perf-7

Conversation

@radical

@radicalradical commented Feb 16, 2023

Copy link
Copy Markdown
Member

Fixes 7.0 perf runs:

Traceback (most recent call last):
File "/mnt/vss/_work/1/s/Payload/performance/scripts/ci_setup.py", line 373, in <module>
__main(sys.argv[1:])
File "/mnt/vss/_work/1/s/Payload/performance/scripts/ci_setup.py", line 318, in __main
dotnet_version = dotnet.get_dotnet_version(target_framework_moniker, args.cli) if args.dotnet_versions == [] else args.dotnet_versions[0]
File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 549, in get_dotnet_version
sdk_path = get_sdk_path(dotnet_path) if sdk_path is None else sdk_path
File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 533, in get_sdk_path
base_path = get_base_path(dotnet_path)
File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 527, in get_base_path
'Did not find "Base Path:" entry on the `dotnet --info` command'
RuntimeError: Did not find "Base Path:" entry on the `dotnet --info` command

@radicalradical added arch-wasm WebAssembly architecture area-Infrastructure-mono perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines labels Feb 16, 2023
@ghostghost assigned radicalFeb 16, 2023
@ghost

ghost commented Feb 16, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes 7.0 perf runs:

Traceback (most recent call last):
File "/mnt/vss/_work/1/s/Payload/performance/scripts/ci_setup.py", line 373, in <module>
__main(sys.argv[1:])
File "/mnt/vss/_work/1/s/Payload/performance/scripts/ci_setup.py", line 318, in __main
dotnet_version = dotnet.get_dotnet_version(target_framework_moniker, args.cli) if args.dotnet_versions == [] else args.dotnet_versions[0]
File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 549, in get_dotnet_version
sdk_path = get_sdk_path(dotnet_path) if sdk_path is None else sdk_path
File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 533, in get_sdk_path
base_path = get_base_path(dotnet_path)
File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 527, in get_base_path
'Did not find "Base Path:" entry on the `dotnet --info` command'
RuntimeError: Did not find "Base Path:" entry on the `dotnet --info` command
Author:radical
Assignees:-
Labels:

arch-wasm, area-Infrastructure-mono, perf-pipeline

Milestone:-

@radicalradical changed the title [wasm] Use latest sdk 7.0 sdk for workload testing, and perf runs[release/7.0][wasm] Use latest sdk 7.0 sdk for workload testing, and perf runsFeb 16, 2023
@build-analysisbuild-analysisBot mentioned this pull request Feb 16, 2023
Closed
@radical
[wasm] Use latest sdk 7.0 sdk for workload testing, and perf runs
94776de
Fixes 7.0 perf runs:
```
Traceback (most recent call last):
File "/mnt/vss/_work/1/s/Payload/performance/scripts/ci_setup.py", line 373, in <module>
__main(sys.argv[1:])
File "/mnt/vss/_work/1/s/Payload/performance/scripts/ci_setup.py", line 318, in __main
dotnet_version = dotnet.get_dotnet_version(target_framework_moniker, args.cli) if args.dotnet_versions == [] else args.dotnet_versions[0]
File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 549, in get_dotnet_version
sdk_path = get_sdk_path(dotnet_path) if sdk_path is None else sdk_path
File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 533, in get_sdk_path
base_path = get_base_path(dotnet_path)
File "/mnt/vss/_work/1/s/Payload/performance/scripts/dotnet.py", line 527, in get_base_path
'Did not find "Base Path:" entry on the `dotnet --info` command'
RuntimeError: Did not find "Base Path:" entry on the `dotnet --info` command
```
@radical
radical marked this pull request as ready for review March 7, 2023 21:06
@radical

radical commented Mar 7, 2023

Copy link
Copy Markdown
MemberAuthor

Waiting for dotnet-runtime-perf build 20230307.5.

@build-analysisbuild-analysisBot mentioned this pull request Mar 8, 2023
Closed
@build-analysisbuild-analysisBot mentioned this pull request Mar 8, 2023
Closed
@radical

radical commented Mar 8, 2023

Copy link
Copy Markdown
MemberAuthor

Waiting for dotnet-runtime-perf build 20230307.5.

This ran successfully except for one failure which was unrelated - build process exited with code 139.

@carlossanlop we want to merge this whenever the branch will be open for it.

@carlossanlop
carlossanlop merged commit 60d5c56 into dotnet:release/7.0Mar 8, 2023
@ghostghost locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing approved these changes

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Infrastructure-monoperf-pipelineIssues with dotnet-runtime-perf, or runtime-wasm-perf pipelines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@radical@lewing@carlossanlop