Skip to content

[release/7.0][workloads] Backport UsingMobileWorkload change - #82268

Merged
carlossanlop merged 3 commits into
dotnet:release/7.0from
steveisok:backport-workload-condition
Mar 8, 2023
Merged

[release/7.0][workloads] Backport UsingMobileWorkload change#82268
carlossanlop merged 3 commits into
dotnet:release/7.0from
steveisok:backport-workload-condition

Conversation

@steveisok

Copy link
Copy Markdown
Member

Backport of #77489

Adds the UsingMobileWorkload property along with a tighter check on when to import the aot task

Backport of dotnet#77489
Adds the UsingMobileWorkload property along with a tighter check on when to import the aot task
@ghost

Copy link
Copy Markdown

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 17, 2023
@jeffhandleyjeffhandley added area-Build-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 17, 2023

@lewinglewing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this code already live in Current? I missed this was targeting release/7.0

@lewing

Copy link
Copy Markdown
Member

should add the fixed condition to net6 too

@lewinglewing changed the title [workloads] Backport UsingMobileWorkload change[release/7.0][workloads] Backport UsingMobileWorkload changeFeb 17, 2023
@lewing

Copy link
Copy Markdown
Member

wasm failure is #82271

@steveisok

steveisok commented Mar 1, 2023

Copy link
Copy Markdown
MemberAuthor

@carlossanlop this is a tell mode change. I'll bump the PR to hopefully get better CI results ;-).

@carlossanlop

Copy link
Copy Markdown
Contributor

@mmitche are you ok with merging this? Just want to confirm that this won't mess with the build flows with the servicing branch closed.

@mmitche

Copy link
Copy Markdown
Member

@mmitche are you ok with merging this? Just want to confirm that this won't mess with the build flows with the servicing branch closed.

Please wait until branding/checkins tomorrow.

@carlossanlop
carlossanlop merged commit 8a7a2ea into dotnet:release/7.0Mar 8, 2023
@ghostghost locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@steveisok@lewing@carlossanlop@mmitche@jeffhandley