Uh oh!
There was an error while loading. Please reload this page.
Expose missing BinaryPrimitives APIs - #82310
Conversation
ghost
commented
Feb 17, 2023
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
commented
Feb 17, 2023
Tagging subscribers to this area: @dotnet/area-system-buffers Issue DetailsThis resolves #72107
|
stephentoub
commented
Feb 17, 2023
Is there anywhere we should be using these? |
tannergooding
commented
Feb 17, 2023
I'm not aware of any places where we're using Looks like we can switch to using |
Uh oh!
There was an error while loading. Please reload this page.
3340ac9 to
0cedabcComparetannergooding
commented
Feb 17, 2023
Fixed the docs and updated relevant places to use the new BinaryPrimitives APIs where applicable. |
tannergooding
commented
Feb 20, 2023
Failure is #82055, this can be merged once it gets sign-off. |
dakersnar
left a comment
There was a problem hiding this comment.
LGTM. Any specific logic in the tests that could use a deeper pass? Also, will we want these APIs on the new Decimal types?
None come to mind. These are relatively straightforward APIs.
Probably not without explicit user ask. Users can achieve the same thing by reading the raw bits and calling |
This resolves#72107