Skip to content

[release/6.0] Install native dependencies on all Apple OS in CI - #82322

Merged
carlossanlop merged 1 commit into
dotnet:release/6.0from
am11:feature/ci/native-deps
Mar 8, 2023
Merged

[release/6.0] Install native dependencies on all Apple OS in CI#82322
carlossanlop merged 1 commit into
dotnet:release/6.0from
am11:feature/ci/native-deps

Conversation

@am11

@am11am11 commented Feb 17, 2023

Copy link
Copy Markdown
Member

Backport of #82263.

@ghostghost added community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 17, 2023
@ghost

ghost commented Feb 17, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #82263.

Author:am11
Assignees:-
Labels:

area-Infrastructure, community-contribution, needs-area-label

Milestone:-

am11
am11 commented Feb 17, 2023
View reviewed changes
Comment threadeng/install-native-dependencies.sh Outdated

@am11am11Feb 17, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is new; lowercase changes in 8.0 didn't require this transformation.

@am11
am11force-pushed the feature/ci/native-deps branch from e94534f to d73cce3CompareFebruary 17, 2023 22:31
@am11am11 changed the title Install native dependencies on all Apple OS in CI[release/6.0] Install native dependencies on all Apple OS in CIFeb 17, 2023
@am11am11 removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 17, 2023
@am11am11 mentioned this pull request Feb 17, 2023
Merged
@am11
am11force-pushed the feature/ci/native-deps branch from d73cce3 to 0ccb1f1CompareFebruary 17, 2023 23:37
@steveisok
steveisok requested a review from a teamFebruary 18, 2023 00:35
@akoeplinger

akoeplinger commented Feb 20, 2023

Copy link
Copy Markdown
Member

actions/runner-images#7125 was merged which should add pkg-config back, it still needs to roll out as builds still fail as of right now. I'd be in favor of merging this but I'll let @carlossanlop decide.

@am11

am11 commented Feb 20, 2023

Copy link
Copy Markdown
MemberAuthor

We run install-native-dependencies is some OSX legs, this PR is basically aligning it to run on all OSX legs with native build. The installation is idempotent; it only installs the missing dependencies. This step is taking 15-20 seconds.

@runfoapprunfoappBot mentioned this pull request Feb 20, 2023
Closed
@akoeplingerakoeplinger mentioned this pull request Feb 21, 2023
Closed
@steveisok

steveisok commented Feb 24, 2023

Copy link
Copy Markdown
Member

@carlossanlop are you good with merging this?

@carlossanlop

carlossanlop commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

Waiting for Matt's answer here: #82323 (comment)

@carlossanlop
carlossanlop merged commit b4f44f7 into dotnet:release/6.0Mar 8, 2023
@ghostghost locked as resolved and limited conversation to collaborators Apr 7, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisoksteveisoksteveisok approved these changes

Assignees

No one assigned

Labels

area-Infrastructurecommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@am11@akoeplinger@steveisok@carlossanlop