Skip to content

[Mono] Add initial arm64 hardware intrinsics support for mini JIT - #82420

Merged
fanyang-mono merged 15 commits into
dotnet:mainfrom
fanyang-mono:arm64_hi
Mar 6, 2023
Merged

[Mono] Add initial arm64 hardware intrinsics support for mini JIT#82420
fanyang-mono merged 15 commits into
dotnet:mainfrom
fanyang-mono:arm64_hi

Conversation

@fanyang-mono

@fanyang-monofanyang-mono commented Feb 21, 2023•
edited
Loading

Copy link
Copy Markdown
Member

The following has been added to mini JIT on arm64:

  • Enabled SIMD support for Vector128.
  • Emitted hardware intrinsics for add.
  • Fixed alignment for SIMD types on arm64.
  • Emitted arm64 intrinsics for various basic operations. They are OP_STOREX_MEMBASE, OP_LOADX_MEMBASE, OP_XZERO, OP_XCONST and OP_XMOVE.

Contributes to #80566

fanyang-mono
fanyang-mono commented Feb 21, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/simd-intrinsics.c Outdated
Comment on lines +1200 to +1203
// #ifdef TARGET_ARM64
// if (!(cfg->compile_aot && cfg->full_aot && !cfg->interp))
// return NULL;
// #endif

@fanyang-monofanyang-monoFeb 21, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary commented these lines out for testing on CI. Need to uncomment before merging.

@vargaz

vargaz commented Feb 21, 2023

Copy link
Copy Markdown
Contributor

The ios-arm64 failures look relevant:
/tmp/helix/working/B18009D0/p/build/apple/AppleApp.targets(110,5): error : * Assertion at /Users/runner/work/1/s/src/mono/mono/mini/../../mono/arch/arm64/arm64-codegen.h:244, condition `arm_is_pimm12_scaled (pimm, size)' not met [/private/tmp/helix/working/B18009D0/w/9CB0086D/e/publish/ProxyProjectForAOTOnHelix.proj]

vargaz
vargaz reviewed Feb 21, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini-arm64.c Outdated
@build-analysisbuild-analysisBot mentioned this pull request Feb 21, 2023
Closed
tannergooding
tannergooding reviewed Feb 21, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini-arm64.c Outdated
jandupej
jandupej approved these changes Feb 21, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini-arm64.c Outdated
vargaz
vargaz reviewed Feb 22, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini.c Outdated
vargaz
vargaz reviewed Feb 22, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini.c
@build-analysisbuild-analysisBot mentioned this pull request Feb 22, 2023
Closed
jandupej
jandupej reviewed Feb 24, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini-arm64.c Outdated
vargaz
vargaz reviewed Mar 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini-arm64.h
@runfoapprunfoappBot mentioned this pull request Mar 1, 2023
Closed
This was referenced Mar 1, 2023
Open
Closed
@jandupej

jandupej commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

Could not reproduce the RegularExpressions failure on macos,arm64; anyway it seems unrelated. Other failures also seem unrelated.

@build-analysisbuild-analysisBot mentioned this pull request Mar 3, 2023
Closed
@runfoapprunfoappBot mentioned this pull request Mar 6, 2023
Closed
@fanyang-mono

fanyang-mono commented Mar 6, 2023

Copy link
Copy Markdown
MemberAuthor

Failures on runtime (Build browser-wasm linux Release WasmBuildTests) are not related to this PR.

@fanyang-mono

fanyang-mono commented Mar 6, 2023

Copy link
Copy Markdown
MemberAuthor

wasm failures on CI are not related to this PR.

@fanyang-mono
fanyang-mono merged commit d74dde7 into dotnet:mainMar 6, 2023
@kotlarmiloskotlarmilos mentioned this pull request Mar 8, 2023
Closed
@lewinglewing mentioned this pull request Mar 8, 2023
Closed
@fanyang-mono

fanyang-mono commented Mar 8, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Micro benchmarks improvement due of this PR:

@kotlarmiloskotlarmilos mentioned this pull request Mar 17, 2023
Closed
@kotlarmiloskotlarmilos mentioned this pull request Apr 4, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergoodingtannergoodingtannergooding left review comments
@lambdageeklambdageekAwaiting requested review from lambdageek
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
+2 more reviewers
@vargazvargazvargaz approved these changes
@jandupejjandupejjandupej approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fanyang-monofanyang-mono

Labels

area-Codegen-Intrinsics-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fanyang-mono@vargaz@jandupej@tannergooding