[mono] Raise soft RLIMIT_NOFILE on Linux by uweigand · Pull Request #82429 · dotnet/runtime

uweigand · 2023-02-21T12:42:51Z

Replace darwin_change_default_file_handles by a new routine increase_descriptor_limit, which mirrors the logic in the CoreCLR INIT_IncreaseDescriptorLimit routine.

Fixes#82428.

Replace darwin_change_default_file_handles by a new routine increase_descriptor_limit, which mirrors the logic in the CoreCLR INIT_IncreaseDescriptorLimit routine. Addresses #82428.

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>

uweigand · 2023-03-03T16:02:12Z

Thanks @akoeplinger ! Can this be backported to .NET 7 and possibly also .NET 6 ? We're seeing the same issue there as well.

akoeplinger · 2023-03-03T16:55:20Z

/backport to release/7.0

akoeplinger · 2023-03-03T16:55:25Z

/backport to release/6.0

github-actions · 2023-03-03T16:55:33Z

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/4325553985

github-actions · 2023-03-03T16:55:38Z

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/4325554484

github-actions · 2023-03-03T16:57:41Z

@akoeplinger backporting to release/7.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: [mono] Raise soft RLIMIT_NOFILE on Linux
Using index info to reconstruct a base tree...
M	src/mono/CMakeLists.txt
M	src/mono/mono/mini/driver.c
Falling back to patching base and 3-way merge...
Auto-merging src/mono/mono/mini/driver.c
Auto-merging src/mono/CMakeLists.txt
CONFLICT (content): Merge conflict in src/mono/CMakeLists.txt
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 [mono] Raise soft RLIMIT_NOFILE on Linux
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

github-actions · 2023-03-03T16:57:42Z

@akoeplinger an error occurred while backporting to release/7.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

github-actions · 2023-03-03T16:57:49Z

@akoeplinger backporting to release/6.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: [mono] Raise soft RLIMIT_NOFILE on Linux
Using index info to reconstruct a base tree...
M	src/mono/CMakeLists.txt
M	src/mono/mono/mini/driver.c
Falling back to patching base and 3-way merge...
Auto-merging src/mono/mono/mini/driver.c
CONFLICT (content): Merge conflict in src/mono/mono/mini/driver.c
Auto-merging src/mono/CMakeLists.txt
CONFLICT (content): Merge conflict in src/mono/CMakeLists.txt
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 [mono] Raise soft RLIMIT_NOFILE on Linux
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

github-actions · 2023-03-03T16:57:50Z

@akoeplinger an error occurred while backporting to release/6.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

akoeplinger · 2023-03-03T16:58:13Z

Looks like there are some merge conflicts, @uweigand would you mind preparing manual backports? thanks

Manual backport of dotnet#82429. Replace darwin_change_default_file_handles by a new routine increase_descriptor_limit, which mirrors the logic in the CoreCLR INIT_IncreaseDescriptorLimit routine. Fixesdotnet#82428.

uweigand · 2023-03-07T09:24:22Z

Looks like there are some merge conflicts, @uweigand would you mind preparing manual backports? thanks

Hi @akoeplinger, I've now created manual backports (linked above). Note that these omit the Alpine-related cmake changes, since in .NET 6 and .NET 7 there isn't any support for Alpine in the Mono makefiles yet. If this is ever backported, the -DDONT_SET_RLIMIT_NOFILE change would have to be added at that point as well (CC @ayakael).

akoeplinger · 2023-03-07T11:46:17Z

Ok, thanks!

ayakael · 2023-03-07T21:25:48Z

Noted! I would like to backport #76500, which would allow the alpine-related changes to be backported as well. Unfortunately, there is worry associated with backporting platform support. Would you like me to backport that PR + your changes?

uweigand · 2023-03-08T13:52:23Z

Noted! I would like to backport #76500, which would allow the alpine-related changes to be backported as well. Unfortunately, there is worry associated with backporting platform support. Would you like me to backport that PR + your changes?

The backport question is not really for me to decide. I wouldn't mind that, but I can also understand the concerns with backporting large features. In the end, that's for the maintainers to decide ...

uweigand requested review from SamMonoRT, lambdageek, marek-safar and vargaz as code owners February 21, 2023 12:42

ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 21, 2023

marek-safar added the area-VM-meta-mono label Feb 21, 2023

This was referenced Feb 21, 2023
Tracking issue for CI build timeouts #76454
Closed
Roslyn source generator crash on mono/linux/arm64 #81123
Closed

[mono] Raise soft RLIMIT_NOFILE on Linux
c23dd54
Replace darwin_change_default_file_handles by a new routine increase_descriptor_limit, which mirrors the logic in the CoreCLR INIT_IncreaseDescriptorLimit routine. Addresses #82428.

akoeplinger reviewed Feb 27, 2023
View reviewed changes

Comment threadsrc/mono/mono/mini/driver.c Outdated

akoeplinger mentioned this pull request Feb 27, 2023
Increase file descriptor limit in NativeAOT app process #82719
Closed

Update src/mono/mono/mini/driver.c
0c355fc
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>

This was referenced Feb 28, 2023
Test failure: System.Security.Cryptography.X509Certificates.Tests.CertificateCreation.CertificateRequestChainTests/CreateChain_Hybrid #25979
Closed
System.Security.Cryptography.X509Certificates.Tests.ChainTests.BuildInvalidSignatureTwice failure #65448
Closed

akoeplinger approved these changes Mar 1, 2023
View reviewed changes

akoeplinger merged commit 605d05b into dotnet:mainMar 1, 2023

uweigand deleted the mono-rlimit-nofile branch March 3, 2023 16:01

uweigand mentioned this pull request Mar 7, 2023
[runtime/7.0] [mono] Raise soft RLIMIT_NOFILE on Linux #83078
Closed

uweigand mentioned this pull request Mar 7, 2023
[runtime/6.0] [mono] Raise soft RLIMIT_NOFILE on Linux #83079
Closed

ghost locked as resolved and limited conversation to collaborators Apr 7, 2023

Uh oh!

Conversation

uweigand commented Feb 21, 2023• edited by akoeplinger Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

uweigand commented Mar 3, 2023

Uh oh!

akoeplinger commented Mar 3, 2023

Uh oh!

akoeplinger commented Mar 3, 2023

Uh oh!

github-actionsBot commented Mar 3, 2023

Uh oh!

github-actionsBot commented Mar 3, 2023

Uh oh!

github-actionsBot commented Mar 3, 2023

Uh oh!

github-actionsBot commented Mar 3, 2023

Uh oh!

github-actionsBot commented Mar 3, 2023

Uh oh!

github-actionsBot commented Mar 3, 2023

Uh oh!

akoeplinger commented Mar 3, 2023

Uh oh!

uweigand commented Mar 7, 2023

Uh oh!

akoeplinger commented Mar 7, 2023

Uh oh!

ayakael commented Mar 7, 2023

Uh oh!

uweigand commented Mar 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

uweigand commented Feb 21, 2023•
edited by akoeplinger
Loading