Uh oh!
There was an error while loading. Please reload this page.
[release/6.0] System.Console: allow terminfo files to be larger than 4KiB. - #82433
Merged
Conversation
# Conflicts: # src/libraries/System.Console/src/System/TermInfo.DatabaseFactory.cs
ghost
commented
Feb 21, 2023
Tagging subscribers to this area: @dotnet/area-system-console Issue DetailsBackport of #82038 to release/6.0 Customer ImpactUpcoming Fedora 38 provides a TermInfo file which is larger than artificial limit we have set in .NET Core 1.0. Usage of any Testing@tmds has provided the fix and tested the changes on Fedora 38. RiskI can't think of any, as TermInfo files are stored in a secure location. No OOB changes needed for System.Console.
|
tmds
approved these changes
Feb 22, 2023
carlossanlop
approved these changes
Mar 8, 2023
carlossanlop
left a comment
Contributor
There was a problem hiding this comment.
No OOB changes needed. CI failures look unrelated. Approved by Tactics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #82038 to release/6.0
Customer Impact
Upcoming Fedora 38 provides a TermInfo file which is larger than artificial limit we have set in .NET Core 1.0. Usage of any
ConsoleAPIs ends up with an exception. This PR removes the max file size check.Testing
@tmds has provided the fix and tested the changes on Fedora 38.
Risk
I can't think of any, as TermInfo files are stored in a secure location.
No OOB changes needed for System.Console.