Uh oh!
There was an error while loading. Please reload this page.
eng/SourceBuild.props: when unset, let the repo determine RuntimeOS. - #82546
Conversation
When source-build builds runtime, it will pass RuntimeOS and BaseOS. When the repo is built directly using './build.sh --sb', let the repo determine those values rather than calculating them in SourceBuild.props.
tmds
commented
Feb 23, 2023
For some extra context, Since .NET 7, source-build no longer does portable builds and some changes were made to With those changes, the rid for With this PR we defer to the runtime's behavior when |
tmds
commented
Mar 6, 2023
When source-build builds this, it sets both The changes here are for when @ViktorHofer can you merge this? |
ViktorHofer
commented
Mar 24, 2023
Thanks @tmds and sorry for the delay. |
When source-build builds runtime, it will pass RuntimeOS and BaseOS.
When the repo is built directly using './build.sh --sb', let the repo determine those values rather than calculating them in SourceBuild.props.
Fixes#82160 (comment).
@ViktorHofer@oleksandr-didyk ptal.