Skip to content

[mono][interp] Add intrinsics for BitOperations - #82827

Merged
BrzVlad merged 6 commits into
dotnet:mainfrom
BrzVlad:feature-interp-bitoperations-intrins
Mar 14, 2023
Merged

[mono][interp] Add intrinsics for BitOperations#82827
BrzVlad merged 6 commits into
dotnet:mainfrom
BrzVlad:feature-interp-bitoperations-intrins

Conversation

@BrzVlad

@BrzVladBrzVlad commented Mar 1, 2023

Copy link
Copy Markdown
Member

No description provided.

@ghostghost assigned BrzVladMar 1, 2023
@ghost

ghost commented Mar 1, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:BrzVlad
Assignees:BrzVlad
Labels:

area-Codegen-Interpreter-mono

Milestone:-

BrzVlad
BrzVlad commented Mar 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/interp/transform.c Outdated
kotlarmilos
kotlarmilos reviewed Mar 1, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/interp/transform.c Outdated
@runfoapprunfoappBot mentioned this pull request Mar 1, 2023
Closed
This was referenced Mar 1, 2023
Closed
Closed
Open
Closed
@BrzVlad
BrzVladforce-pushed the feature-interp-bitoperations-intrins branch from c66bc59 to 5dd2186CompareMarch 6, 2023 09:46
@build-analysisbuild-analysisBot mentioned this pull request Mar 6, 2023
Closed
@runfoapprunfoappBot mentioned this pull request Mar 6, 2023
Closed
tannergooding
tannergooding reviewed Mar 6, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/interp/interp-intrins.h Outdated
@BrzVlad
BrzVladforce-pushed the feature-interp-bitoperations-intrins branch from 5dd2186 to 63a1c65CompareMarch 6, 2023 16:35
@build-analysisbuild-analysisBot mentioned this pull request Mar 6, 2023
Open
5 tasks
@BrzVlad

BrzVlad commented Mar 13, 2023

Copy link
Copy Markdown
MemberAuthor

Could I get a review on this ?

tannergooding
tannergooding reviewed Mar 13, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/interp/interp-intrins.h Outdated
tannergooding
tannergooding reviewed Mar 13, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/interp/interp.c Outdated
tannergooding
tannergooding reviewed Mar 13, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/interp/transform.c Outdated
tannergooding
tannergooding reviewed Mar 13, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/interp/transform.c Outdated
tannergooding
tannergooding reviewed Mar 13, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/interp/transform.c Outdated
tannergooding
tannergooding reviewed Mar 13, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/interp/transform.c Outdated
tannergooding
tannergooding reviewed Mar 13, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/interp/transform.c Outdated
@BrzVlad
BrzVladforce-pushed the feature-interp-bitoperations-intrins branch from 33095db to 3f36c9bCompareMarch 14, 2023 09:21
This was referenced Mar 14, 2023
Closed
Closed
tannergooding
tannergooding approved these changes Mar 14, 2023
View reviewed changes

@tannergoodingtannergooding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@BrzVlad
BrzVlad merged commit 6ddb03f into dotnet:mainMar 14, 2023
@kotlarmiloskotlarmilos mentioned this pull request Mar 17, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing left review comments
@kotlarmiloskotlarmiloskotlarmilos left review comments
@tannergoodingtannergoodingtannergooding approved these changes
@vargazvargazAwaiting requested review from vargaz

Assignees

@BrzVladBrzVlad

Labels

area-Codegen-Interpreter-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BrzVlad@lewing@tannergooding@kotlarmilos