') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Test merging baseservices/threading by BrianBohe · Pull Request #83143 · dotnet/runtime · GitHub
Skip to content

Test merging baseservices/threading - #83143

Merged
BrianBohe merged 8 commits into
dotnet:mainfrom
BrianBohe:testmerging_threading
Mar 14, 2023
Merged

Test merging baseservices/threading#83143
BrianBohe merged 8 commits into
dotnet:mainfrom
BrianBohe:testmerging_threading

Conversation

@BrianBohe

@BrianBoheBrianBohe commented Mar 8, 2023

Copy link
Copy Markdown
Member

This another pr merging JIT tests as #81969. It starts with a commit removing args from test entrypoint, and then applies ILTransform with the arguments specified on each commit in the same directory (baseservices/threading). This is the version of the tool I used.
Last two commits are a patch on the test merging approach to avoid deduplicating test classes on il tests. These are taken from PR merging JIT/Directed.

@ghostghost assigned BrianBoheMar 8, 2023
@ghost

ghost commented Mar 8, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

This another pr merging JIT tests as #81969. It starts with a commit removing args from test entrypoint, and then applies ILTransform with the arguments specified on each commit in the same directory (baseservices/threading). This is the version of the tool I used.
Last two commits are a patch on the test merging approach to avoid deduplicating test classes on il tests. These are taken from PR merging JIT/Directed.

Author:BrianBohe
Assignees:BrianBohe
Labels:

area-System.Reflection.Metadata

Milestone:-

@BrianBohe

BrianBohe commented Mar 8, 2023

Copy link
Copy Markdown
MemberAuthor

Before:

Time [secs] | Total | Passed | Failed | Skipped | Assembly Execution Summary
============================================================================
126.661 | 180 | 180 | 0 | 0 | baseservices.threading.XUnitWrapper.dll
----------------------------------------------------------------------------
126.661 | 180 | 180 | 0 | 0 | (total)

Now:

Time [secs] | Total | Passed | Failed | Skipped | Assembly Execution Summary
============================================================================
222.114 | 85 | 85 | 0 | 0 | baseservices.threading.threading_group1
152.050 | 95 | 95 | 0 | 0 | baseservices.threading.threading_group2
----------------------------------------------------------------------------
374.164 | 180 | 180 | 0 | 0 | (total)

@BrianBohe

BrianBohe commented Mar 8, 2023

Copy link
Copy Markdown
MemberAuthor

There are only 3 baseservices/threading tests on issues.target but none of those has change

@BrianBohe
BrianBohe requested a review from markplesMarch 8, 2023 17:20
@BrianBoheBrianBohe added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 9, 2023
@ghost

ghost commented Mar 9, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

This another pr merging JIT tests as #81969. It starts with a commit removing args from test entrypoint, and then applies ILTransform with the arguments specified on each commit in the same directory (baseservices/threading). This is the version of the tool I used.
Last two commits are a patch on the test merging approach to avoid deduplicating test classes on il tests. These are taken from PR merging JIT/Directed.

Author:BrianBohe
Assignees:BrianBohe
Labels:

area-System.Reflection.Metadata, area-CodeGen-coreclr

Milestone:-

@BrianBohe

BrianBohe commented Mar 9, 2023

Copy link
Copy Markdown
MemberAuthor

Related issue #71732

@BrianBohe
BrianBoheforce-pushed the testmerging_threading branch from c015c18 to 8a253c0CompareMarch 9, 2023 05:40
@BrianBoheBrianBohe mentioned this pull request Mar 9, 2023
Open
33 tasks
@BrianBohe

BrianBohe commented Mar 9, 2023

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Mar 9, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@BrianBohe
BrianBohe requested a review from trylekMarch 9, 2023 21:57
trylek
trylek approved these changes Mar 9, 2023
View reviewed changes

@trylektrylek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks Brian!

@BrianBoheBrianBohe added the test-enhancement Improvements of test source code label Mar 10, 2023
@BrianBohe
BrianBohe merged commit a78f9bd into dotnet:mainMar 14, 2023
@JulieLeeMSFTJulieLeeMSFT mentioned this pull request Mar 29, 2023
Closed
17 tasks
@ghostghost locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@trylektrylektrylek approved these changes
@markplesmarkplesAwaiting requested review from markples

Assignees

@BrianBoheBrianBohe

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIarea-System.Reflection.Metadatatest-enhancementImprovements of test source code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BrianBohe@trylek@steveharter