Skip to content

[iOS] Add gss framework back into sample linker args - #83182

Merged
steveisok merged 2 commits into
dotnet:mainfrom
steveisok:fix-gss-link-spot
Mar 9, 2023
Merged

[iOS] Add gss framework back into sample linker args#83182
steveisok merged 2 commits into
dotnet:mainfrom
steveisok:fix-gss-link-spot

Conversation

@steveisok

Copy link
Copy Markdown
Member

#81919 introduced a regression where the gss framework was omitted from the sample build. This change adds it back in.

Fixesdotnet/performance#2924

dotnet#81919 introduced a regression where the gss framework was omitted from the sample build. This change adds it back in.
Fixesdotnet/performance#2924
@ghost

ghost commented Mar 9, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

#81919 introduced a regression where the gss framework was omitted from the sample build. This change adds it back in.

Fixes dotnet/performance#2924

Author:steveisok
Assignees:steveisok
Labels:

area-Infrastructure-mono

Milestone:-

Comment threadsrc/mono/msbuild/apple/build/AppleApp.targets

@ivanpovazanivanpovazan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@steveisok

Copy link
Copy Markdown
MemberAuthor

Wasm failure was reported as a known build error in #83214.

The rest are previously known build failures.

@steveisok
steveisok merged commit a92ed6e into dotnet:mainMar 9, 2023
@steveisok
steveisok deleted the fix-gss-link-spot branch March 9, 2023 16:28
@ghostghost locked as resolved and limited conversation to collaborators Apr 8, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[main][runtime] iOS app builds are failing

3 participants

@steveisok@akoeplinger@ivanpovazan