Uh oh!
There was an error while loading. Please reload this page.
JIT: Stop relying on type handles in CSE - #83306
Merged
Merged
Conversation
ghost
commented
Mar 11, 2023
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak |
jakobbotsch
commented
Mar 13, 2023
MemberAuthor
Will wait for #83307 to make it in since that will conflict. |
jakobbotsch
marked this pull request as ready for review
March 14, 2023 11:12
jakobbotsch
commented
Mar 14, 2023
MemberAuthor
cc @dotnet/jit-contrib PTAL @AndyAyersMS |
AndyAyersMS
approved these changes
Mar 14, 2023
| { | ||
| m_pCompiler->lvaTable[cseLclVarNum].setLvRefCnt(1); | ||
| m_pCompiler->lvaTable[cseLclVarNum].setLvRefCntWtd(curWeight); | ||
| lclDsc->setLvRefCnt(1); |
Member
There was a problem hiding this comment.
I realize this is pre-existing logic, but we no longer bother to keep ref counts incrementally up to date (see dotnet/coreclr#19345). I don't recall if we ended up needing to keep this particular update for some reason, or I just missed it when removing the other updates.
This is mostly just a note to myself for follow up. No need to explore the ref count changes as part of this PR.
This was referenced Mar 16, 2023
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#83215