Skip to content

[Mono] Add more binary op intrinsics for ARM64 mini JIT - #83337

Merged
fanyang-mono merged 5 commits into
dotnet:mainfrom
fanyang-mono:arm64_binop
Mar 15, 2023
Merged

[Mono] Add more binary op intrinsics for ARM64 mini JIT#83337
fanyang-mono merged 5 commits into
dotnet:mainfrom
fanyang-mono:arm64_binop

Conversation

@fanyang-mono

@fanyang-monofanyang-mono commented Mar 13, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This PR enabled emitting hardware intrinsics for the following API of Vector/Vector128 for ARM64 mini JIT:

  • Subtract
  • BitwiseAnd
  • BitwiseOr
  • Xor
  • Operator + (one operand)
  • Operator - (one operand)
  • Operator ~
  • Operator +
  • Operator -
  • Operator &
  • Operator |
  • Operator ^

Contribute to #80566

@fanyang-monofanyang-mono changed the title [Mono] Add more binary op intrinsics for Arm64 mini JIT[Mono] Add more binary op intrinsics for ARM64 mini JITMar 13, 2023
@build-analysisbuild-analysisBot mentioned this pull request Mar 13, 2023
Closed
@fanyang-mono

fanyang-mono commented Mar 13, 2023

Copy link
Copy Markdown
MemberAuthor

Test failure on runtime (Build Libraries Test Run release mono linux arm64 Debug) also happened on main.

jandupej
jandupej approved these changes Mar 14, 2023
View reviewed changes

@jandupejjandupej left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vargaz
vargaz reviewed Mar 14, 2023
View reviewed changes
Comment threadsrc/mono/mono/mini/mini-ops.h Outdated
@runfoapprunfoappBot mentioned this pull request Mar 14, 2023
Closed
This was referenced Mar 14, 2023
Closed
Closed
Closed
@fanyang-mono

fanyang-mono commented Mar 15, 2023

Copy link
Copy Markdown
MemberAuthor

CI failures on wasm are not related to this PR.

@fanyang-mono
fanyang-mono merged commit c0eb86a into dotnet:mainMar 15, 2023
@kotlarmiloskotlarmilos mentioned this pull request Mar 23, 2023
Closed
@kotlarmiloskotlarmilos mentioned this pull request Apr 4, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageekAwaiting requested review from lambdageek
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT
2 more reviewers
@vargazvargazvargaz left review comments
@jandupejjandupejjandupej approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@fanyang-monofanyang-mono

Labels

area-Codegen-Intrinsics-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fanyang-mono@vargaz@jandupej