Skip to content

Fix superpmi unit test on Alpine - #83372

Merged
jakobbotsch merged 1 commit into
dotnet:mainfrom
BruceForstall:FixSuperpmiCollectUnitTest
Mar 14, 2023
Merged

Fix superpmi unit test on Alpine#83372
jakobbotsch merged 1 commit into
dotnet:mainfrom
BruceForstall:FixSuperpmiCollectUnitTest

Conversation

@BruceForstall

@BruceForstallBruceForstall commented Mar 14, 2023

Copy link
Copy Markdown
Contributor

perl was removed from the Alpine images we use. The superpmi unit test harness was using perl to convert the line endings in the superpmicollect.sh wrapper script harness from Windows CR/LF format to Linux/Mac LF format.

It appears this is no longer necessary, as the wrapper scripts appear to be built in CI during the "Generate tests wrappers" step on Linux when they will be run on Linux, so they already have the correct line endings. Remove the call to invoke perl.

Fixes#83320

@BruceForstall
Fix superpmi unit test on Alpine
a57e877
`perl` was removed from the Alpine images we use. The superpmi unit
test harness was using `perl` to convert the line endings in the
superpmicollect.sh wrapper script harness from Windows CR/LF format
to Linux/Mac LF format.
It appears this is no longer necessary, as the wrapper scripts appear
to be built in CI during the "Generate tests wrappers" step on Linux
when they will be run on Linux, so they already have the correct line
endings. Remove the call to invoke `perl`.
Fixesdotnet#83320
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 14, 2023
@ghost

ghost commented Mar 14, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

perl was removed from the Alpine images we use. The superpmi unit test harness was using perl to convert the line endings in the superpmicollect.sh wrapper script harness from Windows CR/LF format to Linux/Mac LF format.

It appears this is no longer necessary, as the wrapper scripts appear to be built in CI during the "Generate tests wrappers" step on Linux when they will be run on Linux, so they already have the correct line endings. Remove the call to invoke perl.

Fixes #83320

Author:BruceForstall
Assignees:-
Labels:

area-CodeGen-coreclr

Milestone:-

@BruceForstall

BruceForstall commented Mar 14, 2023

Copy link
Copy Markdown
ContributorAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Mar 14, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@BruceForstall

BruceForstall commented Mar 14, 2023

Copy link
Copy Markdown
ContributorAuthor

@jakobbotsch If you see/review/approve this, and outerloop passes (or at least doesn't fail on the superpmi unit test), please merge.

@jakobbotsch

jakobbotsch commented Mar 14, 2023

Copy link
Copy Markdown
Member

Failure is #83298

@jakobbotsch
jakobbotsch merged commit 7c5c4de into dotnet:mainMar 14, 2023
This was referenced Mar 14, 2023
Closed
Closed
@BruceForstall
BruceForstall deleted the FixSuperpmiCollectUnitTest branch March 27, 2023 06:43
@ghostghost locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakobbotschjakobbotschjakobbotsch approved these changes

Assignees

@BruceForstallBruceForstall

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test failure JIT/superpmi/superpmicollect/superpmicollect.sh

2 participants

@BruceForstall@jakobbotsch