Skip to content

Add lowering for get_One, get_AllBitSet, createScalar(), createScalarUnsafe(). - #83402

Merged
tannergooding merged 3 commits into
dotnet:mainfrom
DeepakRajendrakumaran:vector512API_2
Mar 15, 2023
Merged

Add lowering for get_One, get_AllBitSet, createScalar(), createScalarUnsafe().#83402
tannergooding merged 3 commits into
dotnet:mainfrom
DeepakRajendrakumaran:vector512API_2

Conversation

@DeepakRajendrakumaran

@DeepakRajendrakumaranDeepakRajendrakumaran commented Mar 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This makes progress towards #80814. Also helps with #83354

@ghostghost added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member labels Mar 14, 2023
@ghost

ghost commented Mar 14, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

This makes progress towards #80814 and #73604. Also helps with #83354

Author:DeepakRajendrakumaran
Assignees:-
Labels:

area-CodeGen-coreclr, community-contribution

Milestone:-

@DeepakRajendrakumaran

DeepakRajendrakumaran commented Mar 14, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@tannergooding@BruceForstall@anthonycanino

Had to add a new instruction VPTERNLOG since cmp instruction previously used to set all bits would write result to k register. And that is not ideal. Everything else should be straightforward

@DeepakRajendrakumaran
DeepakRajendrakumaran marked this pull request as draft March 14, 2023 17:29
DeepakRajendrakumaran
DeepakRajendrakumaran commented Mar 14, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/codegenxarch.cpp Outdated
tannergooding
tannergooding reviewed Mar 14, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/codegenxarch.cpp Outdated
tannergooding
tannergooding reviewed Mar 14, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/codegenxarch.cpp Outdated
@build-analysisbuild-analysisBot mentioned this pull request Mar 14, 2023
Closed
@DeepakRajendrakumaran
DeepakRajendrakumaranforce-pushed the vector512API_2 branch 2 times, most recently from 42dbaaa to 6096524CompareMarch 14, 2023 22:12
@DeepakRajendrakumaranDeepakRajendrakumaran changed the title Add lowering for get_One, and get_AllBitSet.Add lowering for get_One, get_AllBitSet, createScalar(), createScalarUnsafe().Mar 14, 2023
@DeepakRajendrakumaran
DeepakRajendrakumaran marked this pull request as ready for review March 14, 2023 22:38
tannergooding
tannergooding reviewed Mar 14, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/instrsxarch.h Outdated
DeepakRajendrakumaran
DeepakRajendrakumaran commented Mar 14, 2023
View reviewed changes
Comment threadsrc/coreclr/jit/codegenxarch.cpp
@build-analysisbuild-analysisBot mentioned this pull request Mar 15, 2023
Closed
@tannergooding

tannergooding commented Mar 15, 2023

Copy link
Copy Markdown
Member

CC. @dotnet/jit-contrib, @dotnet/avx512-contrib for secondary review/sign-off

Failures are #83298 which has a revert PR up #83412

Tests covering the relevant changes did run and pass, despite the timeouts (can see that in the console log by searching for Vector512_1.Program.AllBitsSet and related entries).

@tannergoodingtannergooding mentioned this pull request Mar 15, 2023
Merged
@tannergooding
tannergooding merged commit 41cb2d3 into dotnet:mainMar 15, 2023
@BruceForstallBruceForstall added the avx512 Related to the AVX-512 architecture label Mar 27, 2023
@JulieLeeMSFTJulieLeeMSFT mentioned this pull request Apr 4, 2023
Closed
3 tasks
@ghostghost locked as resolved and limited conversation to collaborators Apr 26, 2023
@DeepakRajendrakumaran
DeepakRajendrakumaran deleted the vector512API_2 branch August 3, 2026 23:43
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBoEgorBoEgorBo approved these changes
@tannergoodingtannergoodingtannergooding approved these changes

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIavx512Related to the AVX-512 architecturecommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DeepakRajendrakumaran@tannergooding@EgorBo@BruceForstall