[browser] cleanup of early startup code by pavelsavara · Pull Request #83411 · dotnet/runtime

pavelsavara · 2023-03-14T18:55:25Z

Split off from #83364
Contributes to #72990
Contributes to #85045

drop dotnet.es6.post.js
simplify dotnet.es6.lib.js and dotnet.es6.extpost.js and dotnet.es6.pre.js
create types-api.ts by moving types from other files
drop export_linker() from startup
drop IMPORTS object
drop isGlobal flag (CJS cleanup)
reorganized init_polyfills_async and init_replacements
refactored unifyModuleConfig from dotnet.es6.pre.js to run-outer.ts
removed INTERNAL from top most export

ghost · 2023-03-14T18:55:37Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Split off from #83364

drop dotnet.es6.post.js and dotnet.es6.pre.js
simplify dotnet.es6.lib.js and dotnet.es6.extpost.js
create types-api.ts by moving types from other files
drop export_linker() from startup
drop IMPORTS object
drop isGlobal flag (CJS cleanup)
reorganized init_polyfills_async and init_replacements
moved createDotnetRuntime from dotnet.es6.pre.js to run-outer.ts
removed INTERNAL from top most export

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	`arch-wasm`, `area-System.Runtime.InteropServices.JavaScript`
Milestone:	8.0.0

pavelsavara · 2023-03-16T17:24:37Z

/azp run runtime-wasm

azure-pipelines · 2023-03-16T17:24:48Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-03-17T23:41:03Z

@radical I would appreciate your help with Wasm.Build.Tests on this branch. There are CI failures, but locally it works for me.

pavelsavara · 2023-03-17T23:42:02Z

/azp run runtime-wasm

azure-pipelines · 2023-03-17T23:42:15Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-04-25T16:37:17Z

/azp run runtime-wasm

azure-pipelines · 2023-04-25T16:37:33Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-04-27T12:18:23Z

/azp run runtime-wasm

azure-pipelines · 2023-04-27T12:18:33Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2023-04-27T17:53:10Z

All the CI failures are unrelated.

maraf

It looks great! I have just some minor questions

- renamed imports.ts to globals.ts - formatted jiterp code

pavelsavara · 2023-04-28T12:41:57Z

/azp run runtime-wasm

azure-pipelines · 2023-04-28T12:42:06Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf

Looks good to me 👍

pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript labels Mar 14, 2023

pavelsavara added this to the 8.0.0 milestone Mar 14, 2023

pavelsavara requested a review from maraf March 14, 2023 18:55

pavelsavara self-assigned this Mar 14, 2023

pavelsavara force-pushed the browser_modules_prep1 branch from 5c249d2 to 2e48725Compare March 16, 2023 00:21

build-analysisBot mentioned this pull request Mar 16, 2023
[wasm][debugger] DebuggerTests.AssignmentTests.InspectVariableBeforeAndAfterAssignment failing #64188
Closed

pavelsavara closed this Apr 14, 2023

pavelsavara force-pushed the browser_modules_prep1 branch from 44d307b to 722e19bCompare April 14, 2023 09:17

pavelsavara reopened this Apr 14, 2023

build-analysisBot mentioned this pull request Apr 14, 2023
WasmTestOnBrowser-System.Text.Json.Tests.WorkItemExecution timing out #84434
Closed

pavelsavara force-pushed the browser_modules_prep1 branch from ca3546e to d997a31Compare April 18, 2023 17:51

pavelsavara force-pushed the browser_modules_prep1 branch from 937473f to 5ca2e17Compare April 25, 2023 11:49

pavelsavara force-pushed the browser_modules_prep1 branch from 964b98f to 54e9f48Compare April 26, 2023 12:42

build-analysisBot mentioned this pull request Apr 26, 2023
[mono][wasm] Unable to find RazorClassLibrary.dll to be lazy loaded later. #85395
Closed

wip
55edc8b

pavelsavara force-pushed the browser_modules_prep1 branch from 54e9f48 to 55edc8bCompare April 26, 2023 15:32

pavelsavara added 2 commits April 27, 2023 13:43

fix early environment
57d9b11

Merge branch 'main' into browser_modules_prep1
5c77476

pavelsavara marked this pull request as ready for review April 27, 2023 12:18

pavelsavara requested review from kg, lewing, radical and thaystg as code owners April 27, 2023 12:18

module earlyExports
192ed54

build-analysisBot mentioned this pull request Apr 27, 2023
[Wasm.Build.Tests] Could not restore Microsoft.NET.Workload.Emscripten.Current.Manifest #85456
Closed

maraf reviewed Apr 28, 2023
View reviewed changes

pavelsavara added 2 commits April 28, 2023 13:20

Merge branch 'main' into browser_modules_prep1
20ffeb1

- maraf's feedback
8dad84d
- renamed imports.ts to globals.ts - formatted jiterp code

maraf approved these changes Apr 28, 2023
View reviewed changes

pavelsavara merged commit e6924ee into dotnet:mainApr 28, 2023

ghost locked as resolved and limited conversation to collaborators May 28, 2023

pavelsavara deleted the browser_modules_prep1 branch September 2, 2024 15:30

Uh oh!

Conversation

pavelsavara commented Mar 14, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Mar 14, 2023

Uh oh!

pavelsavara commented Mar 16, 2023

Uh oh!

azure-pipelinesBot commented Mar 16, 2023

Uh oh!

pavelsavara commented Mar 17, 2023

Uh oh!

pavelsavara commented Mar 17, 2023

Uh oh!

azure-pipelinesBot commented Mar 17, 2023

Uh oh!

pavelsavara commented Apr 25, 2023

Uh oh!

azure-pipelinesBot commented Apr 25, 2023

Uh oh!

pavelsavara commented Apr 27, 2023

Uh oh!

azure-pipelinesBot commented Apr 27, 2023

Uh oh!

pavelsavara commented Apr 27, 2023

Uh oh!

maraf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pavelsavara commented Apr 28, 2023

Uh oh!

azure-pipelinesBot commented Apr 28, 2023

Uh oh!

maraf left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pavelsavara commented Mar 14, 2023•
edited
Loading