Uh oh!
There was an error while loading. Please reload this page.
Revert "[wasm] Add a monitoring phase to jiterpreter traces and discard unproductive ones (#83432)" - #83446
Merged
Merged
Conversation
…rd unproductive ones (dotnet#83432)" This reverts commit 1cfda5e.
kg
requested review from
BrzVlad, kotlarmilos, lambdageek, lewing, pavelsavara and vargaz
as code ownersMarch 15, 2023 09:23
ghost
commented
Mar 15, 2023
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsThe first browser-bench run after the monitoring phase was added shows a regression in
|
vargaz
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first browser-bench run after the monitoring phase was added shows a regression in
Span<byte>.Reverse, and I don't think it's feasible to fix with the distance measuring approach so it's best to back out this commit and try the monitoring phase with a different approach after P3. I suspect the problem is that some traces containing loops will execute for a while and then return a small displacement, but it's not easy to fix that.