Uh oh!
There was an error while loading. Please reload this page.
Re-order some blocks in runtimelookup - #83453
Closed
EgorBo wants to merge 8 commits into
Closed
Conversation
ghost
commented
Mar 15, 2023
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsMotivation: #83430 (comment)
|
EgorBo
commented
Mar 15, 2023
MemberAuthor
Comment on lines
-415
to
-458
| if (result == PhaseStatus::MODIFIED_EVERYTHING) | ||
| { | ||
| if (opts.OptimizationEnabled()) | ||
| { | ||
| fgReorderBlocks(/* useProfileData */ false); | ||
| fgUpdateChangedFlowGraph(FlowGraphUpdates::COMPUTE_BASICS); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
W.r.t. the confusing diffs, maybe try with this change reverted?
| nullcheckBb->bbJumpDest = fallbackBb; | ||
| fastPathBb->bbJumpDest = block; | ||
| nullcheckBb->bbJumpDest = fastPathBb; | ||
| fallbackBb->bbJumpDest = block; |
Contributor
There was a problem hiding this comment.
What if you mark fallBackBb->bbSetRunRarely()? I had to do similar thing to re-arrange in #80297.
Contributor
There was a problem hiding this comment.
G_M10050_IG01:subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M10050_IG02:movrcx, qword ptr GS:[0x0058]movrcx, qword ptr [rcx+30H]movedx, dword ptr [rcx+48H]cmpedx,2jl SHORT G_M10050_IG04 ;; size=21 bbWeight=1 PerfScore 6.25G_M10050_IG03:movrcx, qword ptr [rcx+50H]cmp qword ptr [rcx+10H],0jne SHORT G_M10050_IG05 ;; size=11 bbWeight=0.90 PerfScore 5.42G_M10050_IG04:movrcx,0xD1FFAB1Emovedx,29movr8d,2call CORINFO_HELP_GETSHARED_NONGCTHREADSTATIC_BASE_NOCTOR_OPTIMIZEDmov qword ptr [rsp+20H],rax ;; size=31 bbWeight=0.09 PerfScore 0.25G_M10050_IG05:movrax, qword ptr [rsp+20H]moveax, dword ptr [rax+8CH] ;; size=11 bbWeight=1 PerfScore 3.00G_M10050_IG06:addrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25vs.
G_M10050_IG01:subrsp,40 ;; size=4 bbWeight=1 PerfScore 0.25G_M10050_IG02:movrax, qword ptr GS:[0x0058]movrax, qword ptr [rax+30H]movecx, dword ptr [rax+48H]cmpecx,2jl SHORT G_M10050_IG06 ;; size=21 bbWeight=1 PerfScore 6.25G_M10050_IG03:movrax, qword ptr [rax+50H]cmp qword ptr [rax+10H],0je SHORT G_M10050_IG06 ;; size=11 bbWeight=0.90 PerfScore 5.42G_M10050_IG04:movr9, qword ptr [rsp+20H]moveax, dword ptr [r9+8CH] ;; size=12 bbWeight=1 PerfScore 3.00G_M10050_IG05:addrsp,40ret ;; size=5 bbWeight=1 PerfScore 1.25G_M10050_IG06:movrcx,0xD1FFAB1Emovedx,29movr8d,2call CORINFO_HELP_GETSHARED_NONGCTHREADSTATIC_BASE_NOCTOR_OPTIMIZEDmovr9,raxmov qword ptr [rsp+20H],r9jmp SHORT G_M10050_IG04 ;; size=36 bbWeight=0 PerfScore 0.00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: #83430 (comment) let's see the diffs. #83430 changes JIT-EE guid so can't see diffs there