Skip to content

[release/6.0] Fix System.Management wminet_utils.dll lookup code for arm64 - #83546

Merged
carlossanlop merged 5 commits into
release/6.0from
backport/pr-83522-to-release/6.0
Mar 17, 2023
Merged

[release/6.0] Fix System.Management wminet_utils.dll lookup code for arm64#83546
carlossanlop merged 5 commits into
release/6.0from
backport/pr-83522-to-release/6.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Mar 16, 2023•
edited by ViktorHofer
Loading

Copy link
Copy Markdown
Contributor

Backport of #83522 to release/6.0

/cc @ViktorHofer

Customer Impact

Applications using the System.Management nuget package under .NETCoreApp on Windows arm64 and relying on WMI APIs like ManagementScope crash with a TypeInitializationException as the wrong wminet_utils.dll native assembly is being loaded. This results in customers not being able to use the WMI API on Windows arm64.

Testing

Manually tested offline on a Windows arm64 machine. Ran the tests and validated that they completed successfully.

Risk

Low - single line fix and enabling tests that were previously disabled.

@ghost

ghost commented Mar 16, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-system-management
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #83522 to release/6.0

/cc @ViktorHofer

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-System.Management

Milestone:-

@carlossanlopcarlossanlop modified the milestones: 6.0.16, 6.0.xMar 16, 2023
carlossanlop
carlossanlop approved these changes Mar 16, 2023
View reviewed changes

@carlossanlopcarlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packaging changes look good. Glad to see the comment in the System.Management csproj reminded us to also bump M.W.Compatibility.

@carlossanlopcarlossanlop modified the milestones: 6.0.x, 6.0.16Mar 16, 2023
@carlossanlopcarlossanlop added the Servicing-approved Approved for servicing release label Mar 16, 2023
@carlossanlopcarlossanlop modified the milestones: 6.0.16, 6.0.15Mar 16, 2023
@carlossanlop

carlossanlop commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

Approved by Tactics today to go into the April Servicing Release: 6.0.16.

@carlossanlop

carlossanlop commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

CI failures unrelated.
Merging now. cc @mmitche

@carlossanlop
carlossanlop merged commit 32c3904 into release/6.0Mar 17, 2023
@carlossanlop
carlossanlop deleted the backport/pr-83522-to-release/6.0 branch March 17, 2023 00:56
@carlossanlopcarlossanlop mentioned this pull request Apr 5, 2023
Merged
@ghostghost locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericstjericstjericstj approved these changes
+1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.ManagementServicing-approvedApproved for servicing release

Projects

None yet

Milestone

6.0.16

Development

Successfully merging this pull request may close these issues.

3 participants

@carlossanlop@ericstj@ViktorHofer