Skip to content

[release/7.0] Fix encoding problem when publishing - #83577

Merged
ilonatommy merged 5 commits into
dotnet:release/7.0-stagingfrom
ilonatommy:backport-82833
Apr 5, 2023
Merged

[release/7.0] Fix encoding problem when publishing#83577
ilonatommy merged 5 commits into
dotnet:release/7.0-stagingfrom
ilonatommy:backport-82833

Conversation

@ilonatommy

@ilonatommyilonatommy commented Mar 17, 2023•
edited by thaystg
Loading

Copy link
Copy Markdown
Member

Backport of #82833 to release/7.0

Fixes#78953.

Customer Impact

Customers had a problem with publishing applications that were located in a path with Unicode chars. It was because Windows’s scripts do not support UTF-8 by default. Now we added that feature + tests.

Testing

The PR introduced changes in WasmBuildTests and they are passing.

Risk

Low, it broadens the accepted range of codes for Windows to UTF-8.

@ilonatommyilonatommy added arch-wasm WebAssembly architecture area-Build-mono labels Mar 17, 2023
@ilonatommyilonatommy self-assigned this Mar 17, 2023
@ghost

ghost commented Mar 17, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Manual backport of #82833 to release/7.0.

Author:ilonatommy
Assignees:ilonatommy
Labels:

arch-wasm, area-Build-mono

Milestone:-

This was referenced Mar 17, 2023
Closed
Closed
Closed
@thaystg

thaystg commented Mar 17, 2023

Copy link
Copy Markdown
Member

The failures on CI are not connected.

pavelsavara
pavelsavara reviewed Mar 17, 2023
View reviewed changes
Comment threadsrc/tests/BuildWasmApps/Wasm.Build.Tests/BuildTestBase.cs Outdated
@ilonatommyilonatommy mentioned this pull request Mar 17, 2023
Merged
@marek-safarmarek-safar added the Servicing-approved Approved for servicing release label Mar 20, 2023
@marek-safarmarek-safar added this to the 7.0.x milestone Mar 20, 2023
@build-analysisbuild-analysisBot mentioned this pull request Mar 21, 2023
Closed
dotnet-maestroBotand others added 2 commits March 23, 2023 17:34
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/emsdkbuild 202303…
6a533c1
…23.1 (dotnet#83860)
Microsoft.NET.Workload.Emscripten.net6.Manifest-7.0.100 , Microsoft.NET.Workload.Emscripten.net7.Manifest-7.0.100
From Version 7.0.4 -> To Version 7.0.5
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@ilonatommy
Merge branch 'release/7.0' into backport-82833
ecdf52e
@carlossanlop

carlossanlop commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

I'm retargeting this PR to the new release/7.0-staging branch, which is the one that we will use from now on for servicing fixes.

Repo maintainers will now be allowed to merge their own servicing PR as long as it meets the requirements:

  • It is approved by Tactics (signaled by adding the Servicing-approved label).
  • It's signed-off by an area owner.
  • The CI is green, or the failures are investigated as unrelated.
  • And if the PR touches an OOB package, the necessary OOB authoring changes are added.

The new process is described here: runtime/docs/project/library-servicing.md.

The infra team will be actively monitoring servicing PRs to ensure all requirements are met and to help with any issues.

Let me know if you have any questions.

@carlossanlop
carlossanlop changed the base branch from release/7.0 to release/7.0-stagingMarch 28, 2023 21:00
This was referenced Mar 29, 2023
Closed
Closed
@carlossanlopcarlossanlop added Servicing-approved Approved for servicing release and removed Servicing-approved Approved for servicing release labels Mar 30, 2023
@carlossanlop

carlossanlop commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

Reminder: April 10th is the last day to merge backport PRs to ensure they get included in the May Release. PR owners are now in charge of merging their own PRs.

@ilonatommy

ilonatommy commented Apr 5, 2023

Copy link
Copy Markdown
MemberAuthor

Timezones failures on ios are not connected. Merging.

@ilonatommy
ilonatommy merged commit eacc9be into dotnet:release/7.0-stagingApr 5, 2023
@ghostghost locked as resolved and limited conversation to collaborators May 5, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pavelsavarapavelsavarapavelsavara left review comments
@marafmarafmaraf approved these changes
@radicalradicalAwaiting requested review from radical
@akoeplingerakoeplingerAwaiting requested review from akoeplinger

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoServicing-approvedApproved for servicing release

Projects

None yet

Milestone

7.0.x

Development

Successfully merging this pull request may close these issues.

6 participants

@ilonatommy@thaystg@carlossanlop@pavelsavara@maraf@marek-safar