Skip to content

[mono][jit] Add some barriers to the delegate invoke code. - #83673

Merged
vargaz merged 1 commit into
dotnet:mainfrom
vargaz:arm64-tramp-wbarrier
Mar 21, 2023
Merged

[mono][jit] Add some barriers to the delegate invoke code.#83673
vargaz merged 1 commit into
dotnet:mainfrom
vargaz:arm64-tramp-wbarrier

Conversation

@vargaz

@vargazvargaz commented Mar 20, 2023

Copy link
Copy Markdown
Contributor

Re: #81123.

@ghostghost assigned vargazMar 20, 2023
@lambdageek

lambdageek commented Mar 20, 2023

Copy link
Copy Markdown
Member

runtime (Build Libraries Test Run release mono linux arm64 Debug) passed.

Going to trigger the pipeline a couple more times to be sure

@lambdageek

lambdageek commented Mar 20, 2023

Copy link
Copy Markdown
Member

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented Mar 20, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek

This comment was marked as outdated.

Sign in to view
@vargaz
vargazforce-pushed the arm64-tramp-wbarrier branch from a1304f9 to cf30f80CompareMarch 20, 2023 18:26
@lambdageek

lambdageek commented Mar 20, 2023

Copy link
Copy Markdown
Member

arm64 passed Build Libraries Test Run release mono linux arm64 Debug. running again

@lambdageek

lambdageek commented Mar 20, 2023

Copy link
Copy Markdown
Member

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented Mar 20, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@vargazvargaz changed the title [mono][jit] Add a read barrier to the arm64 delegate invoke trampoline.[mono][jit] Add some barriers to the delegate invoke code.Mar 20, 2023
@lambdageek

lambdageek commented Mar 20, 2023

Copy link
Copy Markdown
Member

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented Mar 20, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lambdageek

lambdageek commented Mar 20, 2023

Copy link
Copy Markdown
Member

With read and write barriers, linux-arm64 passed twice. I guess if it passes one more time we should merge it and see if the overall reports in #81123 go down. Thanks for tracking it down @vargaz

This was referenced Mar 21, 2023
Closed
Closed
Closed
@lambdageek

lambdageek commented Mar 21, 2023

Copy link
Copy Markdown
Member

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented Mar 21, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Mar 21, 2023
Closed
@vargaz
vargaz marked this pull request as ready for review March 21, 2023 18:03
@vargaz
vargaz merged commit 7b82cdf into dotnet:mainMar 21, 2023
@vargaz
vargaz deleted the arm64-tramp-wbarrier branch March 21, 2023 19:06
@lambdageeklambdageek mentioned this pull request Mar 21, 2023
Closed
@build-analysisbuild-analysisBot mentioned this pull request Mar 21, 2023
Closed
@kotlarmiloskotlarmilos mentioned this pull request Mar 28, 2023
Closed
@radekdoulikradekdoulik mentioned this pull request Mar 29, 2023
Open
@ghostghost locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lambdageeklambdageeklambdageek approved these changes
@SamMonoRTSamMonoRTAwaiting requested review from SamMonoRT

Assignees

@vargazvargaz

Labels

area-Codegen-JIT-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vargaz@lambdageek