Specify -z notext on linux-musl-x86 and riscv64 by am11 · Pull Request #83682 · dotnet/runtime

am11 · 2023-03-20T17:42:19Z

'text': Report an error if DT_TEXTREL is set, i.e., if the position-independent or shared object has dynamic relocations in read-only sections. Don’t report an error if ‘notext’ or ‘textoff’.

Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.

Ref: #83509 (comment)
cc @ayakael

ghost · 2023-03-20T17:42:31Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

-z text does not allow text relocations. -z notext allows text relocations.

Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.

Ref: #83509 (comment)

Author:	am11
Assignees:	-
Labels:	`area-Infrastructure-coreclr`, `community-contribution`
Milestone:	-

am11 · 2023-03-20T17:48:05Z

@ayakael, now we have a docker image:

$ docker run -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x86 --rm \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-x86-alpine \
/runtime/build.sh clr+host+libs -a x86 -cross

Requires three patches: #83464, #83672 and #83682.

ayakael · 2023-03-20T17:51:39Z

@ayakael, now we have a docker image:
$ docker run -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x86 --rm \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-x86-alpine \
/runtime/build.sh clr+host+libs -a x86 -cross
Requires three patches: #83464, #83672 and #83682.

Very nice! Many thanks for upstreaming these.

ayakael · 2023-03-20T21:15:59Z

We may have to extend the condition to include CLR_CMAKE_TARGET_ARCH_RISCV64

I'm testing #82294, and encountering similar error that -z notext should fix: https://lab.ilot.io/ayakael/dotnet-stage0/-/jobs/1488

I've tried extending the condition, but the error still persists when linking libcoreclr.so. artifacts/obj/coreclr/linux.riscv64.Release/dlls/mscoree/coreclr/CMakeFiles/coreclr.dir/link.txt includes the relevant linker arg.

sbomer

Merge conflict with #84148 needs to be resolved by adding same flag under CLR_CMAKE_TARGET_ALPINE_LINUX. Also note that I saw the warnings with lld 12. Otherwise LGTM. Thanks!

jkotas

Thanks

clamp03 · 2023-04-25T01:57:37Z

noti to #84834

am11 · 2023-03-20T17:42:19Z

'text': Report an error if DT_TEXTREL is set, i.e., if the position-independent or shared object has dynamic relocations in read-only sections. Don’t report an error if ‘notext’ or ‘textoff’.

Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.

Ref: #83509 (comment)
cc @ayakael

ghost · 2023-03-20T17:42:31Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

-z text does not allow text relocations. -z notext allows text relocations.

Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.

Ref: #83509 (comment)

Author:	am11
Assignees:	-
Labels:	`area-Infrastructure-coreclr`, `community-contribution`
Milestone:	-

am11 · 2023-03-20T17:48:05Z

@ayakael, now we have a docker image:

$ docker run -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x86 --rm \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-x86-alpine \
/runtime/build.sh clr+host+libs -a x86 -cross

Requires three patches: #83464, #83672 and #83682.

ayakael · 2023-03-20T17:51:39Z

@ayakael, now we have a docker image:
$ docker run -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x86 --rm \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-x86-alpine \
/runtime/build.sh clr+host+libs -a x86 -cross
Requires three patches: #83464, #83672 and #83682.

Very nice! Many thanks for upstreaming these.

ayakael · 2023-03-20T21:15:59Z

We may have to extend the condition to include CLR_CMAKE_TARGET_ARCH_RISCV64

I'm testing #82294, and encountering similar error that -z notext should fix: https://lab.ilot.io/ayakael/dotnet-stage0/-/jobs/1488

I've tried extending the condition, but the error still persists when linking libcoreclr.so. artifacts/obj/coreclr/linux.riscv64.Release/dlls/mscoree/coreclr/CMakeFiles/coreclr.dir/link.txt includes the relevant linker arg.

sbomer

Merge conflict with #84148 needs to be resolved by adding same flag under CLR_CMAKE_TARGET_ALPINE_LINUX. Also note that I saw the warnings with lld 12. Otherwise LGTM. Thanks!

jkotas

Thanks

clamp03 · 2023-04-25T01:57:37Z

noti to #84834

am11 · 2023-03-20T17:42:19Z

'text': Report an error if DT_TEXTREL is set, i.e., if the position-independent or shared object has dynamic relocations in read-only sections. Don’t report an error if ‘notext’ or ‘textoff’.

Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.

Ref: #83509 (comment)
cc @ayakael

ghost · 2023-03-20T17:42:31Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

-z text does not allow text relocations. -z notext allows text relocations.

Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.

Ref: #83509 (comment)

Author:	am11
Assignees:	-
Labels:	`area-Infrastructure-coreclr`, `community-contribution`
Milestone:	-

am11 · 2023-03-20T17:48:05Z

@ayakael, now we have a docker image:

$ docker run -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x86 --rm \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-x86-alpine \
/runtime/build.sh clr+host+libs -a x86 -cross

Requires three patches: #83464, #83672 and #83682.

ayakael · 2023-03-20T17:51:39Z

@ayakael, now we have a docker image:
$ docker run -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x86 --rm \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-x86-alpine \
/runtime/build.sh clr+host+libs -a x86 -cross
Requires three patches: #83464, #83672 and #83682.

Very nice! Many thanks for upstreaming these.

ayakael · 2023-03-20T21:15:59Z

We may have to extend the condition to include CLR_CMAKE_TARGET_ARCH_RISCV64

I'm testing #82294, and encountering similar error that -z notext should fix: https://lab.ilot.io/ayakael/dotnet-stage0/-/jobs/1488

I've tried extending the condition, but the error still persists when linking libcoreclr.so. artifacts/obj/coreclr/linux.riscv64.Release/dlls/mscoree/coreclr/CMakeFiles/coreclr.dir/link.txt includes the relevant linker arg.

sbomer

Merge conflict with #84148 needs to be resolved by adding same flag under CLR_CMAKE_TARGET_ALPINE_LINUX. Also note that I saw the warnings with lld 12. Otherwise LGTM. Thanks!

jkotas

Thanks

clamp03 · 2023-04-25T01:57:37Z

noti to #84834

am11 · 2023-03-20T17:42:19Z

'text': Report an error if DT_TEXTREL is set, i.e., if the position-independent or shared object has dynamic relocations in read-only sections. Don’t report an error if ‘notext’ or ‘textoff’.

Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.

Ref: #83509 (comment)
cc @ayakael

ghost · 2023-03-20T17:42:31Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

-z text does not allow text relocations. -z notext allows text relocations.

Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.

Ref: #83509 (comment)

Author:	am11
Assignees:	-
Labels:	`area-Infrastructure-coreclr`, `community-contribution`
Milestone:	-

am11 · 2023-03-20T17:48:05Z

@ayakael, now we have a docker image:

$ docker run -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x86 --rm \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-x86-alpine \
/runtime/build.sh clr+host+libs -a x86 -cross

Requires three patches: #83464, #83672 and #83682.

ayakael · 2023-03-20T17:51:39Z

@ayakael, now we have a docker image:
$ docker run -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x86 --rm \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-x86-alpine \
/runtime/build.sh clr+host+libs -a x86 -cross
Requires three patches: #83464, #83672 and #83682.

Very nice! Many thanks for upstreaming these.

ayakael · 2023-03-20T21:15:59Z

We may have to extend the condition to include CLR_CMAKE_TARGET_ARCH_RISCV64

I'm testing #82294, and encountering similar error that -z notext should fix: https://lab.ilot.io/ayakael/dotnet-stage0/-/jobs/1488

I've tried extending the condition, but the error still persists when linking libcoreclr.so. artifacts/obj/coreclr/linux.riscv64.Release/dlls/mscoree/coreclr/CMakeFiles/coreclr.dir/link.txt includes the relevant linker arg.

sbomer

Merge conflict with #84148 needs to be resolved by adding same flag under CLR_CMAKE_TARGET_ALPINE_LINUX. Also note that I saw the warnings with lld 12. Otherwise LGTM. Thanks!

jkotas

Thanks

clamp03 · 2023-04-25T01:57:37Z

noti to #84834

am11 · 2023-03-20T17:42:19Z

'text': Report an error if DT_TEXTREL is set, i.e., if the position-independent or shared object has dynamic relocations in read-only sections. Don’t report an error if ‘notext’ or ‘textoff’.

Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.

Ref: #83509 (comment)
cc @ayakael

ghost · 2023-03-20T17:42:31Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

-z text does not allow text relocations. -z notext allows text relocations.

Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.

Ref: #83509 (comment)

Author:	am11
Assignees:	-
Labels:	`area-Infrastructure-coreclr`, `community-contribution`
Milestone:	-

am11 · 2023-03-20T17:48:05Z

@ayakael, now we have a docker image:

$ docker run -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x86 --rm \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-x86-alpine \
/runtime/build.sh clr+host+libs -a x86 -cross

Requires three patches: #83464, #83672 and #83682.

ayakael · 2023-03-20T17:51:39Z

@ayakael, now we have a docker image:
$ docker run -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x86 --rm \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-x86-alpine \
/runtime/build.sh clr+host+libs -a x86 -cross
Requires three patches: #83464, #83672 and #83682.

Very nice! Many thanks for upstreaming these.

ayakael · 2023-03-20T21:15:59Z

We may have to extend the condition to include CLR_CMAKE_TARGET_ARCH_RISCV64

I'm testing #82294, and encountering similar error that -z notext should fix: https://lab.ilot.io/ayakael/dotnet-stage0/-/jobs/1488

I've tried extending the condition, but the error still persists when linking libcoreclr.so. artifacts/obj/coreclr/linux.riscv64.Release/dlls/mscoree/coreclr/CMakeFiles/coreclr.dir/link.txt includes the relevant linker arg.

sbomer

Merge conflict with #84148 needs to be resolved by adding same flag under CLR_CMAKE_TARGET_ALPINE_LINUX. Also note that I saw the warnings with lld 12. Otherwise LGTM. Thanks!

jkotas

Thanks

clamp03 · 2023-04-25T01:57:37Z

noti to #84834

am11 · 2023-03-20T17:42:19Z

'text': Report an error if DT_TEXTREL is set, i.e., if the position-independent or shared object has dynamic relocations in read-only sections. Don’t report an error if ‘notext’ or ‘textoff’.

Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.

Ref: #83509 (comment)
cc @ayakael

ghost · 2023-03-20T17:42:31Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

-z text does not allow text relocations. -z notext allows text relocations.

Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.

Ref: #83509 (comment)

Author:	am11
Assignees:	-
Labels:	`area-Infrastructure-coreclr`, `community-contribution`
Milestone:	-

am11 · 2023-03-20T17:48:05Z

@ayakael, now we have a docker image:

$ docker run -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x86 --rm \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-x86-alpine \
/runtime/build.sh clr+host+libs -a x86 -cross

Requires three patches: #83464, #83672 and #83682.

ayakael · 2023-03-20T17:51:39Z

@ayakael, now we have a docker image:
$ docker run -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x86 --rm \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-x86-alpine \
/runtime/build.sh clr+host+libs -a x86 -cross
Requires three patches: #83464, #83672 and #83682.

Very nice! Many thanks for upstreaming these.

ayakael · 2023-03-20T21:15:59Z

We may have to extend the condition to include CLR_CMAKE_TARGET_ARCH_RISCV64

I'm testing #82294, and encountering similar error that -z notext should fix: https://lab.ilot.io/ayakael/dotnet-stage0/-/jobs/1488

I've tried extending the condition, but the error still persists when linking libcoreclr.so. artifacts/obj/coreclr/linux.riscv64.Release/dlls/mscoree/coreclr/CMakeFiles/coreclr.dir/link.txt includes the relevant linker arg.

sbomer

Merge conflict with #84148 needs to be resolved by adding same flag under CLR_CMAKE_TARGET_ALPINE_LINUX. Also note that I saw the warnings with lld 12. Otherwise LGTM. Thanks!

jkotas

Thanks

clamp03 · 2023-04-25T01:57:37Z

noti to #84834

am11 · 2023-03-20T17:42:19Z

'text': Report an error if DT_TEXTREL is set, i.e., if the position-independent or shared object has dynamic relocations in read-only sections. Don’t report an error if ‘notext’ or ‘textoff’.

Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.

Ref: #83509 (comment)
cc @ayakael

ghost · 2023-03-20T17:42:31Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

-z text does not allow text relocations. -z notext allows text relocations.

Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.

Ref: #83509 (comment)

Author:	am11
Assignees:	-
Labels:	`area-Infrastructure-coreclr`, `community-contribution`
Milestone:	-

am11 · 2023-03-20T17:48:05Z

@ayakael, now we have a docker image:

$ docker run -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x86 --rm \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-x86-alpine \
/runtime/build.sh clr+host+libs -a x86 -cross

Requires three patches: #83464, #83672 and #83682.

ayakael · 2023-03-20T17:51:39Z

@ayakael, now we have a docker image:
$ docker run -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x86 --rm \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-x86-alpine \
/runtime/build.sh clr+host+libs -a x86 -cross
Requires three patches: #83464, #83672 and #83682.

Very nice! Many thanks for upstreaming these.

ayakael · 2023-03-20T21:15:59Z

We may have to extend the condition to include CLR_CMAKE_TARGET_ARCH_RISCV64

I'm testing #82294, and encountering similar error that -z notext should fix: https://lab.ilot.io/ayakael/dotnet-stage0/-/jobs/1488

I've tried extending the condition, but the error still persists when linking libcoreclr.so. artifacts/obj/coreclr/linux.riscv64.Release/dlls/mscoree/coreclr/CMakeFiles/coreclr.dir/link.txt includes the relevant linker arg.

sbomer

Merge conflict with #84148 needs to be resolved by adding same flag under CLR_CMAKE_TARGET_ALPINE_LINUX. Also note that I saw the warnings with lld 12. Otherwise LGTM. Thanks!

jkotas

Thanks

clamp03 · 2023-04-25T01:57:37Z

noti to #84834

am11 · 2023-03-20T17:42:19Z

'text': Report an error if DT_TEXTREL is set, i.e., if the position-independent or shared object has dynamic relocations in read-only sections. Don’t report an error if ‘notext’ or ‘textoff’.

Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.

Ref: #83509 (comment)
cc @ayakael

ghost · 2023-03-20T17:42:31Z

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

-z text does not allow text relocations. -z notext allows text relocations.

Starting from binutils' ld 2.35 and lld-15 on linux/x86, if there are text relocations the warning is issued by default.

Ref: #83509 (comment)

Author:	am11
Assignees:	-
Labels:	`area-Infrastructure-coreclr`, `community-contribution`
Milestone:	-

am11 · 2023-03-20T17:48:05Z

@ayakael, now we have a docker image:

$ docker run -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x86 --rm \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-x86-alpine \
/runtime/build.sh clr+host+libs -a x86 -cross

Requires three patches: #83464, #83672 and #83682.

ayakael · 2023-03-20T17:51:39Z

@ayakael, now we have a docker image:
$ docker run -v$(pwd):/runtime -e ROOTFS_DIR=/crossrootfs/x86 --rm \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-cross-x86-alpine \
/runtime/build.sh clr+host+libs -a x86 -cross
Requires three patches: #83464, #83672 and #83682.

Very nice! Many thanks for upstreaming these.

ayakael · 2023-03-20T21:15:59Z

We may have to extend the condition to include CLR_CMAKE_TARGET_ARCH_RISCV64

I'm testing #82294, and encountering similar error that -z notext should fix: https://lab.ilot.io/ayakael/dotnet-stage0/-/jobs/1488

I've tried extending the condition, but the error still persists when linking libcoreclr.so. artifacts/obj/coreclr/linux.riscv64.Release/dlls/mscoree/coreclr/CMakeFiles/coreclr.dir/link.txt includes the relevant linker arg.

sbomer

Merge conflict with #84148 needs to be resolved by adding same flag under CLR_CMAKE_TARGET_ALPINE_LINUX. Also note that I saw the warnings with lld 12. Otherwise LGTM. Thanks!

jkotas

Thanks

clamp03 · 2023-04-25T01:57:37Z

noti to #84834

ghost added community-contribution Indicates that the PR has been added by a community member area-Infrastructure-coreclr Only use for closed issues labels Mar 20, 2023

am11 requested a review from janvorli March 20, 2023 17:42

ayakael reviewed Mar 21, 2023
View reviewed changes

Comment threadsrc/coreclr/CMakeLists.txt Outdated

Specify -z notext on linux-musl-x86
65877a9

am11 force-pushed the feature/build/linux-musl-x86 branch from f9f7812 to 65877a9Compare March 21, 2023 16:33

build-analysisBot mentioned this pull request Mar 21, 2023
Arm32: System.Threading.Tasks.Dataflow.Tests failing with NRE #80857
Closed

sbomer mentioned this pull request Apr 7, 2023
Build on CBL-mariner host with rootfs #84148
Merged

jeffschwMSFT requested a review from sbomer April 17, 2023 20:05

sbomer approved these changes Apr 18, 2023
View reviewed changes

Merge branch 'main' into feature/build/linux-musl-x86
737f37e

am11 changed the title ~~Specify -z notext on linux-musl-x86~~Specify -z notext on linux-musl-x86 and riscv64Apr 24, 2023

am11 mentioned this pull request Apr 24, 2023
Update RISCV64 image dotnet/dotnet-buildtools-prereqs-docker#854
Closed

Fix riscv64 build with clang/lld v15+
465f01e

am11 requested a review from jkotas April 24, 2023 16:16

jkotas reviewed Apr 24, 2023
View reviewed changes

Comment threadsrc/coreclr/vm/exceptionhandling.cpp Outdated

Inline visibility attribute
cde6b8f

build-analysisBot mentioned this pull request Apr 24, 2023
Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009
Open
2 tasks

jkotas closed this Apr 24, 2023

jkotas reopened this Apr 24, 2023

Fix gcc build
e71b1f5

jkotas approved these changes Apr 25, 2023
View reviewed changes

build-analysisBot mentioned this pull request Apr 25, 2023
Could not load file or assembly 'Microsoft.CodeAnalysis.NetAnalyzers #84995
Closed

jkotas merged commit 9f07f65 into dotnet:mainApr 25, 2023

clamp03 mentioned this pull request Apr 25, 2023
[RISC-V] Add RISC-V CI #85289
Merged

ghost locked as resolved and limited conversation to collaborators May 25, 2023

am11 deleted the feature/build/linux-musl-x86 branch July 11, 2024 12:35