Skip to content

[release/7.0] SyntaxValueProvider: avoid performance issue with syntax list containing many items - #83743

Merged
tarekgh merged 4 commits into
release/7.0-stagingfrom
backport/pr-83483-to-release/7.0
Apr 4, 2023
Merged

[release/7.0] SyntaxValueProvider: avoid performance issue with syntax list containing many items#83743
tarekgh merged 4 commits into
release/7.0-stagingfrom
backport/pr-83483-to-release/7.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Mar 21, 2023•
edited by cston
Loading

Copy link
Copy Markdown
Contributor

Backport of #83483 to release/7.0

/cc @ericstj@cston

Customer Impact

Original issue: dotnet/roslyn#66475
When a source file contains a large array, performance of compilation degraded substantially (customer case was 50x observed build perf). This bug will appear as a regression from GA since this was introduced in the servicing change #72219.

Testing

Test added to cover this scenario.

The repro from dotnet/roslyn#66475 (comment) uses the implementation of SyntaxValueProvider.ForAttributeWithSimpleName from Microsoft.CodeAnalysis.dll rather than System.Text.Json.SourceGeneration.dll however, and is not affected by this change in 7.0.

Risk

Low. This just adds an additional forward iteration.

  • Package Authoring

@ghost

ghost commented Mar 21, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #83483 to release/7.0

/cc @ericstj@cston

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-Extensions-Logging

Milestone:-

@ericstj

ericstj commented Mar 21, 2023

Copy link
Copy Markdown
Member

Needs package changes for JSON and Logging

@build-analysisbuild-analysisBot mentioned this pull request Mar 21, 2023
Closed
@ericstjericstj added the Servicing-consider Issue for next servicing release review label Mar 28, 2023
@rbhandarbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Mar 28, 2023
@rbhandarbhanda added this to the 7.0.6 milestone Mar 28, 2023
@carlossanlop

carlossanlop commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

I'm retargeting this PR to the new release/7.0-staging branch, which is the one that we will use from now on for servicing fixes.

Repo maintainers will now be allowed to merge their own servicing PR as long as it meets the requirements:

  • It is approved by Tactics (signaled by adding the Servicing-approved label).
  • It's signed-off by an area owner.
  • The CI is green, or the failures are investigated as unrelated.
  • And if the PR touches an OOB package, the necessary OOB authoring changes are added.

The new process is described here: runtime/docs/project/library-servicing.md.

The infra team will be actively monitoring servicing PRs to ensure all requirements are met and to help with any issues.

Let me know if you have any questions.

@carlossanlop
carlossanlop changed the base branch from release/7.0 to release/7.0-stagingMarch 28, 2023 21:01
carlossanlop
carlossanlop approved these changes Mar 28, 2023
View reviewed changes

@carlossanlopcarlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOB package changes look good.

@build-analysisbuild-analysisBot mentioned this pull request Mar 29, 2023
Closed
@carlossanlopcarlossanlop added Servicing-approved Approved for servicing release and removed Servicing-approved Approved for servicing release labels Mar 30, 2023
@tarekgh

tarekgh commented Apr 4, 2023

Copy link
Copy Markdown
Member

The CI failures are not related and are known issues. Merging this PR.

@tarekgh
tarekgh merged commit 5301032 into release/7.0-stagingApr 4, 2023
@tarekgh
tarekgh deleted the backport/pr-83483-to-release/7.0 branch April 4, 2023 19:39
@carlossanlopcarlossanlop mentioned this pull request Apr 5, 2023
Merged
@ghostghost locked as resolved and limited conversation to collaborators May 5, 2023
@leecowleecow modified the milestones: 7.0.6, 7.0.7Jun 1, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tarekghtarekghtarekgh approved these changes
+1 more reviewer
@carlossanlopcarlossanlopcarlossanlop approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Extensions-LoggingServicing-approvedApproved for servicing release

Projects

None yet

Milestone

7.0.7

Development

Successfully merging this pull request may close these issues.

7 participants

@ericstj@carlossanlop@tarekgh@leecow@eiriktsarpalis@rbhanda@cston