Skip to content

[release/8.0-preview3] [browser] partial reversal of PR #82826 - #83750

Merged
carlossanlop merged 1 commit into
release/8.0-preview3from
backport/pr-83637-to-release/8.0-preview3
Mar 22, 2023
Merged

[release/8.0-preview3] [browser] partial reversal of PR #82826#83750
carlossanlop merged 1 commit into
release/8.0-preview3from
backport/pr-83637-to-release/8.0-preview3

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Mar 21, 2023•
edited by maraf
Loading

Copy link
Copy Markdown
Contributor

Backport of #83637 to release/8.0-preview3

/cc @maraf@pavelsavara

Customer Impact

Revert of making legacy JS interop trimmable. Blazor depends on it and the feature wasn't working correctly without wasm-tools workload.

Testing

Manual

Risk

None

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

This was referenced Mar 22, 2023
Closed
Closed
Closed
@marafmaraf added the arch-wasm WebAssembly architecture label Mar 22, 2023
@ghost

ghost commented Mar 22, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #83637 to release/8.0-preview3

/cc @maraf@pavelsavara

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone:-

@maraf

maraf commented Mar 22, 2023

Copy link
Copy Markdown
Member

Failures are not related.

@maraf
marafforce-pushed the backport/pr-83637-to-release/8.0-preview3 branch from dbdf86d to de6fa2cCompareMarch 22, 2023 10:05
@marek-safar

marek-safar commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

@carlossanlop@mmitche please merge before releasing

@carlossanlop

carlossanlop commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

@marek-safar@pavelsavara has this been approved by Tactics?

@marek-safar

marek-safar commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

@carlossanlop I was under impression we are still in P3 open build window

@mmitche

mmitche commented Mar 22, 2023

Copy link
Copy Markdown
Member

@leecow Are we doing tactics approval of p3 changes at this point?

@wtgodbewtgodbe mentioned this pull request Mar 22, 2023
Merged
@leecow

leecow commented Mar 22, 2023

Copy link
Copy Markdown
Member

This will need to be approved by Tactics since we've passed code-complete for Preview 3.

@carlossanlopcarlossanlop added the Servicing-approved Approved for servicing release label Mar 22, 2023
@carlossanlopcarlossanlop added this to the 8.0.0 milestone Mar 22, 2023
@carlossanlop

carlossanlop commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

Approved by Tactics via email.

@carlossanlop
carlossanlop merged commit 1074e57 into release/8.0-preview3Mar 22, 2023
@carlossanlop
carlossanlop deleted the backport/pr-83637-to-release/8.0-preview3 branch March 22, 2023 23:06
@ghostghost locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marek-safarmarek-safarmarek-safar approved these changes
@pavelsavarapavelsavarapavelsavara approved these changes
@lewinglewingAwaiting requested review from lewing

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-System.Runtime.InteropServices.JavaScriptServicing-approvedApproved for servicing release

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@maraf@marek-safar@carlossanlop@mmitche@leecow@pavelsavara