Skip to content

Provide support for exposing .NET classes to COM through source generation - #83755

Merged
jkoritzinsky merged 7 commits into
dotnet:mainfrom
jkoritzinsky:ccw
Mar 28, 2023
Merged

Provide support for exposing .NET classes to COM through source generation#83755
jkoritzinsky merged 7 commits into
dotnet:mainfrom
jkoritzinsky:ccw

Conversation

@jkoritzinsky

@jkoritzinskyjkoritzinsky commented Mar 21, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Implement the API defined in #83471 in Ancillary.Interop and add a source generator in ComInterfaceGenerator to provide the expected behavior.

@jkoritzinskyjkoritzinsky added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels Mar 21, 2023
@jkoritzinskyjkoritzinsky added this to the 8.0.0 milestone Mar 21, 2023
@ghost

ghost commented Mar 21, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Implement the API defined in #83471 in Ancillary.Interop.

Author:jkoritzinsky
Assignees:-
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone:8.0.0

This was referenced Mar 22, 2023
Closed
Closed
Closed
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Mar 24, 2023
View reviewed changes
Comment threadsrc/libraries/System.Runtime.InteropServices/tests/Ancillary.Interop/IComExposedDetails.cs
Comment thread...libraries/System.Runtime.InteropServices/tests/Ancillary.Interop/StrategyBasedComWrappers.cs Outdated
Comment threadsrc/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComClassGenerator.cs
Comment threadsrc/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComClassGenerator.cs Outdated
@jkoritzinsky
Add docs and improve incrementality.
786709f
@jkoritzinsky
Allocate the TypeAssociatedMemory to be associated with the ClassInfo…
d244e48
…rmation type instead of the user type. This allows the generator to be more incremental as the class-info type now doesn't need the class name (so a class rename will not result in regenerating the syntax for this step).
@jkoritzinskyjkoritzinsky mentioned this pull request Mar 24, 2023
Closed
AaronRobinsonMSFT
AaronRobinsonMSFT approved these changes Mar 27, 2023
View reviewed changes
Comment thread...libraries/System.Runtime.InteropServices/tests/Ancillary.Interop/IUnknownDerivedAttribute.cs Outdated
Comment thread...libraries/System.Runtime.InteropServices/tests/Ancillary.Interop/IUnknownDerivedAttribute.cs Outdated
elinor-fung
elinor-fung approved these changes Mar 27, 2023
View reviewed changes
Comment thread...libraries/System.Runtime.InteropServices/tests/Ancillary.Interop/ComExposedClassAttribute.cs Outdated
Comment thread...braries/System.Runtime.InteropServices/tests/Ancillary.Interop/GeneratedComClassAttribute.cs Outdated
Comment threadsrc/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComClassGenerator.cs Outdated
Comment threadsrc/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComClassGenerator.cs Outdated
Comment threadsrc/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComClassGenerator.cs
names.Add(iface.ToDisplayString());
}
}
return new ComClassInfo(

@elinor-fungelinor-fungMar 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to warn / bail if there are no interfaces with GeneratedComInterface?

@jkoritzinskyjkoritzinskyMar 28, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's still a valid scenario, but I could see us adding a warning for it. I'll file a follow-up issue for that.

Comment thread...s/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Tests/GeneratedComClassTests.cs
{
}

public unsafe class GeneratedComClassTests

@elinor-fungelinor-fungMar 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the plan to add some of the more complex cases (at least the ones in the ComObjectRedux repo) in a follow-up change?

@jkoritzinskyjkoritzinskyMar 28, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll add those in in a follow-up change.

@build-analysisbuild-analysisBot mentioned this pull request Mar 28, 2023
Closed
@jkoritzinsky

jkoritzinsky commented Mar 28, 2023

Copy link
Copy Markdown
MemberAuthor

Uncategorized failures were #84010

@jkoritzinsky
jkoritzinsky merged commit ce48579 into dotnet:mainMar 28, 2023
@jkoritzinsky
jkoritzinsky deleted the ccw branch March 28, 2023 18:01
@jkoritzinskyjkoritzinsky mentioned this pull request Mar 28, 2023
Closed
@ghostghost locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@elinor-fungelinor-fungelinor-fung approved these changes
@jtschusterjtschusterAwaiting requested review from jtschuster

Assignees

@jkoritzinskyjkoritzinsky

Labels

area-System.Runtime.InteropServicessource-generatorIndicates an issue with a source generator feature

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jkoritzinsky@AaronRobinsonMSFT@elinor-fung